From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by sourceware.org (Postfix) with ESMTPS id B80B53858D39 for ; Thu, 18 May 2023 19:33:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B80B53858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-5529fcf9d43so704001eaf.1 for ; Thu, 18 May 2023 12:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684438432; x=1687030432; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mvt7Fig7g8gApSAn7ZeODJPSPAwEi9iPmc8fIFHLw84=; b=TZtmqeOwkV8kAknr4N4LnFDrRSiHiK2jtJLjH3nmph0K3tw0j/xR8SY6ILAFvCend0 KrVlOCK7iEcMfn/1cnPp85AC1909iKa4Oymq3v7DGSyYascdHOHmtJpHw1IT5cNvSeMd SiJXrJypcMXdMI2UO3eDh9+ov1K63EIzvAPUDI7x0k3MGx5JHakK4dvmstHLlUcRrUPr rOXUnJ9ILOt+tmTmszTed4Id/8ebtcCoQ+vgJzHHPAO9A8hxbFQHxnvvlu/cFK9MUUST oXJQ/OXumXqhDJswXqVnxSJVniHEDLTU2OavZqUEs6RNm8rMLnTJnfiWoXWCAUBJ/DjX M14w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684438432; x=1687030432; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvt7Fig7g8gApSAn7ZeODJPSPAwEi9iPmc8fIFHLw84=; b=Jm9Z0sZq4HufP1XQHZFouETEHOYKRcdc9Ngceh4RbdRq0Hijil+x0U0Z6+DUZoFywG rsfzJCiCYVYcjzQqu8PhWy+c23zoBNH3Mn7oPDPgxpAI8HQPZLArQL1DfoJ5lKBv4Wjq /pE+btAO+PDeyx8rGoTp7lD00cArZtxHf1/jrlSPiBDslr8zSajiDIE8tFEGKJEkJUz5 ibIlZOaa7hEKNICKdJjBiEk3C4CvC1U6OVjImCC82fNaTFNsLJF/89FlCCcIQOMk7Aio xtV45ueTH4uIeZqqYefcGVMsyvrikwMB9uFP+56Q03Em7hu0qP2rReqNQo4AX/Ehtg9o ByaA== X-Gm-Message-State: AC+VfDzkDMOWmpgOfbANH4f0M/KjFuY6esF3B+/BHrr35/5PHSygvTsw 5BPSfmC7DRJqdYulYJDrpvbXP9VsWnu1wfRCsISRq2PHe4Q= X-Google-Smtp-Source: ACHHUZ7ZxfUGryy1TTUgQ27sEdi+PWpHIOZiuz0Ed3Y9joN4TOEKD/f3Sc+bv6jYyuimgn/2kosWuS7DvjEPTZvfRB4= X-Received: by 2002:a4a:924d:0:b0:54f:54b3:cb9c with SMTP id g13-20020a4a924d000000b0054f54b3cb9cmr28502ooh.1.1684438431904; Thu, 18 May 2023 12:33:51 -0700 (PDT) MIME-Version: 1.0 References: <20230517191436.73636-1-bugaevc@gmail.com> <20230517191436.73636-7-bugaevc@gmail.com> <20230517205955.xb53s7fl5exydk2z@begin> <46ecbc3b-637c-9e52-516-ec2f706ac9dc@codesourcery.com> In-Reply-To: <46ecbc3b-637c-9e52-516-ec2f706ac9dc@codesourcery.com> From: Sergey Bugaev Date: Thu, 18 May 2023 22:33:40 +0300 Message-ID: Subject: Re: [RFC PATCH 06/10] hurd: Make sure to not use tcb->self To: Joseph Myers Cc: Samuel Thibault , libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Thu, May 18, 2023 at 9:55=E2=80=AFPM Joseph Myers wrote: > > I suspect this of causing linknamespace test failures: > > Contents of conform/POSIX2008/pthread.h/linknamespace.out: > > [initial] pthread_create -> [libpthread.a(pt-create.o)] __pthread_setup -= > [libpthread.a(pt-setup.o)] hurd_thread_self > > (On x86_64 there's also a localplt test failure: "Extra PLT reference: > libc.so: hurd_thread_self". In addition, x86_64 has a c++-types-check > failure. Thus, neither Hurd configuration has clean results for > compilation tests from build-many-glibcs.py at present.) Thank you, and sorry :| Do I understand it right that this is because of hurd_thread_self being publicly exported and interposable? A quick grep shows that nothing else inside glibc was using hurd_thread_self indeed. Would the right way to resolve this be introducing a hidden __hurd_thread_self and using that? We could also make it __mach_thread_self () + __mach_port_deallocate (), but why do +2 syscalls when we already have all the required info in userspace. What's the C++ type check failure? Surely this patch (nor 2f8ecb58a59eb82c43214d000842d99644a662d1 "hurd: Fix x86_64 _hurd_tls_fork") has modified any public headers? Sergey