From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 2FFC93858D28 for ; Fri, 2 Dec 2022 14:04:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2FFC93858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x333.google.com with SMTP id r9-20020a05683001c900b0066e6e7a751eso2984733ota.0 for ; Fri, 02 Dec 2022 06:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=wJsT/xj/B7eHI8bQUCP+nE8bz9flpw/yLM+MWSZu5Fk=; b=DhXShnP9S3yIPYBzePDa4gPBD8RyfViPNtVqodHBZKIFCRA3qT+9e+3ptQN+MUy4oM N3uUn2qqca3vq5DrI26hpeEQEc3cDlpTLytBiR/Kg/GMbc+VuA0O6Y8Qq0OblEDWA9qh dwyVnUjxLMY6HwXBRKR18mC6w7sXwE+yOX9SIv/F2LRnYZp1mLuivJ3uGjqSOjpSMclX FEKQjYF3Waouyp0ImHsqRl0TzslQApMUIULWC8aycS0Kbh1TyjWTNiCQKWOWX27gfJd7 2ZWhxTXmg5kWvNeqFn8TUxJQMUSwkChkNbuC78NyEatZ16qINKFLeZiX3ppz3rXwKx9G 1BLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wJsT/xj/B7eHI8bQUCP+nE8bz9flpw/yLM+MWSZu5Fk=; b=4Ft7UlbPTbVbI0FQEtJyUz5dz0B4+xIYs+ArbTw8mwVigqbkP226nJPrzg/K4r/Bv4 bcmLzzaIxEyH4ZQEeA45C7GKb06zH97B6sdPeA6RYvuN+HY3tRmottLwoZbhJbc3h0Yz coj4LLTsMXRW/iQJOXZn2A2tOt+16k803+8g6aj3s73ZsGGRAf4BpNllYQgotAygmTfF V0KfqKkEBYKmm4Uzk+7+V7AfuxitMQnxnQau2XxVwRvO72j0dlYzLBMMAmwgN53FnupD KZSDRcss4H9Ilxy7Gna1Ou7S9fr9mg24OReybQcj2sqwaYR66w77wFAaEn/r90Za/K3L lLAQ== X-Gm-Message-State: ANoB5pl8vhvfBgEsVKwCD+8+YYBrIBLQZSjPIaq1pfwN2ChNNG8xkAE/ lqY5REjcqp0jLgLISSxV480rPaI4N1e9MorOq09xxlrh3nNwWdAH5LFhBQ== X-Google-Smtp-Source: AA0mqf6/iEZTQp6TRGs8fncn63QcvKIQCMwNxsaCiFqRrZXFGeskUKm+ZTI4Z0ulJAnn2djDAKyBqoIC6NnMPATRWKk= X-Received: by 2002:a05:6830:134a:b0:661:a273:f0c4 with SMTP id r10-20020a056830134a00b00661a273f0c4mr25509013otq.120.1669989890066; Fri, 02 Dec 2022 06:04:50 -0800 (PST) MIME-Version: 1.0 References: <20221202135558.23781-1-bugaevc@gmail.com> In-Reply-To: <20221202135558.23781-1-bugaevc@gmail.com> From: Sergey Bugaev Date: Fri, 2 Dec 2022 17:04:38 +0300 Message-ID: Subject: Re: [PATCH v3] hurd: Make getrandom cache the server port To: bug-hurd@gnu.org, libc-alpha@sourceware.org, samuel.thibault@gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Dec 2, 2022 at 4:56 PM Sergey Bugaev wrote: > + switch (flags) > + { > + case 0: > + cached_server = &urandom_server; > + break; > + case GRND_RANDOM: > + cached_server = &random_server; > + break; > + case GRND_NONBLOCK: > + cached_server = &urandom_server_nonblock; > + break; > + case GRND_RANDOM | GRND_NONBLOCK: > + cached_server = &random_server_nonblock; > + break; > + default: > + return __hurd_fail (EINVAL); > + } > + > + if (flags & GRND_RANDOM) > + random_source = "/dev/random"; > + if (flags & GRND_NONBLOCK) > + open_flags |= O_NONBLOCK; > + /* No point in passing either O_NOCTTY, O_IGNORE_CTTY, or O_CLOEXEC > + to file_name_lookup, since we're not making an fd. */ Ooops, the indentation is off here, and of course I'm only seeing this after having sent the patch. Nor did GCC warn me. Sigh. If the patch is otherwise alright, could you please fix that when committing? If it's not, I'll fix it in v4. Sergey