From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 154363858D39 for ; Mon, 3 Apr 2023 20:11:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 154363858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x22f.google.com with SMTP id l18so22663861oic.13 for ; Mon, 03 Apr 2023 13:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680552681; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c1sHIievEueW1vu0csgzA8rh3x8fsXOtB3vb5dwJaP8=; b=WeY7DJ7X8SDRkrpnpGDwHpx3zQarU09NzI+PXxK3Wp6zLeM+kBnV8PHzmOLhoVQ8vS F984uFo0Ue62yV6qy0j1GqWgDgicvG8G5Jf1Y9uGIizpLDZGMkH+jEuUiwYEF7M/ICwC F+LyPDDajFNuNh1LML2FQlxek4ZM4w+8VDiMmC91zVUMXepRMPdXMGCTH8Qy4vu6q2fe /jrtYhUIoj7rZUSYDXR3j+4qyWJRCR+YgL7li7le2FjpaDLi5P/USV11EZxxblrSHGSy 1VSM5lNP6Kl+Qwf+ANl23Byz7PYry0CefVnWkFWwF7gDNex/TIZbUnqgadDe3enC4WGO ixRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680552681; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c1sHIievEueW1vu0csgzA8rh3x8fsXOtB3vb5dwJaP8=; b=6AiwCZlJMdCwa1EjS+9mZ1Vg5HaiBYIF26MwjF0JoF/EpQBCDH8iY/2AnBXNXAXZjg JLiNpDJ87HGqGwDDjNJuGZY3zUQ49g8gphicLGWZPrZUreAgxpTC+SvshJKZ6aJMktRp GWlc0VF6x24v1OVt2ETKY7qHYwQJ9SRouzwftyrPvq5Ob11RlH2v6uRE5HgNwmKj++vC /J70+kEQD61IOj5FOM01BvOOkXBtvV5WpTsjDnT7P2LvgvfDUz+RWRcwa/tTu5vN2IcG voC7dsmCq/EaAgDHbdpKFD9bARin9BYUFNefx27e0E6SgXjiEjxCsXB1v6rojVL8eD2e 7+Yg== X-Gm-Message-State: AAQBX9e7Ywpegt3cd233vIPx27Ban+0vSCkkvCiaAEJs5/OO4POFRusN IQnqelx1OAh2Wsum1SV7iPRfPb29r9XNrPcmI/0= X-Google-Smtp-Source: AKy350baJcQ5Q7yM6HdpWh98sf8YGQTiFI3GCegQ64jdTv6wvWmU+x00xe3XSA3GJl3mbILKCvRbOBW/NLFer6o1V3w= X-Received: by 2002:aca:674a:0:b0:384:3518:df33 with SMTP id b10-20020aca674a000000b003843518df33mr197774oiy.4.1680552679883; Mon, 03 Apr 2023 13:11:19 -0700 (PDT) MIME-Version: 1.0 References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-14-bugaevc@gmail.com> <20230402230934.djvtyoh5dayv23c2@begin> In-Reply-To: From: Sergey Bugaev Date: Mon, 3 Apr 2023 23:11:08 +0300 Message-ID: Subject: Re: [RFC PATCH glibc 13/34] x86-64: Disable prefer_map_32bit_exec tunable on non-Linux To: "H.J. Lu" , Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 3, 2023 at 10:02=E2=80=AFPM H.J. Lu wrote= : > Or something like this. Or like that, yeah! On a second thought, I actually like Samuel's idea (ifdef MAP_32BIT): instead of only building this piece of code when the tunable *is* defined, we'd build it when the tunable *should be* defined (that is, when your port has MAP_32BIT). And if you get build errors, that is your not-so-gentle reminder to go and define the tunable for your port. What do you think? Sergey