From: Will Newton <will.newton@linaro.org>
To: James Lemke <jwlemke@mentor.com>
Cc: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] fix to malloc checking
Date: Wed, 26 Nov 2014 09:40:00 -0000 [thread overview]
Message-ID: <CANu=DmhJ3FqfxCKqoVyuS77UiJ92V8+a3ZuKo3xPX1pxppbxkw@mail.gmail.com> (raw)
In-Reply-To: <5474FA02.6020701@mentor.com>
On 25 November 2014 at 21:52, James Lemke <jwlemke@mentor.com> wrote:
> Ping!
> Any opinions about committing this?
> Cheers, Jim.
>
> https://sourceware.org/ml/libc-alpha/2014-11/msg00219.html
> https://sourceware.org/ml/libc-alpha/2014-11/msg00470.html
This looks ok to me, although there are some minor style issues, e.g.:
There should be a space after casts.
There's a bracket on its own that should be moved onto the line above.
A couple of if statements have some leading space that should not be there.
--
Will Newton
Toolchain Working Group, Linaro
next prev parent reply other threads:[~2014-11-26 9:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 18:45 James Lemke
2014-11-11 20:19 ` Andreas Schwab
2014-11-11 21:18 ` James Lemke
2014-11-11 21:31 ` Andreas Schwab
2014-11-11 21:43 ` James Lemke
2014-11-11 20:32 ` Joseph Myers
2014-11-11 21:07 ` James Lemke
2014-11-18 20:24 ` James Lemke
2014-11-25 21:52 ` James Lemke
2014-11-26 9:40 ` Will Newton [this message]
2014-11-26 19:30 ` James Lemke
2014-11-29 1:42 ` Siddhesh Poyarekar
2014-12-11 11:03 ` Andreas Schwab
2014-12-11 21:23 ` James Lemke
2015-02-04 18:56 ` James Lemke
2015-02-09 15:04 ` James Lemke
2015-02-17 16:22 ` James Lemke
2015-03-02 3:09 ` Mike Frysinger
2015-03-11 18:00 ` James Lemke
2015-03-31 14:15 ` James Lemke
2015-04-05 3:06 ` Mike Frysinger
2015-04-07 13:44 ` James Lemke
2015-04-08 3:11 ` Mike Frysinger
2015-04-08 15:41 ` James Lemke
2015-04-12 8:09 ` Mike Frysinger
2015-04-15 15:04 ` James Lemke
2015-04-27 13:23 ` James Lemke
2015-05-05 17:09 ` James Lemke
2015-05-18 7:35 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANu=DmhJ3FqfxCKqoVyuS77UiJ92V8+a3ZuKo3xPX1pxppbxkw@mail.gmail.com' \
--to=will.newton@linaro.org \
--cc=jwlemke@mentor.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).