From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by sourceware.org (Postfix) with ESMTPS id 1CF28385843A for ; Wed, 6 Mar 2024 10:39:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CF28385843A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=canonical.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CF28385843A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.125.188.122 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709721578; cv=none; b=LEZxWZBK7eDhgIpCrD4tdvFZlLggiYGKKdbxxwPTHGqWM+KBs0MGQFXZzMqhyA+4Z2p7jCS8UF8kTou0oFuss0wyH14Hs2aC0Z9TQaAAuHFzxAv20ytUc541hbFuPnJySBNTvQUYpWAkCi0NlH4hVX9wDLEB9IKxkQe2VI2dcsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709721578; c=relaxed/simple; bh=h4ZJ0FCvM/2USmXo/ONRzdaQB61NvALtIWyZa18nhaw=; h=DKIM-Signature:From:MIME-Version:Date:Message-ID:Subject:To; b=MhXvjP+lVr8yn9FgWEI9i6xfYBSfsNWxD2fQoIi4y5lJOBlfRvnmq9c2WpxTK5yqMzMDOEt1W3wUme5MW7rClFQpAwc5ehPDs0hrC1vdPY+L7uToPWWQ/mB2cfeuAoP9yx9TQWA6ArkrI96pwv1IAL5xhcitQhBCJ5SQ2vWxvCY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 2409C3F148 for ; Wed, 6 Mar 2024 10:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1709721575; bh=siXrmfgW4ph1DlYbM9OpshMMAAOon1/dgsgOqYm/c9g=; h=From:MIME-Version:In-Reply-To:References:Date:Message-ID:Subject: To:Cc:Content-Type; b=gjJt5eLGHqGYQFooJcED3oQ2vt/ZxnT1r9qsLvNOlu4r8SMOhw8vMh+X4vZGVnnXo M0ludvJZQWeZwCBxgW8/9MbdYbqU70GWpH1lIYD2MxGAkS6w0feVvRlizh3+aZo0Km xU5g5zgoCx1L7Kw3AUbIbS+doR6aK79GsjGuiHYo0FfY5xM+5ykbd83eYIEb7I4HGi rEScHoCujrOW9Dd7uXiXcB9eGvHEVrH9icXECxTVSyd61VLQHs+2pv3IPK8ouLnxc2 4zqWd7p42ZeLIJnW5fZf2/Fs+o6RcVzJ85NNVgk160fauub3gcQaDxsJfk51r0xLle LgQCAt+e+HISw== Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-29a94e1bc5aso5131765a91.3 for ; Wed, 06 Mar 2024 02:39:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709721573; x=1710326373; h=cc:to:subject:message-id:date:references:in-reply-to:mime-version :user-agent:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=siXrmfgW4ph1DlYbM9OpshMMAAOon1/dgsgOqYm/c9g=; b=ilTQi1tD6/hnDSqWbz8XhgI9dHhRK49zhdLySdB/6Z0M7Bq9Fk4NnoTBmkehcWdpKT 56s/2/+0qp+1QGrD7oh0uE5Wto0r/fesXUbksnC7SM0QMNrPX8nM8gauk6laUJSfEgLy FCglIgdMFpb3plWf2YoxaqGQ31o/dpt8l2yEKtbIzVxvVDNZ/UOF+ZY1vhVrLitbiZ7N /5yPYRNjHyse8h0kvuOPmbnY7mLBuEwL+WIfODrJ0kq3MFzovIqxezJv6EEfrlkgUeAt Z6JZd5vpNdbSGByu6Cu6wupIyFqDcNdhhYT0LMuUpJ/eTee8oOHGYlmRRD5vahk6py6w Pd+Q== X-Gm-Message-State: AOJu0YztP2FhhVS7l2AhceXckCf6XxpqAnvDutQVloQRKHCKYrOoau2a zBndf3aOQ+cEeSeKwyQ8vfGU0/K0Q04uWr3nC78ppOUDp1ZEd9xLHajrcJBHieydcRFVmIH1pIG CFVcZrLZqiRTjgiWDzL3B7GahQXv2HH4M8ZrnfrsQXcN9wPwyLw1HORpqVNSyJed1W++fwDwSMF HvlSmSgLkZloUubrD2JwHt4grfrA1lpB1XZVnY+qVGlHL9uYbUP/e7OlS7aFg= X-Received: by 2002:a17:90b:1055:b0:299:2db9:1ad4 with SMTP id gq21-20020a17090b105500b002992db91ad4mr10901262pjb.40.1709721573637; Wed, 06 Mar 2024 02:39:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMXnbDpGac4yr+9PXurtGdBFhGMnGyrgWKzHys1ZSS8NhAP+B1lyzqrFo8C9G1rTd15S9JNSxG2djj16zvRVs= X-Received: by 2002:a17:90b:1055:b0:299:2db9:1ad4 with SMTP id gq21-20020a17090b105500b002992db91ad4mr10901249pjb.40.1709721573303; Wed, 06 Mar 2024 02:39:33 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Mar 2024 02:39:32 -0800 From: Simon Chopin User-Agent: Dodo MIME-Version: 1.0 In-Reply-To: <20240112185846.24483-1-palmer@rivosinc.com> References: <20240112185846.24483-1-palmer@rivosinc.com> Date: Wed, 6 Mar 2024 02:39:32 -0800 Message-ID: Subject: RE: [PATCH] Don't check signatures in build-many-glibcs.py To: Palmer Dabbelt Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Palmer, thanks for the patch. On ven. 12 janv. 2024 10:58:46, Palmer Dabbelt wrote: > I sign commits and have signature verification on in git. Maybe that's > a bad idea because it trips up a bunch of scripts, but it's pretty easy > to just force skipping signature verification here. Presumably, there's all kind of things that could go wrong if the user has some particular git configuration. I feel like this particular can of worms could be side-stepped entirely if we just set GIT_CONFIG_GLOBAL to /dev/null (and perhaps used GIT_CONFIG_NOSYSTEM=1 for good measure) to clear any interfering custom config. WDYT? > > Signed-off-by: Palmer Dabbelt > --- > scripts/build-many-glibcs.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index ec2ded6e56..f9cf14c94d 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -931,7 +931,7 @@ class Context(object): > if self.replace_sources: > subprocess.run(['git', 'clean', '-dxfq'], > cwd=self.component_srcdir(component), check=True) > - subprocess.run(['git', 'pull', '-q'], > + subprocess.run(['git', 'pull', '-q', '--no-verify-signatures'], > cwd=self.component_srcdir(component), check=True) > else: > if self.shallow: > -- > 2.43.0 >