From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by sourceware.org (Postfix) with ESMTPS id 641DB3858D37 for ; Mon, 23 Oct 2023 10:11:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 641DB3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=canonical.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 641DB3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.125.188.123 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698055899; cv=none; b=D0Qs9fJUMyfbHOGiYOxyFKGKhn5Q2V0VpreYq6btVMTDXjmot0Sp0+hjiOA/++qOJb2io2WkL7Pd1QNT2H6KtEEZ2qgGgCtBvfq9Vs8bA4a17xxZH2yvqPLj8i4p5vekuUXuVFDyB6d65UzFSE3s4N6YHlruL7c4JSRcWr+s0Ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698055899; c=relaxed/simple; bh=pJOLIa+JM4grca1B0UE5iRAJq+PKtWf5JBRO9M8eazg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=GS+UE9iY/tJlgFx3+d8gJxc22Bfeiy+WZ4mx6eAeY4R0knw5sS0VRX6mT7aP3FLqzTzGMTpxE2VJH8oXlwWtf55rlFEqRIMZn/ghUi4sGWdPe3ayJJxwU+yCuqC6p+umthPzC1zG51/fyZDcQ+HJcKIApxgHJkeCauER+mHtWPo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id BCB6C3F63D for ; Mon, 23 Oct 2023 10:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1698055895; bh=KO9UHsTnyv4HFHdGoHbyooDE6XLlr2V9UhVS/wTZFdo=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Content-Type; b=npOhKMATLND8C2+pOZcqWunMaWniOFrnFXJDTrlZy6xBGiTL4Rx0cahPmAv5wTeMT Mfc543aTC9rWYFxeU4E+OmfGz6wuL7CdEOY8OwaA6n1Cm74Hp4LgOo26tHSQjcEhFN SVbLdhKuM6dL8xqk0SitQNW2SkcNQPbGWW43sq1S2zvkw84JN2F/Jph8UPl0MJ2rWJ JkrvHITpUEUFi/Y5Fv10DKItHq6P6UnZpHV1gyPNYybGk4muufgsaUrhNrdDFj3JtC bSi5B3Oj/tcStbeBxjQLCDPzyEDxgdPZcvm4V9qOr0HRRXtaZ1z7WI0c1KjjCevoaO 5ar/fkjfq8xzg== Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6c4e6affec4so4657733a34.1 for ; Mon, 23 Oct 2023 03:11:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698055894; x=1698660694; h=to:subject:message-id:date:user-agent:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KO9UHsTnyv4HFHdGoHbyooDE6XLlr2V9UhVS/wTZFdo=; b=anm6YFtq9yTyUd6Za0/WaKnznPnuy4CavXu2l8d6+XDKcgvpvegDFA2PMEBb6LrZKh wpELbVWUDF+yce7yejNXoZbsw5w3wf4C5IJccHZJK+VtGvyPZQzfNtmtXiextrPodNaU y14+Y5EtcM7SzL1wNqtbpY+MsOG0x05bxbikTCyPMJMa8j/dQd3Lq0fN8xFbradoMHa2 mdXTFIaMCgTDBX33wnVj0Z4HIlN6483OKhCctMkJn3PAG/3rYdq4NrEfaADF8qHE6YZS xF/JKT645KZgZYh4zlx0ySbt7/+AM7R5L1jrG33gPwmJJdkL/sv0J0qWn6ZRY5cDyyYS FBbg== X-Gm-Message-State: AOJu0YxW0v90FXnQi5uVPmKrjBlh8gxvgo8b3Aapqy/cHiCgGMlWdUL9 r294dJNaa1Jnub4ydVTyA2Lc7OZPp0nnsLhPAgd6ezOrz3UZcLkIKVvrBbtWqP7BWEW9H92wXdm /EPSCI7gdlqzLcMcUCR+yFr+EqulMiKTN5SvilFAPLPw2SIhh+pa6rwHTJdONog== X-Received: by 2002:a05:6830:2010:b0:6c2:1ff0:b2e1 with SMTP id e16-20020a056830201000b006c21ff0b2e1mr4206136otp.4.1698055894521; Mon, 23 Oct 2023 03:11:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHHGSwOdp7VKTSwMAQVdup3A6ysf6BrYZTfb2CPXjxxcj7FzjpygZW7osgGHXgMm85AXBdTBVMFjSvu4r0CcXE= X-Received: by 2002:a05:6830:2010:b0:6c2:1ff0:b2e1 with SMTP id e16-20020a056830201000b006c21ff0b2e1mr4206133otp.4.1698055894243; Mon, 23 Oct 2023 03:11:34 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 23 Oct 2023 03:11:33 -0700 MIME-Version: 1.0 In-Reply-To: References: <20231005125431.3958485-1-simon.chopin@canonical.com> From: Simon Chopin User-Agent: alot/0.10 Date: Mon, 23 Oct 2023 03:11:33 -0700 Message-ID: Subject: Re: [PATCH] test-container: disable ld.so system cache on DSO detection To: Adhemerval Zanella Netto , libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! Quoting Adhemerval Zanella Netto (2023-10-17 16:48:55) > > > On 05/10/23 09:54, Simon Chopin wrote: > > When building the testroot, the script runs the newly built ld.so on a > > couple of binaries in order to copy over any additional libararies > > s/libararies/libraries > > > needed. However, if the dependencies are found in the system cache, it > > will be copied over using that path. > > > > This is problematic if the system ld.so and the one built don't have the > > exact same search configuration. We encountered this in Ubuntu, where we > > build a variant of libc with -fno-omit-frame-pointer for accurate > > performance profiling. > > > > This variant is built using a non-standard slibdir to be able to be > > co-installed with the default library (e.g. slibdir = /lib/libc6-prof). > > Since we have /lib pointing to /usr/lib, any additional dependency > > should still be reachable via /usr. However, resolving via the cache > > might result in the additional DSOs being copied into $testroot/lib, out > > of the search path in the container. > > > > The problem has been triggered by 1d5024f4f052c12e404d42d3b5bfe9c3e9fd27c4 > > ("support: Build with exceptions and asynchronous unwind tables [BZ #30587]") > > which introduced a dependency on libgcc_s.so.1 under some circumstances. > > > > Downstream bug: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/2031495 > > It makes sense to inhibit cache on testroot creation, although default > system dirs will always be used. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella Sorry, my experience of ML-based contributions is pretty limited. Am I expected to send a V2 to fix the typo in the commit log? If I need to send a V2, should it include the Reviewed-by tag?