* Re: [PATCH][BZ 17293] Fix sorting order for Ukrainian locale
[not found] <CAOZT1o0Sfsnx89=TvSjgcLr_sWdPoWH8oNg1sq6Bmg+JgCdfug@mail.gmail.com>
@ 2015-04-13 13:32 ` Andriy Rysin
2015-05-12 14:55 ` Siddhesh Poyarekar
0 siblings, 1 reply; 6+ messages in thread
From: Andriy Rysin @ 2015-04-13 13:32 UTC (permalink / raw)
To: siddhesh; +Cc: libc-alpha
Hi Siddhesh
In the introduction for the official orthography rules for Ukrainian
language (http://spelling.ulif.org.ua/peredmova.htm) there's a note
that only apostrophe does not affect order of the words when sorting.
As could be seen from the official alphabet the soft sign
(U+044C/U+042C) has its hard position and thus affects the order and
also letters "е" and "є" (CYR-IE: U+0435/U+0415 and UKR-IE:
U+0454/U+0404) have their own positions and should have separate place
when sorting.
This also corresponds to official Unicode collation chart for these
letters: http://unicode.org/charts/collation/chart_Cyrillic.html
Thanks,
Andriy
2015-03-13 11:17 GMT-04:00 Andriy Rysin <arysin@gmail.com>:
> 2015-02-10 Andriy Rysin <arysin@gmail.com>
>
> [BZ #17293]
> uk_UA: Fix sorting order for Ukrainian locale
> * localedata/Makefile:
> * localedata/locales/uk_UA:
> * localedata/uk_UA.in: New file.
>
>
>
> From 060dca0cabdd85de4ae2cbfad3e3027539987252 Mon Sep 17 00:00:00 2001
> From: Andriy Rysin <arysin@gmail.com>
> Date: Tue, 10 Feb 2015 19:46:56 -0500
> Subject: [PATCH] Fix sorting order for Ukrainian locale: soft sign has its
> own position and UKR-IE should follow CYR-IE; added collation tests for
> Ukrainian locale symbols
>
> ---
> localedata/Makefile | 4 +-
> localedata/locales/uk_UA | 116 ++++++++++++++++++++++++-----------------------
> localedata/uk_UA.in | 56 +++++++++++++++++++++++
> 3 files changed, 117 insertions(+), 59 deletions(-)
> create mode 100644 localedata/uk_UA.in
>
> diff --git a/localedata/Makefile b/localedata/Makefile
> index d1218f5..83c7047 100644
> --- a/localedata/Makefile
> +++ b/localedata/Makefile
> @@ -37,7 +37,7 @@ test-srcs := collate-test xfrm-test tst-fmon
> tst-rpmatch tst-trans \
> tst-ctype tst-langinfo tst-langinfo-static tst-numeric
> test-input := de_DE.ISO-8859-1 en_US.ISO-8859-1 da_DK.ISO-8859-1 \
> hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 tr_TR.UTF-8 fr_FR.UTF-8 \
> - si_LK.UTF-8
> + si_LK.UTF-8 uk_UA.UTF-8
> test-input-data = $(addsuffix .in, $(basename $(test-input)))
> test-output := $(foreach s, .out .xout, \
> $(addsuffix $s, $(basename $(test-input))))
> @@ -106,7 +106,7 @@ LOCALES := de_DE.ISO-8859-1 de_DE.UTF-8
> en_US.ANSI_X3.4-1968 \
> hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 ja_JP.SJIS fr_FR.ISO-8859-1 \
> nb_NO.ISO-8859-1 nn_NO.ISO-8859-1 tr_TR.UTF-8 cs_CZ.UTF-8 \
> zh_TW.EUC-TW fa_IR.UTF-8 fr_FR.UTF-8 ja_JP.UTF-8 si_LK.UTF-8 \
> - tr_TR.ISO-8859-9 en_GB.UTF-8
> + tr_TR.ISO-8859-9 en_GB.UTF-8 uk_UA.UTF-8
> LOCALE_SRCS := $(shell echo "$(LOCALES)"|sed 's/\([^ .]*\)[^ ]*/\1/g')
> CHARMAPS := $(shell echo "$(LOCALES)" | \
> sed -e 's/[^ .]*[.]\([^ ]*\)/\1/g' -e s/SJIS/SHIFT_JIS/g)
> diff --git a/localedata/locales/uk_UA b/localedata/locales/uk_UA
> index d9194b8..2bd30eb 100644
> --- a/localedata/locales/uk_UA
> +++ b/localedata/locales/uk_UA
> @@ -349,61 +349,63 @@ collating-symbol <UKR-GHE>
> % Soft sign '<U044C>' may follow only this set of nine characters
> [<U0432><U0434><U0437><U043B><U043D><U0440><U0441><U0442><U0446>].
> % It only softens pronunciation of these characters so it's should not impact
> % sorting.
> -
> -
> -collating-symbol <V+SS>
> -collating-element <V-SS> from "<U0412><U042C>"
> -collating-element <V-ss> from "<U0412><U044C>"
> -collating-element <v-SS> from "<U0432><U042C>"
> -collating-element <v-ss> from "<U0432><U044C>"
> -
> -collating-symbol <D+SS>
> -collating-element <D-SS> from "<U0414><U042C>"
> -collating-element <D-ss> from "<U0414><U044C>"
> -collating-element <d-SS> from "<U0434><U042C>"
> -collating-element <d-ss> from "<U0434><U044C>"
> -
> -collating-symbol <Z+SS>
> -collating-element <Z-SS> from "<U0417><U042C>"
> -collating-element <Z-ss> from "<U0417><U044C>"
> -collating-element <z-SS> from "<U0437><U042C>"
> -collating-element <z-ss> from "<U0437><U044C>"
> -
> -collating-symbol <L+SS>
> -collating-element <L-SS> from "<U041B><U042C>"
> -collating-element <L-ss> from "<U041B><U044C>"
> -collating-element <l-SS> from "<U043B><U042C>"
> -collating-element <l-ss> from "<U043B><U044C>"
> -
> -collating-symbol <N+SS>
> -collating-element <N-SS> from "<U041D><U042C>"
> -collating-element <N-ss> from "<U041D><U044C>"
> -collating-element <n-SS> from "<U043D><U042C>"
> -collating-element <n-ss> from "<U043D><U044C>"
> -
> -collating-symbol <R+SS>
> -collating-element <R-SS> from "<U0420><U042C>"
> -collating-element <R-ss> from "<U0420><U044C>"
> -collating-element <r-SS> from "<U0440><U042C>"
> -collating-element <r-ss> from "<U0440><U044C>"
> -
> -collating-symbol <S+SS>
> -collating-element <S-SS> from "<U0421><U042C>"
> -collating-element <S-ss> from "<U0421><U044C>"
> -collating-element <s-SS> from "<U0441><U042C>"
> -collating-element <s-ss> from "<U0441><U044C>"
> -
> -collating-symbol <T+SS>
> -collating-element <T-SS> from "<U0422><U042C>"
> -collating-element <T-ss> from "<U0422><U044C>"
> -collating-element <t-SS> from "<U0442><U042C>"
> -collating-element <t-ss> from "<U0442><U044C>"
> -
> -collating-symbol <TSE+SS>
> -collating-element <TS-SS> from "<U0426><U042C>"
> -collating-element <TS-ss> from "<U0426><U044C>"
> -collating-element <ts-SS> from "<U0446><U042C>"
> -collating-element <ts-ss> from "<U0446><U044C>"
> +%
> +% Note: in the official alphabet the soft sign is a letter and has a
> hard position in the order
> +
> +
> +%collating-symbol <V+SS>
> +%collating-element <V-SS> from "<U0412><U042C>"
> +%collating-element <V-ss> from "<U0412><U044C>"
> +%collating-element <v-SS> from "<U0432><U042C>"
> +%collating-element <v-ss> from "<U0432><U044C>"
> +%
> +%collating-symbol <D+SS>
> +%collating-element <D-SS> from "<U0414><U042C>"
> +%collating-element <D-ss> from "<U0414><U044C>"
> +%collating-element <d-SS> from "<U0434><U042C>"
> +%collating-element <d-ss> from "<U0434><U044C>"
> +%
> +%collating-symbol <Z+SS>
> +%collating-element <Z-SS> from "<U0417><U042C>"
> +%collating-element <Z-ss> from "<U0417><U044C>"
> +%collating-element <z-SS> from "<U0437><U042C>"
> +%collating-element <z-ss> from "<U0437><U044C>"
> +%
> +%collating-symbol <L+SS>
> +%collating-element <L-SS> from "<U041B><U042C>"
> +%collating-element <L-ss> from "<U041B><U044C>"
> +%collating-element <l-SS> from "<U043B><U042C>"
> +%collating-element <l-ss> from "<U043B><U044C>"
> +%
> +%collating-symbol <N+SS>
> +%collating-element <N-SS> from "<U041D><U042C>"
> +%collating-element <N-ss> from "<U041D><U044C>"
> +%collating-element <n-SS> from "<U043D><U042C>"
> +%collating-element <n-ss> from "<U043D><U044C>"
> +%
> +%collating-symbol <R+SS>
> +%collating-element <R-SS> from "<U0420><U042C>"
> +%collating-element <R-ss> from "<U0420><U044C>"
> +%collating-element <r-SS> from "<U0440><U042C>"
> +%collating-element <r-ss> from "<U0440><U044C>"
> +%
> +%collating-symbol <S+SS>
> +%collating-element <S-SS> from "<U0421><U042C>"
> +%collating-element <S-ss> from "<U0421><U044C>"
> +%collating-element <s-SS> from "<U0441><U042C>"
> +%collating-element <s-ss> from "<U0441><U044C>"
> +%
> +%collating-symbol <T+SS>
> +%collating-element <T-SS> from "<U0422><U042C>"
> +%collating-element <T-ss> from "<U0422><U044C>"
> +%collating-element <t-SS> from "<U0442><U042C>"
> +%collating-element <t-ss> from "<U0442><U044C>"
> +%
> +%collating-symbol <TSE+SS>
> +%collating-element <TS-SS> from "<U0426><U042C>"
> +%collating-element <TS-ss> from "<U0426><U044C>"
> +%collating-element <ts-SS> from "<U0446><U042C>"
> +%collating-element <ts-ss> from "<U0446><U044C>"
>
>
> collating-symbol <CAP-MIN>
> @@ -489,11 +491,11 @@ reorder-after <U0434>
> <U0455> "<U003C><U0043><U0059><U0052><U002D><U0044><U0045><U003E><U003C><U0043><U0059><U0052><U002D><U005A><U0045><U003E>";"<U003C><U004C><U0049><U0047><U003E><U003C><U004C><U0049><U0047><U003E>";"<U003C><U004D><U0049><U004E><U003E><U003C><U004D><U0049><U004E><U003E>";IGNORE
> % CYR-DZE
>
> reorder-after <U0435>
> -<U0454> <CYR-IE>;<UKR-IE>;<MIN>;IGNORE
> +%<U0454> <CYR-IE>;<UKR-IE>;<MIN>;IGNORE
> <U0451> <CYR-IE>;<CYR-IO>;<MIN>;IGNORE
> <U044D> <CYR-IE>;<CYR-E>;<MIN>;IGNORE
> reorder-after <U0415>
> -<U0404> <CYR-IE>;<UKR-IE>;<CAP>;IGNORE
> +%<U0404> <CYR-IE>;<UKR-IE>;<CAP>;IGNORE
> <U0401> <CYR-IE>;<CYR-IO>;<CAP>;IGNORE
> <U042D> <CYR-IE>;<CYR-E>;<CAP>;IGNORE
>
> diff --git a/localedata/uk_UA.in b/localedata/uk_UA.in
> new file mode 100644
> index 0000000..ff4d284
> --- /dev/null
> +++ b/localedata/uk_UA.in
> @@ -0,0 +1,56 @@
> +01010
> +Абажур
> +абажур
> +абажур-10
> +брама
> +вермішель
> +грати
> +Граття
> +граття
> +ґрати
> +ебонітовий
> +експорт
> +експосол
> +екс-посол
> +експоцентр
> +експрацівник
> +екс-працівник
> +еластичність
> +електрика
> +ельбор
> +елюент
> +епатаж
> +євгеніка
> +Європа
> +єдність
> +Жмих
> +жмих
> +зоря
> +и
> +і
> +ї
> +й
> +Карпати
> +криниця
> +лебідь
> +місяцевий
> +місяць
> +наразі
> +обапіл
> +об'їзд
> +об’їзд
> +обʼїзд
> +образ
> +опір
> +право
> +сонце
> +тарган
> +упродовж
> +фантастика
> +центр
> +чухатися
> +ш
> +щ
> +ь
> +ю
> +я
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][BZ 17293] Fix sorting order for Ukrainian locale
2015-04-13 13:32 ` [PATCH][BZ 17293] Fix sorting order for Ukrainian locale Andriy Rysin
@ 2015-05-12 14:55 ` Siddhesh Poyarekar
[not found] ` <CAOZT1o1ab=XVoLRXZppKiitetmAyPHX7NAdowSjjgUQryjoQQw@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Siddhesh Poyarekar @ 2015-05-12 14:55 UTC (permalink / raw)
To: Andriy Rysin; +Cc: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 9840 bytes --]
Thanks, the patch looks OK except for the nits below. Please fix
those and repost.
On Mon, Apr 13, 2015 at 09:31:55AM -0400, Andriy Rysin wrote:
> 2015-03-13 11:17 GMT-04:00 Andriy Rysin <arysin@gmail.com>:
> > 2015-02-10 Andriy Rysin <arysin@gmail.com>
> >
> > [BZ #17293]
> > uk_UA: Fix sorting order for Ukrainian locale
> > * localedata/Makefile:
> > * localedata/locales/uk_UA:
> > * localedata/uk_UA.in: New file.
> >
> >
> >
> > From 060dca0cabdd85de4ae2cbfad3e3027539987252 Mon Sep 17 00:00:00 2001
> > From: Andriy Rysin <arysin@gmail.com>
> > Date: Tue, 10 Feb 2015 19:46:56 -0500
> > Subject: [PATCH] Fix sorting order for Ukrainian locale: soft sign has its
> > own position and UKR-IE should follow CYR-IE; added collation tests for
> > Ukrainian locale symbols
> >
> > ---
> > localedata/Makefile | 4 +-
> > localedata/locales/uk_UA | 116 ++++++++++++++++++++++++-----------------------
> > localedata/uk_UA.in | 56 +++++++++++++++++++++++
> > 3 files changed, 117 insertions(+), 59 deletions(-)
> > create mode 100644 localedata/uk_UA.in
> >
> > diff --git a/localedata/Makefile b/localedata/Makefile
> > index d1218f5..83c7047 100644
> > --- a/localedata/Makefile
> > +++ b/localedata/Makefile
> > @@ -37,7 +37,7 @@ test-srcs := collate-test xfrm-test tst-fmon
> > tst-rpmatch tst-trans \
> > tst-ctype tst-langinfo tst-langinfo-static tst-numeric
> > test-input := de_DE.ISO-8859-1 en_US.ISO-8859-1 da_DK.ISO-8859-1 \
> > hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 tr_TR.UTF-8 fr_FR.UTF-8 \
> > - si_LK.UTF-8
> > + si_LK.UTF-8 uk_UA.UTF-8
> > test-input-data = $(addsuffix .in, $(basename $(test-input)))
> > test-output := $(foreach s, .out .xout, \
> > $(addsuffix $s, $(basename $(test-input))))
> > @@ -106,7 +106,7 @@ LOCALES := de_DE.ISO-8859-1 de_DE.UTF-8
> > en_US.ANSI_X3.4-1968 \
> > hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 ja_JP.SJIS fr_FR.ISO-8859-1 \
> > nb_NO.ISO-8859-1 nn_NO.ISO-8859-1 tr_TR.UTF-8 cs_CZ.UTF-8 \
> > zh_TW.EUC-TW fa_IR.UTF-8 fr_FR.UTF-8 ja_JP.UTF-8 si_LK.UTF-8 \
> > - tr_TR.ISO-8859-9 en_GB.UTF-8
> > + tr_TR.ISO-8859-9 en_GB.UTF-8 uk_UA.UTF-8
> > LOCALE_SRCS := $(shell echo "$(LOCALES)"|sed 's/\([^ .]*\)[^ ]*/\1/g')
> > CHARMAPS := $(shell echo "$(LOCALES)" | \
> > sed -e 's/[^ .]*[.]\([^ ]*\)/\1/g' -e s/SJIS/SHIFT_JIS/g)
> > diff --git a/localedata/locales/uk_UA b/localedata/locales/uk_UA
> > index d9194b8..2bd30eb 100644
> > --- a/localedata/locales/uk_UA
> > +++ b/localedata/locales/uk_UA
> > @@ -349,61 +349,63 @@ collating-symbol <UKR-GHE>
> > % Soft sign '<U044C>' may follow only this set of nine characters
> > [<U0432><U0434><U0437><U043B><U043D><U0440><U0441><U0442><U0446>].
> > % It only softens pronunciation of these characters so it's should not impact
> > % sorting.
> > -
> > -
> > -collating-symbol <V+SS>
> > -collating-element <V-SS> from "<U0412><U042C>"
> > -collating-element <V-ss> from "<U0412><U044C>"
> > -collating-element <v-SS> from "<U0432><U042C>"
> > -collating-element <v-ss> from "<U0432><U044C>"
> > -
> > -collating-symbol <D+SS>
> > -collating-element <D-SS> from "<U0414><U042C>"
> > -collating-element <D-ss> from "<U0414><U044C>"
> > -collating-element <d-SS> from "<U0434><U042C>"
> > -collating-element <d-ss> from "<U0434><U044C>"
> > -
> > -collating-symbol <Z+SS>
> > -collating-element <Z-SS> from "<U0417><U042C>"
> > -collating-element <Z-ss> from "<U0417><U044C>"
> > -collating-element <z-SS> from "<U0437><U042C>"
> > -collating-element <z-ss> from "<U0437><U044C>"
> > -
> > -collating-symbol <L+SS>
> > -collating-element <L-SS> from "<U041B><U042C>"
> > -collating-element <L-ss> from "<U041B><U044C>"
> > -collating-element <l-SS> from "<U043B><U042C>"
> > -collating-element <l-ss> from "<U043B><U044C>"
> > -
> > -collating-symbol <N+SS>
> > -collating-element <N-SS> from "<U041D><U042C>"
> > -collating-element <N-ss> from "<U041D><U044C>"
> > -collating-element <n-SS> from "<U043D><U042C>"
> > -collating-element <n-ss> from "<U043D><U044C>"
> > -
> > -collating-symbol <R+SS>
> > -collating-element <R-SS> from "<U0420><U042C>"
> > -collating-element <R-ss> from "<U0420><U044C>"
> > -collating-element <r-SS> from "<U0440><U042C>"
> > -collating-element <r-ss> from "<U0440><U044C>"
> > -
> > -collating-symbol <S+SS>
> > -collating-element <S-SS> from "<U0421><U042C>"
> > -collating-element <S-ss> from "<U0421><U044C>"
> > -collating-element <s-SS> from "<U0441><U042C>"
> > -collating-element <s-ss> from "<U0441><U044C>"
> > -
> > -collating-symbol <T+SS>
> > -collating-element <T-SS> from "<U0422><U042C>"
> > -collating-element <T-ss> from "<U0422><U044C>"
> > -collating-element <t-SS> from "<U0442><U042C>"
> > -collating-element <t-ss> from "<U0442><U044C>"
> > -
> > -collating-symbol <TSE+SS>
> > -collating-element <TS-SS> from "<U0426><U042C>"
> > -collating-element <TS-ss> from "<U0426><U044C>"
> > -collating-element <ts-SS> from "<U0446><U042C>"
> > -collating-element <ts-ss> from "<U0446><U044C>"
> > +%
> > +% Note: in the official alphabet the soft sign is a letter and has a
> > hard position in the order
> > +
> > +
> > +%collating-symbol <V+SS>
> > +%collating-element <V-SS> from "<U0412><U042C>"
> > +%collating-element <V-ss> from "<U0412><U044C>"
> > +%collating-element <v-SS> from "<U0432><U042C>"
> > +%collating-element <v-ss> from "<U0432><U044C>"
> > +%
> > +%collating-symbol <D+SS>
> > +%collating-element <D-SS> from "<U0414><U042C>"
> > +%collating-element <D-ss> from "<U0414><U044C>"
> > +%collating-element <d-SS> from "<U0434><U042C>"
> > +%collating-element <d-ss> from "<U0434><U044C>"
> > +%
> > +%collating-symbol <Z+SS>
> > +%collating-element <Z-SS> from "<U0417><U042C>"
> > +%collating-element <Z-ss> from "<U0417><U044C>"
> > +%collating-element <z-SS> from "<U0437><U042C>"
> > +%collating-element <z-ss> from "<U0437><U044C>"
> > +%
> > +%collating-symbol <L+SS>
> > +%collating-element <L-SS> from "<U041B><U042C>"
> > +%collating-element <L-ss> from "<U041B><U044C>"
> > +%collating-element <l-SS> from "<U043B><U042C>"
> > +%collating-element <l-ss> from "<U043B><U044C>"
> > +%
> > +%collating-symbol <N+SS>
> > +%collating-element <N-SS> from "<U041D><U042C>"
> > +%collating-element <N-ss> from "<U041D><U044C>"
> > +%collating-element <n-SS> from "<U043D><U042C>"
> > +%collating-element <n-ss> from "<U043D><U044C>"
> > +%
> > +%collating-symbol <R+SS>
> > +%collating-element <R-SS> from "<U0420><U042C>"
> > +%collating-element <R-ss> from "<U0420><U044C>"
> > +%collating-element <r-SS> from "<U0440><U042C>"
> > +%collating-element <r-ss> from "<U0440><U044C>"
> > +%
> > +%collating-symbol <S+SS>
> > +%collating-element <S-SS> from "<U0421><U042C>"
> > +%collating-element <S-ss> from "<U0421><U044C>"
> > +%collating-element <s-SS> from "<U0441><U042C>"
> > +%collating-element <s-ss> from "<U0441><U044C>"
> > +%
> > +%collating-symbol <T+SS>
> > +%collating-element <T-SS> from "<U0422><U042C>"
> > +%collating-element <T-ss> from "<U0422><U044C>"
> > +%collating-element <t-SS> from "<U0442><U042C>"
> > +%collating-element <t-ss> from "<U0442><U044C>"
> > +%
> > +%collating-symbol <TSE+SS>
> > +%collating-element <TS-SS> from "<U0426><U042C>"
> > +%collating-element <TS-ss> from "<U0426><U044C>"
> > +%collating-element <ts-SS> from "<U0446><U042C>"
> > +%collating-element <ts-ss> from "<U0446><U044C>"
Please don't comment these out. Instead, just delete them and replace
with your comment.
> >
> >
> > collating-symbol <CAP-MIN>
> > @@ -489,11 +491,11 @@ reorder-after <U0434>
> > <U0455> "<U003C><U0043><U0059><U0052><U002D><U0044><U0045><U003E><U003C><U0043><U0059><U0052><U002D><U005A><U0045><U003E>";"<U003C><U004C><U0049><U0047><U003E><U003C><U004C><U0049><U0047><U003E>";"<U003C><U004D><U0049><U004E><U003E><U003C><U004D><U0049><U004E><U003E>";IGNORE
> > % CYR-DZE
> >
> > reorder-after <U0435>
> > -<U0454> <CYR-IE>;<UKR-IE>;<MIN>;IGNORE
> > +%<U0454> <CYR-IE>;<UKR-IE>;<MIN>;IGNORE
> > <U0451> <CYR-IE>;<CYR-IO>;<MIN>;IGNORE
> > <U044D> <CYR-IE>;<CYR-E>;<MIN>;IGNORE
> > reorder-after <U0415>
> > -<U0404> <CYR-IE>;<UKR-IE>;<CAP>;IGNORE
> > +%<U0404> <CYR-IE>;<UKR-IE>;<CAP>;IGNORE
> > <U0401> <CYR-IE>;<CYR-IO>;<CAP>;IGNORE
> > <U042D> <CYR-IE>;<CYR-E>;<CAP>;IGNORE
Likewise, just delete those lines.
> >
> > diff --git a/localedata/uk_UA.in b/localedata/uk_UA.in
> > new file mode 100644
> > index 0000000..ff4d284
> > --- /dev/null
> > +++ b/localedata/uk_UA.in
> > @@ -0,0 +1,56 @@
> > +01010
> > +Абажур
> > +абажур
> > +абажур-10
> > +брама
> > +вермішель
> > +грати
> > +Граття
> > +граття
> > +ґрати
> > +ебонітовий
> > +експорт
> > +експосол
> > +екс-посол
> > +експоцентр
> > +експрацівник
> > +екс-працівник
> > +еластичність
> > +електрика
> > +ельбор
> > +елюент
> > +епатаж
> > +євгеніка
> > +Європа
> > +єдність
> > +Жмих
> > +жмих
> > +зоря
> > +и
> > +і
> > +ї
> > +й
> > +Карпати
> > +криниця
> > +лебідь
> > +місяцевий
> > +місяць
> > +наразі
> > +обапіл
> > +об'їзд
> > +об’їзд
> > +обʼїзд
> > +образ
> > +опір
> > +право
> > +сонце
> > +тарган
> > +упродовж
> > +фантастика
> > +центр
> > +чухатися
> > +ш
> > +щ
> > +ь
> > +ю
> > +я
Thanks,
Siddhesh
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][BZ 17293] Fix sorting order for Ukrainian locale
[not found] ` <CAOZT1o1ab=XVoLRXZppKiitetmAyPHX7NAdowSjjgUQryjoQQw@mail.gmail.com>
@ 2015-05-21 19:56 ` Andriy Rysin
2015-05-26 18:10 ` Siddhesh Poyarekar
0 siblings, 1 reply; 6+ messages in thread
From: Andriy Rysin @ 2015-05-21 19:56 UTC (permalink / raw)
To: libc-alpha; +Cc: Siddhesh Poyarekar
I've sent the email below on May 12 but somehow it does not show up in
libc-alpha mailing list archive (although Siddhesh's email from
earlier that day is there). So I am resending it again.
Andriy
2015-05-12 14:47 GMT-04:00 Andriy Rysin <arysin@gmail.com>:
> Hi Siddhesh
>
> Thanks, I've updated the patch per your comment. Updates a below inline.
>
> Regards,
> Andriy
>
>
> 2015-05-12 Andriy Rysin <arysin@gmail.com>
>
> [BZ #17293]
> * uk_UA: Fix sorting order for Ukrainian locale
>
> From 3ca9afb68ce4166ec854cce8a935df7694915365 Mon Sep 17 00:00:00 2001
> From: Andriy Rysin <arysin@gmail.com>
> Date: Tue, 10 Feb 2015 19:46:56 -0500
> Subject: [PATCH] Fix sorting order for Ukrainian locale: soft sign has its
> own position and UKR-IE should follow CYR-IE; added collation tests for
> Ukrainian locale symbols
>
> ---
> localedata/Makefile | 4 +--
> localedata/locales/uk_UA | 64 ++----------------------------------------------
> localedata/uk_UA.in | 56 ++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 60 insertions(+), 64 deletions(-)
> create mode 100644 localedata/uk_UA.in
>
> diff --git a/localedata/Makefile b/localedata/Makefile
> index d1218f5..83c7047 100644
> --- a/localedata/Makefile
> +++ b/localedata/Makefile
> @@ -37,7 +37,7 @@ test-srcs := collate-test xfrm-test tst-fmon
> tst-rpmatch tst-trans \
> tst-ctype tst-langinfo tst-langinfo-static tst-numeric
> test-input := de_DE.ISO-8859-1 en_US.ISO-8859-1 da_DK.ISO-8859-1 \
> hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 tr_TR.UTF-8 fr_FR.UTF-8 \
> - si_LK.UTF-8
> + si_LK.UTF-8 uk_UA.UTF-8
> test-input-data = $(addsuffix .in, $(basename $(test-input)))
> test-output := $(foreach s, .out .xout, \
> $(addsuffix $s, $(basename $(test-input))))
> @@ -106,7 +106,7 @@ LOCALES := de_DE.ISO-8859-1 de_DE.UTF-8
> en_US.ANSI_X3.4-1968 \
> hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 ja_JP.SJIS fr_FR.ISO-8859-1 \
> nb_NO.ISO-8859-1 nn_NO.ISO-8859-1 tr_TR.UTF-8 cs_CZ.UTF-8 \
> zh_TW.EUC-TW fa_IR.UTF-8 fr_FR.UTF-8 ja_JP.UTF-8 si_LK.UTF-8 \
> - tr_TR.ISO-8859-9 en_GB.UTF-8
> + tr_TR.ISO-8859-9 en_GB.UTF-8 uk_UA.UTF-8
> LOCALE_SRCS := $(shell echo "$(LOCALES)"|sed 's/\([^ .]*\)[^ ]*/\1/g')
> CHARMAPS := $(shell echo "$(LOCALES)" | \
> sed -e 's/[^ .]*[.]\([^ ]*\)/\1/g' -e s/SJIS/SHIFT_JIS/g)
> diff --git a/localedata/locales/uk_UA b/localedata/locales/uk_UA
> index d9194b8..af6856f 100644
> --- a/localedata/locales/uk_UA
> +++ b/localedata/locales/uk_UA
> @@ -340,70 +340,12 @@ copy
> "<U0069><U0073><U006F><U0031><U0034><U0036><U0035><U0031><U005F><U0074><U00
> % Ukrainian ghe is missing in iso14651_t1
> collating-symbol <UKR-GHE>
>
> -% Soft sign and apostrophe must be ignored during sorting because they are
> -% just signs, not real letters.
> +% Apostrophe must be ignored during sorting because it's just a sign,
> not real letter
> % ( "<U006E><U0060>"=="<U006E>",
> "<U0027><U0079><U0061>"=="<U0079><U0061>", etc. )
> %
> % Apostrophe already ignored by iso14651_t1.
> %
> -% Soft sign '<U044C>' may follow only this set of nine characters
> [<U0432><U0434><U0437><U043B><U043D><U0440><U0441><U0442><U0446>].
> -% It only softens pronunciation of these characters so it's should not impact
> -% sorting.
> -
> -
> -collating-symbol <V+SS>
> -collating-element <V-SS> from "<U0412><U042C>"
> -collating-element <V-ss> from "<U0412><U044C>"
> -collating-element <v-SS> from "<U0432><U042C>"
> -collating-element <v-ss> from "<U0432><U044C>"
> -
> -collating-symbol <D+SS>
> -collating-element <D-SS> from "<U0414><U042C>"
> -collating-element <D-ss> from "<U0414><U044C>"
> -collating-element <d-SS> from "<U0434><U042C>"
> -collating-element <d-ss> from "<U0434><U044C>"
> -
> -collating-symbol <Z+SS>
> -collating-element <Z-SS> from "<U0417><U042C>"
> -collating-element <Z-ss> from "<U0417><U044C>"
> -collating-element <z-SS> from "<U0437><U042C>"
> -collating-element <z-ss> from "<U0437><U044C>"
> -
> -collating-symbol <L+SS>
> -collating-element <L-SS> from "<U041B><U042C>"
> -collating-element <L-ss> from "<U041B><U044C>"
> -collating-element <l-SS> from "<U043B><U042C>"
> -collating-element <l-ss> from "<U043B><U044C>"
> -
> -collating-symbol <N+SS>
> -collating-element <N-SS> from "<U041D><U042C>"
> -collating-element <N-ss> from "<U041D><U044C>"
> -collating-element <n-SS> from "<U043D><U042C>"
> -collating-element <n-ss> from "<U043D><U044C>"
> -
> -collating-symbol <R+SS>
> -collating-element <R-SS> from "<U0420><U042C>"
> -collating-element <R-ss> from "<U0420><U044C>"
> -collating-element <r-SS> from "<U0440><U042C>"
> -collating-element <r-ss> from "<U0440><U044C>"
> -
> -collating-symbol <S+SS>
> -collating-element <S-SS> from "<U0421><U042C>"
> -collating-element <S-ss> from "<U0421><U044C>"
> -collating-element <s-SS> from "<U0441><U042C>"
> -collating-element <s-ss> from "<U0441><U044C>"
> -
> -collating-symbol <T+SS>
> -collating-element <T-SS> from "<U0422><U042C>"
> -collating-element <T-ss> from "<U0422><U044C>"
> -collating-element <t-SS> from "<U0442><U042C>"
> -collating-element <t-ss> from "<U0442><U044C>"
> -
> -collating-symbol <TSE+SS>
> -collating-element <TS-SS> from "<U0426><U042C>"
> -collating-element <TS-ss> from "<U0426><U044C>"
> -collating-element <ts-SS> from "<U0446><U042C>"
> -collating-element <ts-ss> from "<U0446><U044C>"
> +% In the official alphabet the soft sign is a letter and has a hard
> position in the order.
>
>
> collating-symbol <CAP-MIN>
> @@ -489,11 +431,9 @@ reorder-after <U0434>
> <U0455> "<U003C><U0043><U0059><U0052><U002D><U0044><U0045><U003E><U003C><U0043><U0059><U0052><U002D><U005A><U0045><U003E>";"<U003C><U004C><U0049><U0047><U003E><U003C><U004C><U0049><U0047><U003E>";"<U003C><U004D><U0049><U004E><U003E><U003C><U004D><U0049><U004E><U003E>";IGNORE
> % CYR-DZE
>
> reorder-after <U0435>
> -<U0454> <CYR-IE>;<UKR-IE>;<MIN>;IGNORE
> <U0451> <CYR-IE>;<CYR-IO>;<MIN>;IGNORE
> <U044D> <CYR-IE>;<CYR-E>;<MIN>;IGNORE
> reorder-after <U0415>
> -<U0404> <CYR-IE>;<UKR-IE>;<CAP>;IGNORE
> <U0401> <CYR-IE>;<CYR-IO>;<CAP>;IGNORE
> <U042D> <CYR-IE>;<CYR-E>;<CAP>;IGNORE
>
> diff --git a/localedata/uk_UA.in b/localedata/uk_UA.in
> new file mode 100644
> index 0000000..ff4d284
> --- /dev/null
> +++ b/localedata/uk_UA.in
> @@ -0,0 +1,56 @@
> +01010
> +Абажур
> +абажур
> +абажур-10
> +брама
> +вермішель
> +грати
> +Граття
> +граття
> +ґрати
> +ебонітовий
> +експорт
> +експосол
> +екс-посол
> +експоцентр
> +експрацівник
> +екс-працівник
> +еластичність
> +електрика
> +ельбор
> +елюент
> +епатаж
> +євгеніка
> +Європа
> +єдність
> +Жмих
> +жмих
> +зоря
> +и
> +і
> +ї
> +й
> +Карпати
> +криниця
> +лебідь
> +місяцевий
> +місяць
> +наразі
> +обапіл
> +об'їзд
> +об’їзд
> +обʼїзд
> +образ
> +опір
> +право
> +сонце
> +тарган
> +упродовж
> +фантастика
> +центр
> +чухатися
> +ш
> +щ
> +ь
> +ю
> +я
> --
> 2.1.0
>
>
> 2015-05-12 10:54 GMT-04:00 Siddhesh Poyarekar <siddhesh@redhat.com>:
>> Thanks, the patch looks OK except for the nits below. Please fix
>> those and repost.
>>
>> On Mon, Apr 13, 2015 at 09:31:55AM -0400, Andriy Rysin wrote:
>>> 2015-03-13 11:17 GMT-04:00 Andriy Rysin <arysin@gmail.com>:
>>> > 2015-02-10 Andriy Rysin <arysin@gmail.com>
>>> >
>>> > [BZ #17293]
>>> > uk_UA: Fix sorting order for Ukrainian locale
>>> > * localedata/Makefile:
>>> > * localedata/locales/uk_UA:
>>> > * localedata/uk_UA.in: New file.
>>> >
>>> >
>>> >
>>> > From 060dca0cabdd85de4ae2cbfad3e3027539987252 Mon Sep 17 00:00:00 2001
>>> > From: Andriy Rysin <arysin@gmail.com>
>>> > Date: Tue, 10 Feb 2015 19:46:56 -0500
>>> > Subject: [PATCH] Fix sorting order for Ukrainian locale: soft sign has its
>>> > own position and UKR-IE should follow CYR-IE; added collation tests for
>>> > Ukrainian locale symbols
>>> >
>>> > ---
>>> > localedata/Makefile | 4 +-
>>> > localedata/locales/uk_UA | 116 ++++++++++++++++++++++++-----------------------
>>> > localedata/uk_UA.in | 56 +++++++++++++++++++++++
>>> > 3 files changed, 117 insertions(+), 59 deletions(-)
>>> > create mode 100644 localedata/uk_UA.in
>>> >
>>> > diff --git a/localedata/Makefile b/localedata/Makefile
>>> > index d1218f5..83c7047 100644
>>> > --- a/localedata/Makefile
>>> > +++ b/localedata/Makefile
>>> > @@ -37,7 +37,7 @@ test-srcs := collate-test xfrm-test tst-fmon
>>> > tst-rpmatch tst-trans \
>>> > tst-ctype tst-langinfo tst-langinfo-static tst-numeric
>>> > test-input := de_DE.ISO-8859-1 en_US.ISO-8859-1 da_DK.ISO-8859-1 \
>>> > hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 tr_TR.UTF-8 fr_FR.UTF-8 \
>>> > - si_LK.UTF-8
>>> > + si_LK.UTF-8 uk_UA.UTF-8
>>> > test-input-data = $(addsuffix .in, $(basename $(test-input)))
>>> > test-output := $(foreach s, .out .xout, \
>>> > $(addsuffix $s, $(basename $(test-input))))
>>> > @@ -106,7 +106,7 @@ LOCALES := de_DE.ISO-8859-1 de_DE.UTF-8
>>> > en_US.ANSI_X3.4-1968 \
>>> > hr_HR.ISO-8859-2 sv_SE.ISO-8859-1 ja_JP.SJIS fr_FR.ISO-8859-1 \
>>> > nb_NO.ISO-8859-1 nn_NO.ISO-8859-1 tr_TR.UTF-8 cs_CZ.UTF-8 \
>>> > zh_TW.EUC-TW fa_IR.UTF-8 fr_FR.UTF-8 ja_JP.UTF-8 si_LK.UTF-8 \
>>> > - tr_TR.ISO-8859-9 en_GB.UTF-8
>>> > + tr_TR.ISO-8859-9 en_GB.UTF-8 uk_UA.UTF-8
>>> > LOCALE_SRCS := $(shell echo "$(LOCALES)"|sed 's/\([^ .]*\)[^ ]*/\1/g')
>>> > CHARMAPS := $(shell echo "$(LOCALES)" | \
>>> > sed -e 's/[^ .]*[.]\([^ ]*\)/\1/g' -e s/SJIS/SHIFT_JIS/g)
>>> > diff --git a/localedata/locales/uk_UA b/localedata/locales/uk_UA
>>> > index d9194b8..2bd30eb 100644
>>> > --- a/localedata/locales/uk_UA
>>> > +++ b/localedata/locales/uk_UA
>>> > @@ -349,61 +349,63 @@ collating-symbol <UKR-GHE>
>>> > % Soft sign '<U044C>' may follow only this set of nine characters
>>> > [<U0432><U0434><U0437><U043B><U043D><U0440><U0441><U0442><U0446>].
>>> > % It only softens pronunciation of these characters so it's should not impact
>>> > % sorting.
>>> > -
>>> > -
>>> > -collating-symbol <V+SS>
>>> > -collating-element <V-SS> from "<U0412><U042C>"
>>> > -collating-element <V-ss> from "<U0412><U044C>"
>>> > -collating-element <v-SS> from "<U0432><U042C>"
>>> > -collating-element <v-ss> from "<U0432><U044C>"
>>> > -
>>> > -collating-symbol <D+SS>
>>> > -collating-element <D-SS> from "<U0414><U042C>"
>>> > -collating-element <D-ss> from "<U0414><U044C>"
>>> > -collating-element <d-SS> from "<U0434><U042C>"
>>> > -collating-element <d-ss> from "<U0434><U044C>"
>>> > -
>>> > -collating-symbol <Z+SS>
>>> > -collating-element <Z-SS> from "<U0417><U042C>"
>>> > -collating-element <Z-ss> from "<U0417><U044C>"
>>> > -collating-element <z-SS> from "<U0437><U042C>"
>>> > -collating-element <z-ss> from "<U0437><U044C>"
>>> > -
>>> > -collating-symbol <L+SS>
>>> > -collating-element <L-SS> from "<U041B><U042C>"
>>> > -collating-element <L-ss> from "<U041B><U044C>"
>>> > -collating-element <l-SS> from "<U043B><U042C>"
>>> > -collating-element <l-ss> from "<U043B><U044C>"
>>> > -
>>> > -collating-symbol <N+SS>
>>> > -collating-element <N-SS> from "<U041D><U042C>"
>>> > -collating-element <N-ss> from "<U041D><U044C>"
>>> > -collating-element <n-SS> from "<U043D><U042C>"
>>> > -collating-element <n-ss> from "<U043D><U044C>"
>>> > -
>>> > -collating-symbol <R+SS>
>>> > -collating-element <R-SS> from "<U0420><U042C>"
>>> > -collating-element <R-ss> from "<U0420><U044C>"
>>> > -collating-element <r-SS> from "<U0440><U042C>"
>>> > -collating-element <r-ss> from "<U0440><U044C>"
>>> > -
>>> > -collating-symbol <S+SS>
>>> > -collating-element <S-SS> from "<U0421><U042C>"
>>> > -collating-element <S-ss> from "<U0421><U044C>"
>>> > -collating-element <s-SS> from "<U0441><U042C>"
>>> > -collating-element <s-ss> from "<U0441><U044C>"
>>> > -
>>> > -collating-symbol <T+SS>
>>> > -collating-element <T-SS> from "<U0422><U042C>"
>>> > -collating-element <T-ss> from "<U0422><U044C>"
>>> > -collating-element <t-SS> from "<U0442><U042C>"
>>> > -collating-element <t-ss> from "<U0442><U044C>"
>>> > -
>>> > -collating-symbol <TSE+SS>
>>> > -collating-element <TS-SS> from "<U0426><U042C>"
>>> > -collating-element <TS-ss> from "<U0426><U044C>"
>>> > -collating-element <ts-SS> from "<U0446><U042C>"
>>> > -collating-element <ts-ss> from "<U0446><U044C>"
>>> > +%
>>> > +% Note: in the official alphabet the soft sign is a letter and has a
>>> > hard position in the order
>>> > +
>>> > +
>>> > +%collating-symbol <V+SS>
>>> > +%collating-element <V-SS> from "<U0412><U042C>"
>>> > +%collating-element <V-ss> from "<U0412><U044C>"
>>> > +%collating-element <v-SS> from "<U0432><U042C>"
>>> > +%collating-element <v-ss> from "<U0432><U044C>"
>>> > +%
>>> > +%collating-symbol <D+SS>
>>> > +%collating-element <D-SS> from "<U0414><U042C>"
>>> > +%collating-element <D-ss> from "<U0414><U044C>"
>>> > +%collating-element <d-SS> from "<U0434><U042C>"
>>> > +%collating-element <d-ss> from "<U0434><U044C>"
>>> > +%
>>> > +%collating-symbol <Z+SS>
>>> > +%collating-element <Z-SS> from "<U0417><U042C>"
>>> > +%collating-element <Z-ss> from "<U0417><U044C>"
>>> > +%collating-element <z-SS> from "<U0437><U042C>"
>>> > +%collating-element <z-ss> from "<U0437><U044C>"
>>> > +%
>>> > +%collating-symbol <L+SS>
>>> > +%collating-element <L-SS> from "<U041B><U042C>"
>>> > +%collating-element <L-ss> from "<U041B><U044C>"
>>> > +%collating-element <l-SS> from "<U043B><U042C>"
>>> > +%collating-element <l-ss> from "<U043B><U044C>"
>>> > +%
>>> > +%collating-symbol <N+SS>
>>> > +%collating-element <N-SS> from "<U041D><U042C>"
>>> > +%collating-element <N-ss> from "<U041D><U044C>"
>>> > +%collating-element <n-SS> from "<U043D><U042C>"
>>> > +%collating-element <n-ss> from "<U043D><U044C>"
>>> > +%
>>> > +%collating-symbol <R+SS>
>>> > +%collating-element <R-SS> from "<U0420><U042C>"
>>> > +%collating-element <R-ss> from "<U0420><U044C>"
>>> > +%collating-element <r-SS> from "<U0440><U042C>"
>>> > +%collating-element <r-ss> from "<U0440><U044C>"
>>> > +%
>>> > +%collating-symbol <S+SS>
>>> > +%collating-element <S-SS> from "<U0421><U042C>"
>>> > +%collating-element <S-ss> from "<U0421><U044C>"
>>> > +%collating-element <s-SS> from "<U0441><U042C>"
>>> > +%collating-element <s-ss> from "<U0441><U044C>"
>>> > +%
>>> > +%collating-symbol <T+SS>
>>> > +%collating-element <T-SS> from "<U0422><U042C>"
>>> > +%collating-element <T-ss> from "<U0422><U044C>"
>>> > +%collating-element <t-SS> from "<U0442><U042C>"
>>> > +%collating-element <t-ss> from "<U0442><U044C>"
>>> > +%
>>> > +%collating-symbol <TSE+SS>
>>> > +%collating-element <TS-SS> from "<U0426><U042C>"
>>> > +%collating-element <TS-ss> from "<U0426><U044C>"
>>> > +%collating-element <ts-SS> from "<U0446><U042C>"
>>> > +%collating-element <ts-ss> from "<U0446><U044C>"
>>
>> Please don't comment these out. Instead, just delete them and replace
>> with your comment.
>>
>>> >
>>> >
>>> > collating-symbol <CAP-MIN>
>>> > @@ -489,11 +491,11 @@ reorder-after <U0434>
>>> > <U0455> "<U003C><U0043><U0059><U0052><U002D><U0044><U0045><U003E><U003C><U0043><U0059><U0052><U002D><U005A><U0045><U003E>";"<U003C><U004C><U0049><U0047><U003E><U003C><U004C><U0049><U0047><U003E>";"<U003C><U004D><U0049><U004E><U003E><U003C><U004D><U0049><U004E><U003E>";IGNORE
>>> > % CYR-DZE
>>> >
>>> > reorder-after <U0435>
>>> > -<U0454> <CYR-IE>;<UKR-IE>;<MIN>;IGNORE
>>> > +%<U0454> <CYR-IE>;<UKR-IE>;<MIN>;IGNORE
>>> > <U0451> <CYR-IE>;<CYR-IO>;<MIN>;IGNORE
>>> > <U044D> <CYR-IE>;<CYR-E>;<MIN>;IGNORE
>>> > reorder-after <U0415>
>>> > -<U0404> <CYR-IE>;<UKR-IE>;<CAP>;IGNORE
>>> > +%<U0404> <CYR-IE>;<UKR-IE>;<CAP>;IGNORE
>>> > <U0401> <CYR-IE>;<CYR-IO>;<CAP>;IGNORE
>>> > <U042D> <CYR-IE>;<CYR-E>;<CAP>;IGNORE
>>
>> Likewise, just delete those lines.
>>
>>> >
>>> > diff --git a/localedata/uk_UA.in b/localedata/uk_UA.in
>>> > new file mode 100644
>>> > index 0000000..ff4d284
>>> > --- /dev/null
>>> > +++ b/localedata/uk_UA.in
>>> > @@ -0,0 +1,56 @@
>>> > +01010
>>> > +Абажур
>>> > +абажур
>>> > +абажур-10
>>> > +брама
>>> > +вермішель
>>> > +грати
>>> > +Граття
>>> > +граття
>>> > +ґрати
>>> > +ебонітовий
>>> > +експорт
>>> > +експосол
>>> > +екс-посол
>>> > +експоцентр
>>> > +експрацівник
>>> > +екс-працівник
>>> > +еластичність
>>> > +електрика
>>> > +ельбор
>>> > +елюент
>>> > +епатаж
>>> > +євгеніка
>>> > +Європа
>>> > +єдність
>>> > +Жмих
>>> > +жмих
>>> > +зоря
>>> > +и
>>> > +і
>>> > +ї
>>> > +й
>>> > +Карпати
>>> > +криниця
>>> > +лебідь
>>> > +місяцевий
>>> > +місяць
>>> > +наразі
>>> > +обапіл
>>> > +об'їзд
>>> > +об’їзд
>>> > +обʼїзд
>>> > +образ
>>> > +опір
>>> > +право
>>> > +сонце
>>> > +тарган
>>> > +упродовж
>>> > +фантастика
>>> > +центр
>>> > +чухатися
>>> > +ш
>>> > +щ
>>> > +ь
>>> > +ю
>>> > +я
>>
>> Thanks,
>> Siddhesh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][BZ 17293] Fix sorting order for Ukrainian locale
2015-05-21 19:56 ` Andriy Rysin
@ 2015-05-26 18:10 ` Siddhesh Poyarekar
[not found] ` <CAOZT1o0nONwYs9fZX7FPnp1uObaSY0=WxvHbDRHV=89aTkkb_A@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Siddhesh Poyarekar @ 2015-05-26 18:10 UTC (permalink / raw)
To: Andriy Rysin; +Cc: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Thu, May 21, 2015 at 01:28:36PM -0400, Andriy Rysin wrote:
> I've sent the email below on May 12 but somehow it does not show up in
> libc-alpha mailing list archive (although Siddhesh's email from
> earlier that day is there). So I am resending it again.
Please resend the patch, don't just reply to the email. It is
difficult to try and extract the patch from your quoted email.
Siddhesh
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][BZ 17293] Fix sorting order for Ukrainian locale
[not found] ` <CAOZT1o0nONwYs9fZX7FPnp1uObaSY0=WxvHbDRHV=89aTkkb_A@mail.gmail.com>
@ 2015-05-26 19:07 ` Siddhesh Poyarekar
2015-05-27 12:17 ` Andriy Rysin
0 siblings, 1 reply; 6+ messages in thread
From: Siddhesh Poyarekar @ 2015-05-26 19:07 UTC (permalink / raw)
To: Andriy Rysin; +Cc: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Tue, May 26, 2015 at 01:16:46PM -0400, Andriy Rysin wrote:
> Changelog:
>
> 2015-05-12 Andriy Rysin <arysin@gmail.com>
>
> [BZ #17293]
> * uk_UA: Fix sorting order for Ukrainian locale
>
This is still no good since your MUA seems to be auto-wrapping lines
and eating up tabs. Are you using the gmail web client? it is a
terrible terrible interface to work with patches.
I've fixed it up and committed the patch.
Siddhesh
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][BZ 17293] Fix sorting order for Ukrainian locale
2015-05-26 19:07 ` Siddhesh Poyarekar
@ 2015-05-27 12:17 ` Andriy Rysin
0 siblings, 0 replies; 6+ messages in thread
From: Andriy Rysin @ 2015-05-27 12:17 UTC (permalink / raw)
To: Siddhesh Poyarekar; +Cc: libc-alpha
Thanks Siddhesh, much appreciated!
Andriy
2015-05-26 14:23 GMT-04:00 Siddhesh Poyarekar <siddhesh@redhat.com>:
> On Tue, May 26, 2015 at 01:16:46PM -0400, Andriy Rysin wrote:
>> Changelog:
>>
>> 2015-05-12 Andriy Rysin <arysin@gmail.com>
>>
>> [BZ #17293]
>> * uk_UA: Fix sorting order for Ukrainian locale
>>
>
> This is still no good since your MUA seems to be auto-wrapping lines
> and eating up tabs. Are you using the gmail web client? it is a
> terrible terrible interface to work with patches.
>
> I've fixed it up and committed the patch.
>
> Siddhesh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-27 11:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAOZT1o0Sfsnx89=TvSjgcLr_sWdPoWH8oNg1sq6Bmg+JgCdfug@mail.gmail.com>
2015-04-13 13:32 ` [PATCH][BZ 17293] Fix sorting order for Ukrainian locale Andriy Rysin
2015-05-12 14:55 ` Siddhesh Poyarekar
[not found] ` <CAOZT1o1ab=XVoLRXZppKiitetmAyPHX7NAdowSjjgUQryjoQQw@mail.gmail.com>
2015-05-21 19:56 ` Andriy Rysin
2015-05-26 18:10 ` Siddhesh Poyarekar
[not found] ` <CAOZT1o0nONwYs9fZX7FPnp1uObaSY0=WxvHbDRHV=89aTkkb_A@mail.gmail.com>
2015-05-26 19:07 ` Siddhesh Poyarekar
2015-05-27 12:17 ` Andriy Rysin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).