Re: Test suite failures with GCC 11 in header checks

[Frederic Berat <fberat@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

On Thu, Jul 20, 2023 at 11:26 AM Florian Weimer <fweimer@redhat.com> wrote:

> * Florian Weimer:
>
> > The test suite currently runs header checks with -D_FORTIFY_SOURCE=3
> > even if the compiler does not support it (such as GCC 11), leading to
> > failures.
> >
> > Has this already been discussed?  Should be resolved before the release?
>
> It's a regression introduced yesterday:
>
> commit 30379efad117b85cc56a255cac628d0ad745bfe3
> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Date:   Wed Jul 19 11:37:01 2023 -0300
>
>     scripts: Add fortify checks on installed headers
>
>     The _FORTIFY_SOURCE is used as default by some system compilers,
>     and there is no way to check if some fortify extension does not
>     trigger any conformance issue.
>
>     Checked on x86_64-linux-gnu.
>
>     Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
>
Some suggestions for the fix, instead of reverting that:
One can probably make use of the variables created by configure to define
the maximum level to be tested.
There is "enable_fortify_source" that should hold the level used to
configure glibc, assuming configure is run using GCC11, then this variable
will be set to 2.
As of now, this variable isn't used outside of the configure script, but it
could be (either by substituting the values in the script or by passing it
as an argument through the makefile).


> Thanks,
> Florian
>
>