From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9F3BB3858D1E for ; Tue, 20 Jun 2023 14:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F3BB3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687270921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=biGVuXHsS9jOikdnYQKQXJHeuQg7bw/OKQcK84O0zNQ=; b=IkSJTumDf9QXD8hW1jpHXZX6qyFJ15D5O409/JO8NWuZ3UZXS8adf9najH6OyiWk+2fk77 OggkDv1NRfdv57BSlS2pqxV5SzleuyjYcxf1DVrihFIZ4Q98+31A8IAUW614B9OL4LgDdL emgYbfRmOyL36XNkjXiiUehe7lgSXjs= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-yU_t_BksN9-GOgWGbXk0Ew-1; Tue, 20 Jun 2023 10:21:57 -0400 X-MC-Unique: yU_t_BksN9-GOgWGbXk0Ew-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-9879d2fc970so240102066b.0 for ; Tue, 20 Jun 2023 07:21:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687270913; x=1689862913; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=biGVuXHsS9jOikdnYQKQXJHeuQg7bw/OKQcK84O0zNQ=; b=KDI326p1POlH3L7TnjFLvGcWgKX/bjGx6hxxh8tSuItlTigSZ204V0zUUTSwOXK/sW K98iaHytBUDWQpzO8DQ2FHhRaleL+4l1E/uaT/5yLBRul0z+dexUQ5MmXQhWz3L1ah5H zRAVQDYWNdbfKMI4zZyJbxKP9wt5ip+1wuuOoNwh2ADyjYmLkFR2H9NTv7d2fv4AQJxG LEPP6mv81kMRJSm6vxnkIQ6IHXPwTAvyT++EdmmKiXQL9wk5snJwOIQkQYpr2Qomk8bY YYhbxTn3XAePZaDfQ4sdNReZcOhIel2PCKL7vX7D15Z/Aqln7rfJret2RibXnn09ANfq j45g== X-Gm-Message-State: AC+VfDxZ5vDsXv7BcsS3utYKRAEBpnv7RY+dJtj2ysjn2O/0y+uTSrjZ abeaG/fZZkZrOY4hwQxPRoysLl/1Fr5Qgux71enlCQ2ewmkSY0/lu9S0xRLRlW5H3PSlI3bBoFP qcDAU2cWFJbMhqjqMwBQ6q6dQMZ5Waa2YYVIfrA5RjVONrwc= X-Received: by 2002:a17:906:6a0e:b0:988:f93a:7ab7 with SMTP id qw14-20020a1709066a0e00b00988f93a7ab7mr3554073ejc.3.1687270913253; Tue, 20 Jun 2023 07:21:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ46xDfGlx1wPP9wzjQer9dVzMVPD6ufjkPec1BJP4tO2Sg2w1BqF8mg5gx8ANOdykQqeUAfYXQXMcmTfu3OQyU= X-Received: by 2002:a17:906:6a0e:b0:988:f93a:7ab7 with SMTP id qw14-20020a1709066a0e00b00988f93a7ab7mr3554057ejc.3.1687270912935; Tue, 20 Jun 2023 07:21:52 -0700 (PDT) MIME-Version: 1.0 References: <20230617222218.642125-1-bugaevc@gmail.com> <1249c048-c72d-0bf1-f0e0-2e619cfe5372@redhat.com> <783b1d24-f2b4-3a3c-d636-2b231be3b823@linaro.org> <2B723D88-546D-4AA6-8BDA-7B6CC9F5D404@linaro.org> In-Reply-To: From: Frederic Berat Date: Tue, 20 Jun 2023 16:21:42 +0200 Message-ID: Subject: Re: [PATCH v3 0/5] fcntl fortification To: Adhemerval Zanella Netto Cc: Maxim Kuvyrkov , Sergey Bugaev , "Carlos O'Donell" , Libc-alpha X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 20, 2023 at 2:50=E2=80=AFPM Adhemerval Zanella Netto wrote: > > > > On 20/06/23 02:59, Maxim Kuvyrkov wrote: > >> On Jun 19, 2023, at 22:36, Adhemerval Zanella Netto wrote: > >> > >> > >> > >> On 19/06/23 11:23, Sergey Bugaev via Libc-alpha wrote: > >>> On Mon, Jun 19, 2023 at 3:58=E2=80=AFPM Carlos O'Donell wrote: > >>>> Pre-commit CI regression caused by this series on both aarch64 and a= arch32. > >>>> https://patchwork.sourceware.org/project/glibc/patch/20230617222218.= 642125-6-bugaevc@gmail.com/ > >>>> > >>>> # Running glibc:io ... > >>>> # FAIL: io/check-installed-headers-c > >>>> # FAIL: io/check-installed-headers-cxx > >>>> # > >>>> # Running glibc:misc ... > >>>> # FAIL: misc/check-installed-headers-c > >>>> # FAIL: misc/check-installed-headers-cxx > >>>> # > >>>> # Running glibc:rt ... > >>>> # FAIL: rt/check-installed-headers-c > >>>> # FAIL: rt/check-installed-headers-cxx > >>> > >>> Thank you :( > >>> > >>> I'm a little bit lost in the Jenkins web UI -- is there anywhere I ca= n > >>> view the output of the failing tests to understand what exactly went > >>> wrong? I see the sum files here [0], but not the .out files. > >>> > >>> [0]: https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/386= /artifact/artifacts/artifacts.precommit/sumfiles/ > > > > Hi Sergey, > > > > See the attached tarball with output from failed tests: > > =3D=3D=3D > > Running glibc:io ... > > FAIL: io/check-installed-headers-c > > FAIL: io/check-installed-headers-cxx > > > > Running glibc:misc ... > > FAIL: misc/check-installed-headers-c > > FAIL: misc/check-installed-headers-cxx > > > > Running glibc:rt ... > > FAIL: rt/check-installed-headers-c > > FAIL: rt/check-installed-headers-cxx > > =3D=3D=3D > > > > Let me know if you need any help in reproducing these. The results are= for Ubuntu 22.04 armhf target, but results for Ubuntu 22.04 aarch64 show t= he same regressions. > > > > Interestingly the top-level check-installed-headers-* tests PASS: > > =3D=3D=3D > > PASS: check-installed-headers-c > > PASS: check-installed-headers-cxx > > =3D=3D=3D > > > >> > >> I could not reproduce it locally, so I think it is a limitation of our > >> (Linaro) CI framework, where not all tests artifacts are being removed > >> with make test-clean. Maxim already sent a fix for this [1]. > >> > >> [1] https://patchwork.sourceware.org/project/glibc/patch/2023061515254= 7.2924770-1-maxim.kuvyrkov@linaro.org/ > > > > Hi Adhemerval, > > > > We (Linaro) have fixed or added workarounds for all known testsuite sta= bility problems in our CI before enabling reporting for failed patches. I = am surprised that you could not reproduce the above failures in your setup;= let's troubleshoot your local setup offline. > > I think I figure out what is happening here. I am using toolchains built = with > scripts/build-many-glibcs.py which does not set fortify as default, diffe= rent > than distro that are now setting the it as default. > > Since in our CI we use the system compiler to check for header, fortify w= ill > be always enabled and thus breaking the testing. > > Fr=C3=A9d=C3=A9ric is fixing a lot of tests to assume fortify is enabled = as default, so > maybe it is something that he is already tracking. In any case, I think = we > should fix scripts/check-installed-headers.sh to check for different leve= ls > of _FORTIFY_SOURCE along with already in places flags. > I'm indeed working on a patch series to enable _FORTIFY_SOURCE while building Glibc, which may improve your situation. I expect the patchset will be out in the next few days (or even hours if everything goes right), so you might be able to check soon.