From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 09C5F388215A for ; Fri, 30 Jun 2023 15:58:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09C5F388215A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688140695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+X1RwJbp41Yut8ce1QQbTXgCXwxBp3weRmFy715G274=; b=hV3G/01e0id3ld9FfFMl89unRVACqjVpJlh17Mre78OEjXcUJ7A3lPC/5fhjIR6ly9qVJE ASrjBsP5VhMJ1sZOYisL4w4HBYX80KjQMUMn+I3KjJ1d4kuDzhIkwjXx5ocR3msau3IpmB BFJ7fGC3TDCK8lPXHoh+iJx37gRgHYU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-eHgP5EMlM1-XYjkex6Gyhg-1; Fri, 30 Jun 2023 11:58:11 -0400 X-MC-Unique: eHgP5EMlM1-XYjkex6Gyhg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b6a679df26so19652981fa.2 for ; Fri, 30 Jun 2023 08:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688140689; x=1690732689; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+X1RwJbp41Yut8ce1QQbTXgCXwxBp3weRmFy715G274=; b=FMz8ndtFBsyORsL0SeqS32uSDiZTVt2SQyNshVBcfZRK0TrNsy9FrIryeqBtyP/zPs GZXAEf1EcuVTzrxOVEDIWxF2MQr9+sDDxP1GmlDzssIzN9lRJjfC9TopBzXN7dQtT9in Ia+KKsyOTSRV4s6TuIs4M/+u+T3DGSz4vxq9u1P5BbSi2P7G7M/na7bKTVwkZ/zQwtLc PYesr7NJIXEYgWcIIy2VGFprTGx7TZcGCDnMZXWbli6RIvrC1P7W4d3HR+GkiFtR+s2R 8o9GE1avY+IzEDBkf378fwRuO2Cv7X2VqDkJRtIoSZHGvjIT0tzkOzXF6RX8BAFdyjhN QxFg== X-Gm-Message-State: ABy/qLbeSZz1qWy/5SlPbc28WWKWHKsYmZYuwa+LOhTQFOI20n5F3sVS Hq+T9IhbXWC36t5ro0KpxLoPm6aLlYAITFp7I3drTdOAPWJ5L6audEZZC+qQ2hoSz5LMmU3I53h GR5Y0BoYZaRa4Az793CRjm9Na6ADJ7eeA22ClXTfDUQhJ X-Received: by 2002:a2e:9057:0:b0:2b6:d0fc:ee18 with SMTP id n23-20020a2e9057000000b002b6d0fcee18mr1578820ljg.19.1688140689376; Fri, 30 Jun 2023 08:58:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlEd9tH8ftaRJXX4tuA7n9cvs1tlZCgdimLWFdYkRoGk+rvYNlXcb30fYnatVC3WMBCc5xLNNJ669dKTxWD05TY= X-Received: by 2002:a2e:9057:0:b0:2b6:d0fc:ee18 with SMTP id n23-20020a2e9057000000b002b6d0fcee18mr1578804ljg.19.1688140688986; Fri, 30 Jun 2023 08:58:08 -0700 (PDT) MIME-Version: 1.0 References: <20230628084246.778302-1-fberat@redhat.com> <20230628084246.778302-4-fberat@redhat.com> <8108ba62-564d-e6f4-e590-5e2463265ea0@linux.ibm.com> In-Reply-To: <8108ba62-564d-e6f4-e590-5e2463265ea0@linux.ibm.com> From: Frederic Berat Date: Fri, 30 Jun 2023 17:57:58 +0200 Message-ID: Subject: Re: [PATCH v3 03/16] sysdeps: Ensure ieee128*_chk routines to be properly named To: Paul E Murphy Cc: Siddhesh Poyarekar , libc-alpha@sourceware.org, Rajalakshmi Srinivasaraghavan X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000192fb305ff5ae241" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000192fb305ff5ae241 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2023 at 5:55=E2=80=AFPM Paul E Murphy wrote: > > > On 6/30/23 9:58 AM, Siddhesh Poyarekar wrote: > > > > > > On 2023-06-28 04:42, Fr=C3=A9d=C3=A9ric B=C3=A9rat wrote: > >> The *_chk routines naming doesn't match the name that would be generat= ed > >> using libc_hidden_ldbl_proto. Since the macro is needed for some of > >> these *_chk functions for _FORTIFY_SOURCE to be enabled, that needed to > >> be fixed. > >> While at it, all the *_chk function get renamed appropriately for > >> consistency, even if not strictly necessary. > >> --- > > > > LGTM, but I'd like Raji to pitch in as well as ppc maintainer. > > > This LGTM (on behalf of Raji). I am surprised this wasn't noticed > sooner. Was it not noticed because there are no internal calls within > libc to these functions? > > It wasn't noticed because the macros were not used nor needed as long as building glibc with fortification was forbidden by the configure script. > Reviewed-by: Paul E. Murphy > > > --000000000000192fb305ff5ae241--