From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9F73A3858D3C for ; Mon, 10 Jul 2023 05:57:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F73A3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688968622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lKRvGn4fdVngle7RYuYHGsCK6NvVMQYNsGpQp7GWM9U=; b=XTXNCxZD1ngee5l6sY5puvcwFEP1ffsYxXrFhdt7S3OFyR23A4x76mW3ZlRiDD4wofH+PS H1+iJ3tSwC1jC5NVYVBOH23BBC8qKAH16UvcKu02NdH8Os5xxUgeT4EIQIeDAjf6wVLLLO xM68XTPTDvp1QMKfUwT6aFkJkUJA388= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-445-rslG73KtPYy2UoSQVtCc1w-1; Mon, 10 Jul 2023 01:57:00 -0400 X-MC-Unique: rslG73KtPYy2UoSQVtCc1w-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-993c2d9e496so207170466b.0 for ; Sun, 09 Jul 2023 22:57:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688968619; x=1691560619; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lKRvGn4fdVngle7RYuYHGsCK6NvVMQYNsGpQp7GWM9U=; b=Y0VXrxgQnLbrO7XvE8m/jkKIfXheOw86OtiEZg7f0MAPgZAqLE51CZnKNGsvB4Q4v1 FFgRczAEE6SCeaZxuPWLHHLce2BG1ZwOPSOAjgGCqSlKULWQAGLn0qty78X+D/zmkFhI Z/vxTM4iIZfSFbD/1Gc54ZtlsfRML0Ik65hqd0tInTVlXUJ3LPikaegRyP1HSPgW2klv h13FmHq6no0YGIFdcu64kUHgRMuh4t8S7Whb/6POqH8MSHuGRZn5pOpckYwJ9rGTp0A3 L7hJ7c9tGl9Xu9K+0K/tOW772rzTA1HfVvqu3QcynIUlrWVjsslpz9VCMO+5ai1ujt6P 3XXA== X-Gm-Message-State: ABy/qLZZ/Nm432HaYKmdpSE99raPOnpn+rIn9k1ktnMAP87zUIh+hy+c 5geM0hPweWpitmi1aIfrhuUSOUuIWo+XaYeCU1kz7I/2EglXgMI2P9CKbtcp8nS9BBZ0kzLOnIC cxS0u9uCguFHWycLUOqB86x3JA3CeY32VgdWTSRazKAxkwes= X-Received: by 2002:a17:906:728f:b0:993:ec0b:1a1e with SMTP id b15-20020a170906728f00b00993ec0b1a1emr7647006ejl.26.1688968619576; Sun, 09 Jul 2023 22:56:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlEq7l8Njv6FSUFDs18rVzzrVPV1V8xdzSSOslFhr6GLIMT93lQaQpS1ZcOAt8dwMda9Ewtr4kXo+VXLCAmmi4E= X-Received: by 2002:a17:906:728f:b0:993:ec0b:1a1e with SMTP id b15-20020a170906728f00b00993ec0b1a1emr7646992ejl.26.1688968619268; Sun, 09 Jul 2023 22:56:59 -0700 (PDT) MIME-Version: 1.0 References: <20230705143822.275049-1-fberat@redhat.com> In-Reply-To: From: Frederic Berat Date: Mon, 10 Jul 2023 07:56:48 +0200 Message-ID: Subject: Re: [PATCH v6 00/14] Allow glibc to be built with _FORTIFY_SOURCE To: Andreas Schwab Cc: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQgdmlhIExpYmMtYWxwaGE=?= , siddhesh@gotplt.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000096aded06001ba60d" X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000096aded06001ba60d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 6, 2023 at 3:38=E2=80=AFPM Andreas Schwab wrot= e: > > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:gli= bc/glibc/s/s390x > > gcc ../sysdeps/s390/memmove-c.c -c -std=3Dgnu11 -fgnu89-inline -O2 -Wall > -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection > -Werror=3Dreturn-type -g -Wall -Wwrite-strings -Wundef -Werror > -fmerge-all-constants -frounding-math -fstack-protector-strong -fno-common > -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3D3 -Wstrict-prototypes > -Wold-style-definition -fmath-errno -mlong-double-128 -fPIE > -ftls-model=3Dinitial-exec -I../include > -I/home/abuild/rpmbuild/BUILD/glibc-2.37.9000.594.g5324d25842/cc-base/str= ing > -I/home/abuild/rpmbuild/BUILD/glibc-2.37.9000.594.g5324d25842/cc-base > -I../sysdeps/unix/sysv/linux/s390/s390-64 > -I../sysdeps/unix/sysv/linux/wordsize-64 > -I../sysdeps/unix/sysv/linux/s390/fpu -I../sysdeps/s390/fpu > -I../sysdeps/unix/sysv/linux/s390 -I../sysdeps/s390/nptl > -I../sysdeps/ieee754/ldbl-64-128 -I../sysdeps/ieee754/ldbl-opt > -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux > -I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu > -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix > -I../sysdeps/posix -I../sysdeps/s390/s390-64 -I../sysdeps/wordsize-64 > -I../sysdeps/s390/multiarch -I../sysdeps/s390 > -I../sysdeps/ieee754/ldbl-128 -I../sysdeps/ieee754/dbl-64 > -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysdeps/generic > -I.. -I../libio -I. -D_LIBC_REENTRANT -include > /home/abuild/rpmbuild/BUILD/glibc-2.37.9000.594.g5324d25842/cc-base/libc-= modules.h > -DMODULE_NAME=3Dlibc -include ../include/libc-symbols.h -DPIC > -DTOP_NAMESPACE=3Dglibc -o > /home/abuild/rpmbuild/BUILD/glibc-2.37.9000.594.g5324d25842/cc-base/strin= g/memmove-c.o > -MD -MP -MF > /home/abuild/rpmbuild/BUILD/glibc-2.37.9000.594.g5324d25842/cc-base/strin= g/memmove-c.o.dt > -MT > /home/abuild/rpmbuild/BUILD/glibc-2.37.9000.594.g5324d25842/cc-base/strin= g/memmove-c.o > In file included from ../sysdeps/s390/memmove-c.c:36: > ../string/memmove.c:44:1: error: optimization attribute on 'memmove' > follows definition but the attribute doesn't match [-Werror=3Dattributes] > 44 | { > | ^ > In file included from ../include/sys/cdefs.h:10, > from ../include/features.h:503, > from ../posix/sys/types.h:25, > from ../include/sys/types.h:1, > from ../include/string.h:6, > from ../string/memmove.c:20: > ../string/bits/string_fortified.h:34:8: note: previous definition of > 'memmove' with type 'void *(void *, const void *, size_t)' {aka 'void > *(void *, const void *, long unsigned int)'} > 34 | __NTH (memmove (void *__dest, const void *__src, size_t __len)) > | ^~~~~~~ > ../misc/sys/cdefs.h:81:62: note: in definition of macro '__NTH' > 81 | # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct > | ^~~ > cc1: all warnings being treated as errors > > Hello, Please review https://patchwork.sourceware.org/project/glibc/patch/20230707145425.535014-= 1-fberat@redhat.com/ --=20 > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different." > > --00000000000096aded06001ba60d--