From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36082 invoked by alias); 25 Jun 2018 17:16:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 36064 invoked by uid 89); 25 Jun 2018 17:16:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=partially X-HELO: mail-io0-f193.google.com MIME-Version: 1.0 In-Reply-To: <9b8c0727-f285-d779-27fc-7af294e44e45@redhat.com> References: <9b8c0727-f285-d779-27fc-7af294e44e45@redhat.com> From: Patsy Franklin Date: Mon, 25 Jun 2018 17:16:00 -0000 Message-ID: Subject: Re: [PATCH] Initialize pad outside the conditional to prevent uninitialized data warnings. To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-06/txt/msg00745.txt.bz2 Hi Florian, On Mon, Jun 25, 2018 at 10:39 AM, Florian Weimer wrote: > On 06/25/2018 04:18 PM, Patsy Franklin wrote: >> >> Prior to this change, valgrind warned about unitialized bytes on >> ppc64, ppc64le, s390x, and aarch64. > > > How come that valgrind warns when it's supposed to be uninitialized padding? The problem occurs when the partially initialized struct is written to the file system. I should have stated this in the original description. Thanks, Patsy