public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Cristian Rodríguez" <crrodriguez@opensuse.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] linux: posix_spawn: return EINVAL on argc < 1
Date: Wed, 23 Mar 2022 11:40:43 -0300	[thread overview]
Message-ID: <CAPBLoAcG3cQoGdCL+PWbcSMD7gKd0LhjRi96qtCF2Sm7Lcs_Yg@mail.gmail.com> (raw)
In-Reply-To: <CAPBLoAebfBNRWgrOGpv7osaHcLVMrpTa4mpX-c_x=FZAZT46mg@mail.gmail.com>

On Fri, Jan 28, 2022 at 10:04 PM Cristian Rodríguez
<crrodriguez@opensuse.org> wrote:
>
> On Fri, Jan 28, 2022 at 8:49 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> > Errors for argc == 0 (with argv != NULL) are contrary to POSIX, which
> > allows that case other than for Strictly Conforming POSIX Applications,
>
> The case you mention as valid are rejected by BSDs.. QNX and others.
> so portable applications cannot rely on this either.
> .
> freebsd head and openbsd -EINVAL with argc == 0 and has never allowed
> argv to be NULL  (EFAULTs)

it has been now addressed in the kernel

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dcd46d897adb70d63e025f175a00a89797d31a43

I think all the linux specific code in glibc at least should behave
like that for consistency.

  reply	other threads:[~2022-03-23 14:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 13:39 Cristian Rodríguez
2022-01-28 15:26 ` Cristian Rodríguez
2022-01-28 17:07   ` Adhemerval Zanella
2022-01-28 18:03     ` Joseph Myers
2022-01-28 23:05       ` Adhemerval Zanella
2022-01-28 23:26         ` Joseph Myers
2022-01-28 23:35           ` Cristian Rodríguez
2022-01-28 23:49             ` Joseph Myers
2022-01-29  1:04               ` Cristian Rodríguez
2022-03-23 14:40                 ` Cristian Rodríguez [this message]
2022-01-28 19:08     ` Cristian Rodríguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPBLoAcG3cQoGdCL+PWbcSMD7gKd0LhjRi96qtCF2Sm7Lcs_Yg@mail.gmail.com \
    --to=crrodriguez@opensuse.org \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).