From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cr@cristianrodriguez.net>
Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com
 [209.85.221.51])
 by sourceware.org (Postfix) with ESMTPS id A3973385840C
 for <libc-alpha@sourceware.org>; Fri, 28 Jan 2022 19:08:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3973385840C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=opensuse.org
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=cristianrodriguez.net
Received: by mail-wr1-f51.google.com with SMTP id a13so12664386wrh.9
 for <libc-alpha@sourceware.org>; Fri, 28 Jan 2022 11:08:23 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=tSU2oawuUyHqSpFVsy533oBUOHMgoVRc6PTSBZsus/E=;
 b=dk9cVMF0E3d22/X2AZQMWwmZQwRRwqui412yq6lA7EjtAkVdXAYHONMgd9F+yn38UI
 SHcxy+azQOszUH+zKFMUqT+sUEDCz2e1DFfDPFTxOhaI5FTRdQ5CVLn6hOI9JTI4V6vO
 N895siclb4q7pMhd+takUQYzvD2R0yylDJhpomCOsIE7PZUB3ETeArhdQ5JLmiBl8YgB
 tYrF7lBxPB9dlc18a464AbhiGrdZX1R+PTQ+c5CIZKn00dpH9FmEezGjfRid612UlrTG
 ryl72cUzBe4y4BI7KceRI0NcVM+Y4/ROAioACISQEJ8hSz1aTYD7Xh3UWVbt/EsbDGym
 0VYg==
X-Gm-Message-State: AOAM533jWuloo2WiXMrHlGndi8/1RaeIVdxJnr647UbkLQQdPCmIw/aW
 B+hNM13MrVbdWU83m360AIsOw560r/zGHILXQRX8VOLs6srZsw==
X-Google-Smtp-Source: ABdhPJzJXOg34Cv9v1NGyGnUYubLbk9mnal0ih14nkogMe8CHHC1iIeGHzjHOKxFR4iVPEMRh1uTGADyYZllezEhuq8=
X-Received: by 2002:a5d:6a12:: with SMTP id m18mr7930741wru.528.1643396902412; 
 Fri, 28 Jan 2022 11:08:22 -0800 (PST)
MIME-Version: 1.0
References: <20220128133937.9555-1-crrodriguez@opensuse.org>
 <CAPBLoAcQYmDEh5DwtgZeg6C_E6tSCT4ix7WMm8u6+x8KCSBDnA@mail.gmail.com>
 <a9828191-eb42-ded7-a29f-2768ed94d906@linaro.org>
In-Reply-To: <a9828191-eb42-ded7-a29f-2768ed94d906@linaro.org>
From: =?UTF-8?Q?Cristian_Rodr=C3=ADguez?= <crrodriguez@opensuse.org>
Date: Fri, 28 Jan 2022 16:08:11 -0300
Message-ID: <CAPBLoAcjZexjN59tCjSEH6r8Rg1FmWyDtEVG9P8oOxMAbK4D4w@mail.gmail.com>
Subject: Re: [PATCH 2/2] linux: posix_spawn: return EINVAL on argc < 1
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_NUMSUBJECT,
 RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jan 2022 19:08:25 -0000

hi, thanks for reading...

On Fri, Jan 28, 2022 at 2:07 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:

>   2. Add the proper check on generic, Linux, and Hurd implementation execveat.

but what is the proper check.. ?

if (path == NULL || argv == NULL || envp == NULL || argv[0] == NULL)
    {
      __set_errno (EINVAL);
      return -1;
  }

or should I also check fd for validity.. I do not think so.. rhave to
special case various combinations in that case... (AT_FCWD, absolute
vs relative "path".. vs dirfd..nope..)