From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by sourceware.org (Postfix) with ESMTPS id 419CD3858D1E for ; Mon, 1 May 2023 21:52:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 419CD3858D1E Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=rodriguez.im Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cristianrodriguez.net Received: by mail-ua1-x933.google.com with SMTP id a1e0cc1a2514c-771ef819305so185298241.1 for ; Mon, 01 May 2023 14:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rodriguez.im; s=google; t=1682977948; x=1685569948; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nc4ogv+4KQAA6cIp0X9INYs2hC+MGf3hvjSxzq7wyKg=; b=Wpzq6meQHyzrgJyIqENk7oHu/K5GKuzvKobjuP0vynh29e3m3X3c6WxaV1ykrllNjg q65mAZrdadNiy2uoLqRVnoggbFHh6IEIYXLuIdugfM80ov+i5Iyko3aMhrNglZOU+OdD wKoHJg5OW8vIp+AuRkkTF3tgTPIsTL2j3ZJ5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682977948; x=1685569948; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nc4ogv+4KQAA6cIp0X9INYs2hC+MGf3hvjSxzq7wyKg=; b=AlUH0wrN6PqYVIzBmaBv0ku6B3OTYa9C3Z0We+/es89TJjjvGaUksKuyZzB/igXRn1 HyLJZkY1+cz807eTeni+iq2btkCsc2VzsVu+9e6Q4EfBxetPLKrHiCZHXpqBawfR8B03 lVXNaqP+DvaSn52kYsnLP3KduoO6b/l+gzcESfS+mpxQDSsXRqHbuJ878YJbTmdY2RWm anP7IBxHp1ox6kOOvMNIEIUzh7VH0sjs5APP1DBt1m2Ilauc/8ptYZ5M7piLDhDyy9qd k6tgUTL5EkFucIPn2MahZnE41VrTWuxI/sNcZbnh0DaTnzgAgQsw2pTj3S1Tuwiq6TJ9 mo6w== X-Gm-Message-State: AC+VfDwQQ7PX3xkGmpmGuZiHnMNJKsSiXbwMcVIg11CsrZczjUISBWFc kX0yDkAiOB8iWfVYrUwQITfGjksjFNpFgVBJWJqwag== X-Google-Smtp-Source: ACHHUZ4KIFXov8tjHWTErLHJy7qLlFaqGLMQtDvAuCVqwzRbt8cO3Owp4IysQM0igTsvdRCMRxVx2FHXpVjArBlslv0= X-Received: by 2002:a05:6122:1804:b0:431:f9cd:5a27 with SMTP id ay4-20020a056122180400b00431f9cd5a27mr162026vkb.1.1682977948464; Mon, 01 May 2023 14:52:28 -0700 (PDT) MIME-Version: 1.0 References: <20230429131223.2507236-1-bugaevc@gmail.com> <20230429131223.2507236-3-bugaevc@gmail.com> In-Reply-To: <20230429131223.2507236-3-bugaevc@gmail.com> From: =?UTF-8?Q?Cristian_Rodr=C3=ADguez?= Date: Mon, 1 May 2023 17:52:17 -0400 Message-ID: Subject: Re: [PATCH 3/3] Mark various cold functions as __COLD To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org, Samuel Thibault Content-Type: multipart/alternative; boundary="000000000000c8915105faa8d6ab" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000c8915105faa8d6ab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable a On Sat, Apr 29, 2023 at 9:12=E2=80=AFAM Sergey Bugaev via Libc-alpha < libc-alpha@sourceware.org> wrote: > GCC docs explicitly list perror () as a good candidate for using > __attribute__ ((cold)). So apply __COLD to perror () and similar > functions. > abort() and all the function wrappers called by assert on failure are also cold. Cheers! > --000000000000c8915105faa8d6ab--