From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by sourceware.org (Postfix) with ESMTPS id B37EA385275C for ; Tue, 18 Apr 2023 13:48:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B37EA385275C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=opensuse.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cristianrodriguez.net Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-771e0f8b541so172545241.0 for ; Tue, 18 Apr 2023 06:48:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681825733; x=1684417733; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lA7cRao+z9hLkZEpnGgV8kJRw5Ev86O/nx648iGB/FA=; b=Gz3zUa+E7RCgds37HImLLW1uY/uMehDDlA2y/CseTHEwA5M1MWItvQazWuehDJeN1o uXqAGEQzrnTEOmOWJtDQfsH5bVMbV0um8LkJJNMdNG0dTdws4RA1zb4fPdbiZJA1lQ0a gS0YH5I2Xi18D/T54bmqdIQRFX91QGF7aZkFdmFXlcaZ3a02gZA2xk2g2pgDrFS7bGGD 69SnS43cUXEKJB5GVwRwsCAJ+rKT8DMrUhTpBjMdtpl4qB2hs2DuEOFwy7BLbXrY/nxi DhtdBdp4Q65DioBbai4wbBJcguw9rNhJXH+cArgqMgbOrtkAu3tmtNZ7kZHpmPXHiTEn Kc6Q== X-Gm-Message-State: AAQBX9c6VIyftdSNOgxdpWPnR27/NDHQLaTSVJsfWGWIjKQ2ZobV6Cfd i52SS2GqbaLS8eiE7cbmxfLvGmBopT21T/TyrXsh7MTTpYFacGYJhAk= X-Google-Smtp-Source: AKy350YQbJSna3RP+uf4g0YSGGOLM4H5k6XeDxAuZMQ2N4msp4s+np0lxOLCDy1e7txW998ET330lqIrAKBP/3q1yTQ= X-Received: by 2002:a67:c889:0:b0:42c:4cf7:6ebf with SMTP id v9-20020a67c889000000b0042c4cf76ebfmr4155046vsk.2.1681825732869; Tue, 18 Apr 2023 06:48:52 -0700 (PDT) MIME-Version: 1.0 References: <20230417225857.2006561-1-bugaevc@gmail.com> <20230417225857.2006561-2-bugaevc@gmail.com> <19b6b831-49c5-4db4-292c-349d36bb16ce@linaro.org> In-Reply-To: <19b6b831-49c5-4db4-292c-349d36bb16ce@linaro.org> From: =?UTF-8?Q?Cristian_Rodr=C3=ADguez?= Date: Tue, 18 Apr 2023 09:48:41 -0400 Message-ID: Subject: Re: [RFC PATCH 1/5] misc: Convert daemon () to GNU coding style To: Adhemerval Zanella Netto Cc: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org, Samuel Thibault Content-Type: multipart/alternative; boundary="00000000000061d64405f99c912b" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,URI_DOTEDU autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000061d64405f99c912b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 18, 2023 at 8:02=E2=80=AFAM Adhemerval Zanella Netto via Libc-a= lpha < libc-alpha@sourceware.org> wrote: > > > On 17/04/23 19:58, Sergey Bugaev via Libc-alpha wrote: > > This is nicer, and is going to be required for the following changes > > to reasonably stay within the 79 column limit. > > > > No functional change. > > > > Signed-off-by: Sergey Bugaev > > LGTM, some minor nits below. > > > --- > > misc/daemon.c | 88 ++++++++++++++++++++++++++++----------------------- > > 1 file changed, 49 insertions(+), 39 deletions(-) > > > > diff --git a/misc/daemon.c b/misc/daemon.c > > index 3c73ac2a..61da49b7 100644 > > --- a/misc/daemon.c > > +++ b/misc/daemon.c > > @@ -43,50 +43,60 @@ static char sccsid[] =3D "@(#)daemon.c 8.1 > (Berkeley) 6/4/93"; > > > I think there is no need to ignore return code. > > > Also This code clearly comes from freeBSD.. which has since updated the code to ignore SIGHUP when the parent exits. https://web.mit.edu/freebsd/head/lib/libc/gen/daemon.c --00000000000061d64405f99c912b--