From: Daniel Alvarez Sanchez <dalvarez@redhat.com>
To: adhemerval.zanella@linaro.org
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] [BZ #21812] getifaddrs() Don't return ifa entries with NULL names
Date: Fri, 29 Jun 2018 06:58:00 -0000 [thread overview]
Message-ID: <CAPXMuf-mJk9QXxn9+cbwpqyUcTo3EMjQCXW9WqDjdJo8ucs+EA@mail.gmail.com> (raw)
In-Reply-To: <2a3d6cc5-b05e-434f-3059-992da1dbd219@linaro.org>
Thanks a lot for reviewing. It'd be nice to get this in soon as it can
happen easily on systems with lots of interfaces.
Here it's a reproducer:
$ sudo unshare -n
# cat create-links.sh
#!/bin/bash
for i in {1..512}; do ifname="dum$i"; ip li add $ifname type dummy; ip
li set $ifname up; done
# ./create-links.sh
# cat loop-add-del-link.sh
#!/bin/bash
while :; do ifname="test$RANDOM"; ip li add $ifname type dummy; ip li
set $ifname up; sleep 0.1; ip li del $ifname; done
# ./loop-add-del-link.sh &
[1] 6260
# ./loop-add-del-link.sh &
[2] 6314
# ./loop-add-del-link.sh &
[3] 6374
# ./loop-add-del-link.sh &
[4] 6476
# ./loop-add-del-link.sh &
[5] 6628
# cat dalvarez-tester.c
#include <sys/types.h>
#include <ifaddrs.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
int main(void)
{
struct ifaddrs *ifaddr, *ifa;
for (;;)
{
if (getifaddrs(&ifaddr) == -1) {
perror("getifaddrs");
return EXIT_FAILURE;
}
/* Walk through linked list, maintaining head pointer so we
can free list later */
for (ifa = ifaddr; ifa != NULL; ifa = ifa->ifa_next) {
if (ifa->ifa_name == NULL) {
printf("Gotcha!!!!\n");
return EXIT_FAILURE;
}
}
freeifaddrs(ifaddr);
usleep(10);
}
return EXIT_SUCCESS;
}
On Fri, Jun 15, 2018 at 9:13 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 15/06/2018 10:29, Daniel Alvarez wrote:
> > Due to bug 21812, a lookup operation in map_newlink() turns out
> > into an insert because of holes in the interface part of the map.
> > This leads to incorrectly set the name of the interface to NULL when
> > the interface is not present for the address being processed (most
> > likely because the interface was added between the RTM_GETLINK and
> > RTM_GETADDR calls to the kernel). When such changes are detected
> > by the kernel, it'll mark the dump as "inconsistent" by setting
> > NLM_F_DUMP_INTR flag on the next netlink message.
> >
> > This patch checks this condition and retries the whole operation.
> > Hopes are that next time the interface corresponding to the address
> > entry is present in the list and correct name is returned.
> >
> > Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
> > Signed-off-by: Jakub Sitnicki <jkbs@redhat.com>
>
> We don't use DCO, instead we use copyright assignments. However the
> change below seems to fit as a trivial change.
>
> Patch looks good and I can't think in a easy way to add testcase which
> is guarantee to be reproducible (maybe by using a network namespace and
> force inject an interface so kernel will set NLM_F_DUMP_INTR?).
>
> > ---
> > sysdeps/unix/sysv/linux/ifaddrs.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/sysdeps/unix/sysv/linux/ifaddrs.c b/sysdeps/unix/sysv/linux/ifaddrs.c
> > index 32381f54e4..5659c9605b 100644
> > --- a/sysdeps/unix/sysv/linux/ifaddrs.c
> > +++ b/sysdeps/unix/sysv/linux/ifaddrs.c
> > @@ -370,6 +370,14 @@ getifaddrs_internal (struct ifaddrs **ifap)
> > if ((pid_t) nlh->nlmsg_pid != nh.pid || nlh->nlmsg_seq != nlp->seq)
> > continue;
> >
> > + /* If the dump got interrupted, we can't relay on the results so
> > + try again. */
> > + if (nlh->nlmsg_flags & NLM_F_DUMP_INTR)
> > + {
> > + result = -EAGAIN;
> > + goto exit_free;
> > + }
> > +
> > if (nlh->nlmsg_type == NLMSG_DONE)
> > break; /* ok */
> >
> >
next prev parent reply other threads:[~2018-06-29 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 13:29 Daniel Alvarez
2018-06-15 19:12 ` Adhemerval Zanella
2018-06-29 6:58 ` Daniel Alvarez Sanchez [this message]
2018-06-29 9:38 ` Florian Weimer
2018-06-29 8:22 ` Florian Weimer
-- strict thread matches above, loose matches on Subject: below --
2017-07-24 20:58 Daniel Alvarez
2017-08-29 10:37 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPXMuf-mJk9QXxn9+cbwpqyUcTo3EMjQCXW9WqDjdJo8ucs+EA@mail.gmail.com \
--to=dalvarez@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).