From: "Rodriguez Bahena, Victor" <victor.rodriguez.bahena@intel.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH V3] benchtests: Expand range of tests names in schema.json
Date: Fri, 24 Nov 2017 21:27:00 -0000 [thread overview]
Message-ID: <D63DEA74.1CA86%victor.rodriguez.bahena@intel.com> (raw)
In-Reply-To: <2616ac26-1f46-aeea-5526-ad4b1a1fcf3e@gotplt.org>
-----Original Message-----
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
Date: Thursday, November 23, 2017 at 12:08 PM
To: Victor Rodriguez Bahena <victor.rodriguez.bahena@intel.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH V3] benchtests: Expand range of tests names in
schema.json
>
>
>On Thursday 23 November 2017 11:31 PM, Victor Rodriguez wrote:
>> When executing bench-math the benchmark output is invalid with this
>> error msg:
>>
>> Invalid benchmark output: 'workload-spec2006.wrf' does not match
>>any of
>> the regexes: '^[_a-zA-Z0-9]*$¹ or Invalid benchmark output:
>>Additional
>> properties are not allowed ('workload-spec2006.wrf' was unexpected)
>>
>> The error was seen when running the test:
>> workload-spec2006.wrf, 'stack=1024,guard=1' and 'stack=1024,guard=2'.
>> The problem is that the current regex's do not accept the hyphen, dot,
>>equal
>> and comma in the output.
>>
>> This patch changes the regex in benchout.schema.json to accept symbols
>>in
>> benchmark tests names.
>>
>> ChangeLog:
>>
>> * benchtests/scripts/benchout.schema.json: Fix regex to accept a
>> wider range of tests names.
>>
>> Signed-off-by: Victor Rodriguez <victor.rodriguez.bahena@intel.com>
>
>OK.
>
>Reviewed-By: Siddhesh Poyarekar <siddhesh@sourceware.org>
Thanks Siddhesh
Are these patches ok for master ? Could you please merge them ?
Regards
Victor
>> ---
>> ChangeLog | 5 +++++
>> benchtests/scripts/benchout.schema.json | 2 +-
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 64a8d9c8ea..73df200dbb 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,8 @@
>> +2017-11-22 Victor Rodriguez <victor.rodriguez.bahena@intel.com>
>> +
>> + * benchtests/scripts/benchout.schema.json: Fix regex to accept a wider
>> + range of tests names.
>> +
>> 2017-11-21 Mike FABIAN <mfabian@redhat.com>
>>
>> [BZ #15537]
>> diff --git a/benchtests/scripts/benchout.schema.json
>>b/benchtests/scripts/benchout.schema.json
>> index affb7c11f4..815ad9735a 100644
>> --- a/benchtests/scripts/benchout.schema.json
>> +++ b/benchtests/scripts/benchout.schema.json
>> @@ -13,7 +13,7 @@
>> "title": "Function names",
>> "type": "object",
>> "patternProperties": {
>> - "^[_a-zA-Z0-9]*$": {
>> + "^[_a-zA-Z0-9,=.-]*$": {
>> "title": "Function variants",
>> "type": "object",
>> "properties": {
>>
next prev parent reply other threads:[~2017-11-24 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 18:04 Victor Rodriguez
2017-11-23 18:08 ` Siddhesh Poyarekar
2017-11-24 21:27 ` Rodriguez Bahena, Victor [this message]
2017-11-28 14:40 ` Siddhesh Poyarekar
2017-11-28 15:36 ` Rodriguez Bahena, Victor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D63DEA74.1CA86%victor.rodriguez.bahena@intel.com \
--to=victor.rodriguez.bahena@intel.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).