From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Joseph Myers <joseph@codesourcery.com>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Cc: GNU C Library <libc-alpha@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH 03/10] Improve performance of sinf and cosf
Date: Wed, 15 Aug 2018 13:11:00 -0000 [thread overview]
Message-ID: <DB5PR08MB10308D8D6ABDADB8BF9B587C833F0@DB5PR08MB1030.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1808141936560.21830@digraph.polyomino.org.uk>
Joseph Myers wrote:
> The ulps updates here broke the testsuite build for x86_64 through adding
> invalid "ifloat:1" and "float:1" lines (missing space after colon) to
> sysdeps/x86_64/fpu/libm-test-ulps. I don't know quite how you generated
> those changes to libm-test-ulps; "make regen-ulps" should never generate
> such invalid lines, either before or after my move of it from perl to
> python.
Sorry, it seems I copied and pasted some fields incorrectly. I've committed a
fix with the spaces, the libm-test-ulps is now identical to the latest regen output.
Wilco
Fix spaces in x86_64 ULP file
Fix a few missing spaces, it's now identical to the regenerated version.
Passes GLIBC tests on x64.
ChangeLog:
2018-08-15 Wilco Dijkstra <wdijkstr@arm.com>
* sysdeps/x86_64/fpu/libm-test-ulps: Regenerate to fix spaces.
--
diff --git a/sysdeps/x86_64/fpu/libm-test-ulps b/sysdeps/x86_64/fpu/libm-test-ulps
index a51faecfc72342904d7c0ecb1ae90a03c14a7cad..e26f9c13586dc90bf7af42ca0994da3eb489ff45 100644
--- a/sysdeps/x86_64/fpu/libm-test-ulps
+++ b/sysdeps/x86_64/fpu/libm-test-ulps
@@ -2548,14 +2548,14 @@ double: 1
float: 1
float128: 3
idouble: 1
-ifloat:1
+ifloat: 1
ifloat128: 3
ildouble: 3
ldouble: 3
Function: "sin_towardzero":
double: 1
-float:1
+float: 1
float128: 2
idouble: 1
ifloat: 1
@@ -2565,7 +2565,7 @@ ldouble: 2
Function: "sin_upward":
double: 1
-float:1
+float: 1
float128: 3
idouble: 1
ifloat: 1
next prev parent reply other threads:[~2018-08-15 13:11 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 8:49 [PATCH 00/10] Optimized math routines Szabolcs Nagy
2018-07-06 8:57 ` [PATCH 01/10] Clean up converttoint handling and document the semantics Szabolcs Nagy
2018-08-07 19:52 ` Joseph Myers
2018-07-06 8:57 ` [PATCH 02/10] Improve performance of sincosf Szabolcs Nagy
2018-07-11 13:22 ` Szabolcs Nagy
2018-08-07 20:11 ` Joseph Myers
2018-08-10 12:12 ` Wilco Dijkstra
2018-08-10 16:04 ` Joseph Myers
2018-07-06 8:59 ` [PATCH 03/10] Improve performance of sinf and cosf Szabolcs Nagy
2018-08-13 19:46 ` Joseph Myers
2018-08-14 19:41 ` Joseph Myers
2018-08-15 13:11 ` Wilco Dijkstra [this message]
2018-07-06 9:02 ` [PATCH 04/10] Add new exp and exp2 implementations Szabolcs Nagy
2018-08-22 19:55 ` Joseph Myers
2018-09-05 15:26 ` Szabolcs Nagy
2018-07-06 9:04 ` [PATCH 05/10] aarch64: update libm-test-ulps Szabolcs Nagy
2018-08-24 17:09 ` Joseph Myers
2018-07-06 9:05 ` [PATCH 06/10] arm: " Szabolcs Nagy
2018-07-06 9:06 ` [PATCH 07/10] x86_64: " Szabolcs Nagy
2018-07-06 9:08 ` [PATCH 08/10] Add new log implementation Szabolcs Nagy
2018-08-24 17:19 ` Joseph Myers
2018-07-06 9:09 ` [PATCH 09/10] Add new log2 implementation Szabolcs Nagy
2018-07-06 9:10 ` [PATCH 10/10] Add new pow implementation Szabolcs Nagy
2018-07-11 13:24 ` Szabolcs Nagy
2018-07-06 12:43 ` [PATCH 00/10] Optimized math routines Carlos O'Donell
2018-07-06 15:46 ` Szabolcs Nagy
2018-07-06 16:27 ` Carlos O'Donell
2018-07-06 17:17 ` Szabolcs Nagy
2018-07-09 12:15 ` Szabolcs Nagy
2018-07-09 13:09 ` Adhemerval Zanella
2018-07-09 13:35 ` Szabolcs Nagy
2018-07-09 14:27 ` Adhemerval Zanella
2018-07-09 15:41 ` Szabolcs Nagy
2018-07-09 18:20 ` Adhemerval Zanella
2018-07-17 21:59 ` Joseph Myers
2018-07-18 0:07 ` Carlos O'Donell
2018-07-11 13:39 ` Szabolcs Nagy
2018-07-11 14:19 ` [PATCH] powerpc: update libm-test-ulps Szabolcs Nagy
2018-07-12 15:52 ` [PATCH] update libm-test-ulps for new exp Szabolcs Nagy
2018-07-18 17:25 ` Joseph Myers
2018-07-19 9:15 ` Szabolcs Nagy
2018-07-19 17:03 ` Joseph Myers
2018-07-19 17:15 ` Wilco Dijkstra
2018-07-19 17:23 ` Joseph Myers
2018-08-07 11:03 ` [PATCH 00/10] Optimized math routines Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR08MB10308D8D6ABDADB8BF9B587C833F0@DB5PR08MB1030.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).