From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by sourceware.org (Postfix) with ESMTPS id 093A23857C48 for ; Tue, 31 May 2022 09:42:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 093A23857C48 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LT3frilVGdLhgLPs+q44yBUGHA7TeSdc61v2mUrSPdU3/C0RJbro4E2aonGzNim9Nr0DHo5KS2rKjsGLr3TcjtBXBxaXWlSk24L6PQNwGgXoS+edkHk1bI3J+/pIkbnrPXqrLM2Weqm76GnqVqFQzRSwDRK349FUwRmEj3PmolCg+Njbg+HjgpFgljwMobk9QE9RFmR40d6uMdEYyt+jboOE2SQnoZD9FKnKU1GOXrUVrKNuueP4ezSTf3q07100m1XL2n08PxgbQ4z/5XLRGbW2USxWZ1B7OKulwWtXmYzRTQFIqsSa+yzmIcR7JE+1xFM8FkJluC4KY7aYsakMUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MbsesthtZF5L3vr5ylhCFnTpzW5FdPv/M/0mJXpYkr8=; b=Wa8U3iKFHfX0MNW2raV1ZF7/kcLXfVuAZWaVrPKiZhoAlmf7SY1MuvP3R8AVM2W/KmvQVzkmz0gfPoN+aKYbrdjbtVQrhxs7isEIwNtsuzfW5nsE1mgqHR7Kapcrs848uauz5pkCpDuPpDi77sYz3R90JsV/sxj/SQfLNo6jm8TfAxOvY55PPketWShKmBs4m13FthKwsVU0kkwFR5RY37EGAYBaSrmcPHZ8RaAeKXqun7oh0Es/E5OSRbCZrv4Uez8wmtHKlYI0gmZ0yMGKzJ3nQ2MeNXmZMBCfPhBYz+h98mT4AVXhi0gOxMZTZzKAk1PxmdcLwbSyzPxJUvbUAQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB8PR06CA0052.eurprd06.prod.outlook.com (2603:10a6:10:120::26) by DB7PR08MB3147.eurprd08.prod.outlook.com (2603:10a6:5:1d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 09:42:27 +0000 Received: from DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::e5) by DB8PR06CA0052.outlook.office365.com (2603:10a6:10:120::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 09:42:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT004.mail.protection.outlook.com (100.127.142.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 09:42:27 +0000 Received: ("Tessian outbound 5b5a41c043d3:v120"); Tue, 31 May 2022 09:42:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fe85c93ce724013a X-CR-MTA-TID: 64aa7808 Received: from 61ea7178953c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F0609850-1C23-47B2-8C32-4F4176E67359.1; Tue, 31 May 2022 09:42:20 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 61ea7178953c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 May 2022 09:42:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cxv94KE4kNTP//zGY/+ab5YfWtARBQTa6FtGwEwU4rKI8xtAFSJDptWdnBkBfeVndVTD2pSmiF4SClmlabP8x8u7JQr38H+qt03T2zFsY1t9A6VMj4G0gi9gYC4lVd+M1Q05GCXs7LhOqPLsnyNZO0q0XxCSe/1o8okIwuHkkJU0uhyXBPG3ou2wR+W/WDSUBjG5Nuiu2LIiMKRPKsNg+NrA7CYtJapmRwh2nJfXbJhouUyPFPWLdgEOPBSy/mc1c+dLM/VYkBSFOgxoHJRPhV0GW5fG7FxN8MhhUStKZRlOy0BdTPP3q5fHGN+mZdvMwoL1jaLH+rognoBdgyVUqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MbsesthtZF5L3vr5ylhCFnTpzW5FdPv/M/0mJXpYkr8=; b=XBALSmIdBEP8wA3UAnMlsH6Upu+a+hQ+dY0XeBQStdRV03sXFVERlH+5byXgsaVSrJiIa5AVvdezRWTCvrxnENHYSAthjjEycGANQaiXklqu9NS3ylNoJEUm8PYpNiqocgWnQLZPEqXEw1clXxZ+rJwHXbK8NwjHGSkCdsjohhdplZDiOyOZkbR/XVPf2XD7Lk6ELPoMJvF7T8ZOsypwHFrx1TJrq6QU7df8azqzF11WaFGEDsbC93rLLleGG8MskahArHr14X0D1ubdPoDb5ZjsS/3q7PWT70ONadRd5a8Aw5aztx96HdCK02GU7eZlowrDjXYVAEN26Pbalh2VMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from DB6PR0801MB1879.eurprd08.prod.outlook.com (2603:10a6:4:73::9) by AM8PR08MB5859.eurprd08.prod.outlook.com (2603:10a6:20b:1c6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 09:42:13 +0000 Received: from DB6PR0801MB1879.eurprd08.prod.outlook.com ([fe80::4ce6:bb17:9240:2c69]) by DB6PR0801MB1879.eurprd08.prod.outlook.com ([fe80::4ce6:bb17:9240:2c69%10]) with mapi id 15.20.5293.019; Tue, 31 May 2022 09:42:13 +0000 From: Wilco Dijkstra To: Fangrui Song , "H.J. Lu" CC: Florian Weimer , Szabolcs Nagy , "libc-alpha@sourceware.org" Subject: Re: [PATCH 2/3] Revert "[AArch64][BZ #17711] Fix extern protected data handling" Thread-Topic: [PATCH 2/3] Revert "[AArch64][BZ #17711] Fix extern protected data handling" Thread-Index: AQHYb3AQ5vf+RU34WECR0bcI7jSh4q0uk9gAgAE6UOaAABuQDoAAJ+oAgAFzTuWAAAkQt4AAA4r8gAEeau2ABZZkAIAAYLMAgAAWtww= Date: Tue, 31 May 2022 09:42:13 +0000 Message-ID: References: <87mtf5wk0k.fsf@oldenburg.str.redhat.com> <8735gwhz9i.fsf@oldenburg.str.redhat.com> <878rqnf8nd.fsf@oldenburg.str.redhat.com> <20220531074930.sjzjdnkayy2ln2wa@google.com> In-Reply-To: <20220531074930.sjzjdnkayy2ln2wa@google.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 908952c5-e0fb-43e0-574a-08da42e9df8c x-ms-traffictypediagnostic: AM8PR08MB5859:EE_|DBAEUR03FT004:EE_|DB7PR08MB3147:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PlCU0dwzUdbtYvHSIVSAnciWZHT7GDBCszbhNbLYFqgGHfotofQOeHXoxixu5PhpWD5T30QJJ6JsloOBr7H2WcGf7EO2ARp60L7Pgzsg25ZnhiHliczS5le/TiuZwVAfv49b2JY2xphMESsBKeAzh1X381t1z/tkZvKBF3r6WuMMvJNVarVaAPbmeOg4v9ETC2aFotdxFmGLoNUWnLbMdSDirpfJQZHSNp1xM8VSSI9tdC3QKFKeIVOWbWx0I4dUzUcHI02F2DswlY/Da5tidMCm8WQb8htOdT2/Q4em8GG2mADNvaH/ijvVJ5nzPxmfAMq5WY9tTq3s5X/90W6+YGK2EGuS+61C44ddJ/HQbtogIaKg5JRLk+5amk9Ru7c0vmSzhlBQ+SjGS/gLJwB7rH7/tjjJeOyuHE54pKvQrKcDhKJyphHhZOmCj/ILAW8Cx6ekrL/Omrn+hXYME6i5EhQT+NtkRucG9jKRKQF/XcgRI0ucxXDX0PgLDyzU30bbynqaQqiMjvZNgQ7OdCoQOTkegEVLAEzQbkzvzKm3fSJPlG/gNbJIm43SoGqcQUi+NjqbIhVp8vPPQZIDd1oh96d6R10qW3G5sEiG10csmO5W+7ICrf92wtvSYDvEAte5y+xoP81YRqJ5cd/Vsfp8ureJHcv2nUqvpCUkGRHUy/8hQfnb7RrvxPYzb87yiX8DFkGLzE8CwgAXiDQMHTqF2Nw1kHdZpxjlRNWMicMtdVyXo9i27KDkfBB8DSDgLe28KNyk6l2qJ/xRD+qRjBZUnfh9uwqmqVCy8BgZgwI+3fw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0801MB1879.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(38100700002)(66946007)(8936002)(54906003)(66446008)(76116006)(4326008)(110136005)(7696005)(66476007)(64756008)(8676002)(6506007)(91956017)(122000001)(26005)(66556008)(38070700005)(2906002)(33656002)(71200400001)(4744005)(186003)(5660300002)(966005)(52536014)(86362001)(55016003)(83380400001)(498600001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5859 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0f155907-c0ee-4ae3-c7c9-08da42e9d778 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JS8D1QHO/7T3p4/FDme/zyIQ7qDus1f7tVXn6vEjGLzYKhenMFZ2rNSlR4VY/BAQn0AAHONaPEzEa8ugmJbvQri34yakSb6t/gjN+IU3FDTXJc5jrIFNJ1Fl0U19mOJ/C6BepMWjeaT0tEISLxZ12/LzqNIzNSrqSAukJfmVU56C9C+SawAXIpXEtzzX7GmlCQVF5LHxVCqEIF9Iv8yfbxocCNhjezyBK0suAkf7jdkzZoh0kOZv+B0RLYPfmXQm2SHU6JjDzWL4N5BAgNPnOpnXI932gkViXLAJSq0DSkELQF4RFR0pEPh+qYE9jjayLyOrEIYyh6yxDMQy2EDMvvNJWvD2bfC9LM4ctzOVm42rvmgibOHvvzoKc8IhAHfDLU/riOZL7imgprLkgmGDGJLmfJ6Vqohsi5fAX//ODQP9/SJeMUHiogQLbROaLk4imjnGmgl6zsiywU8N9wNEROMaq5e83u0rVQWOq12Hf2e0CCP9KXx03RAf2rxLjBhzhvXmlfM80BA8wec8SvsS8XwYfMevLUDPRtOACBpDHuWfhXHY317iIeOFGgrJk8JWDFTvHf17aSTPlXW/GhGUvdhjZeV7jqQ6vFdLwr1Z3QLjIVe1uA0ZruqkXioXYuEqa8n1zIjQKeMw2YQw0XwrSex4pyl8933Yg3iX9qPmLwkKByfi9iXyvtkeXQSqWd2yoC5HIXPdYInmI8CkoMocl3QrYVt6+UtcOOQ6sEWJDNzqTVZ4cPV8czIzIdnsVw+KDhVb22FjBcDroHPQUmQvQA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(508600001)(336012)(40460700003)(36860700001)(47076005)(966005)(2906002)(55016003)(82310400005)(4744005)(83380400001)(70586007)(186003)(86362001)(4326008)(5660300002)(33656002)(70206006)(110136005)(8936002)(316002)(54906003)(8676002)(52536014)(6506007)(81166007)(9686003)(356005)(26005)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 09:42:27.1676 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 908952c5-e0fb-43e0-574a-08da42e9df8c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3147 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 09:42:33 -0000 Hi Fangrui,=0A= =0A= >>Should -fno-semantic-interposition imply -fvisibility=3Dprotected=0A= >>-mno-direct-extern-access?=0A= >=0A= > Unfortunately, no.=A0 -fvisibility=3Dprotected imposes stricter requireme= nt=0A= > than -fno-semantic-interposition.=A0 See=0A= > https://maskray.me/blog/2021-01-09-copy-relocations-canonical-plt-entries= -and-protected#protected-function-symbols-and-canonical-plt-entries=0A= >=0A= >=A0=A0 __attribute__((visibility("protected"))) void *foo() {=0A= >=A0=A0=A0=A0 return (void *)foo;=0A= >=A0 }=0A= >=0A= > GNU ld does not support this on several architectures, including the comm= on x86-32/x86-64/aarch64.=0A= =0A= So you're saying this should only give an error if the executable takes the= address of foo=0A= without a GOT indirection? In principle compilers could use a GOT indirecti= on when taking=0A= the address of function symbols to make this work (either in the executable= or for protected=0A= function symbols in shared objects).=0A= =0A= Note in the executable case, the linker can relax the GOT relocations so it= would have almost=0A= zero overhead.=0A= =0A= Wilco=