From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23475 invoked by alias); 16 Mar 2018 18:06:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 23465 invoked by uid 89); 16 Mar 2018 18:06:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com From: Wilco Dijkstra To: Florian Weimer , "libc-alpha@sourceware.org" CC: nd Subject: Re: [PATCH] Use correct includes in benchtests Date: Fri, 16 Mar 2018 18:06:00 -0000 Message-ID: References: , In-Reply-To: x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0801MB1254;7:FqqJzqnFEjg56vwQm1v2pGh5Cma/ucuYT1M1rMZHaFRs/v1FmWepl05DA4Q+0I5BQd1V9EGWW+Sn8JjnT0fVL27oCBe1GWu0Pr0KM/5E54TUvQnnOKHC3TIGJYpUqjwZMHdpq1oAvMt83mM5HqeiNCUWKtTdXV0eXXwmlspJWzNexkB/syWTWL24zEsaceZFFcA9nACxBmH4w5qb0gbKhs66S3/Jt1sEvE8KtzRiLKmOpe+6BeEJNKsg6xspWzeP x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 27dd0fc8-5f6c-4854-5a3c-08d58b68aff1 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020);SRVR:DB6PR0801MB1254; x-ms-traffictypediagnostic: DB6PR0801MB1254: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501281)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:DB6PR0801MB1254;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1254; x-forefront-prvs: 0613912E23 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(39380400002)(346002)(39860400002)(376002)(396003)(199004)(189003)(97736004)(6436002)(316002)(6246003)(5250100002)(6116002)(105586002)(3846002)(2501003)(55016002)(86362001)(6506007)(68736007)(229853002)(102836004)(2950100002)(99286004)(2900100001)(53936002)(110136005)(76176011)(7696005)(9686003)(4326008)(5660300001)(2906002)(478600001)(72206003)(106356001)(3660700001)(8936002)(26005)(33656002)(74316002)(14454004)(7736002)(305945005)(3280700002)(81156014)(66066001)(25786009)(81166006)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1254;H:DB6PR0801MB2053.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: q+SmJL0murKb/z1rtuGuSKh22LgcAKhXMHH714ALTWWCRkfwgDO6aJMOKVCR7hwORUprtN9iRjJpyDkiVyFRZdW6YlCv2Sf5RfAoLEF1itV7bFZnvCbN6BZyq9dgCKz8qhO1+ZdnVxMVMlA1RPUsBScq5A7RDDaGL6DpNvarP5lxDi5qX97SJjcr9HYk0h5oHtL/WsbhGWMSv9Y4U1gc6BpfEo/MwQZZLaBoy64dRpvppoM4dsmuIXcxRNizV8egCwNt8e3gc/9OGDQJdf8n5/dMbKaKre/W1Ij2OgI4IfUSak51hYOpdtTeXCsVvM9OgxiXfJs4uz2jEQxMFU6MaQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27dd0fc8-5f6c-4854-5a3c-08d58b68aff1 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2018 18:06:48.6701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1254 X-SW-Source: 2018-03/txt/msg00411.txt.bz2 Florian Weimer wrote: > I think this broken --enable-static-pie builds for some reason: > > In file included from bench-timing-type.c:19:0: > bench-timing.h:19:0: error: "attribute_hidden" redefined [-Werror] > =A0 #define attribute_hidden > In file included from :0:0: > ./../include/libc-symbols.h:361:0: note: this is the location of the=20 > previous definition >=A0 # define attribute_hidden __attribute__ ((visibility ("hidden"))) > > Any suggestions how to fix this?=A0 Just stick an #undef attribute_hidden= =20 > in front of it? Hmm that looks like a preincluded file, which is done just before we define _ISOMAC... So I wonder whether it would be better to fix Makeconfig to pre-includes after the CPPFLAGS rather than in the middle of it? CPPFLAGS =3D $(config-extra-cppflags) $(CPPUNDEFS) $(CPPFLAGS-config) \ $($(subdir)-CPPFLAGS) \ $(+includes) $(defines) $(module-cppflags) \ -include $(..)include/libc-symbols.h $(sysdep-CPPFLAGS) \ $(CPPFLAGS-$(suffix $@)) \ $(foreach lib,$(libof-$(basename $(@F))) \ $(libof-$(