From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)
Date: Wed, 14 Mar 2018 17:34:00 -0000 [thread overview]
Message-ID: <DB6PR0801MB20536B0302E1784A22F921EB83D10@DB6PR0801MB2053.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1803141643210.26962@digraph.polyomino.org.uk>
Joseph Myers wrote:
> If the benchmarks are compiled without _ISOMAC being defined, that's the
> bug that should be fixed. Changing them to use math/math.h is definitely
> wrong.
Unfortunately it's not possible to define _ISOMAC since many tests actually require
internal headers, for example the string benchmarks often need inhibit_loop_to_libcall
which is defined only if _ISOMAC is not defined.
Defining _ISOMAC just for the math tests seems to work though, that looks like a
reasonable workaround for now.
Wilco
next prev parent reply other threads:[~2018-03-14 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 18:27 Wilco Dijkstra
2018-03-13 22:46 ` Joseph Myers
2018-03-14 14:47 ` Wilco Dijkstra
2018-03-14 16:50 ` Joseph Myers
2018-03-14 17:34 ` Wilco Dijkstra [this message]
2018-03-14 17:44 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0801MB20536B0302E1784A22F921EB83D10@DB6PR0801MB2053.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).