From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113600 invoked by alias); 14 Mar 2018 14:47:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 113589 invoked by uid 89); 14 Mar 2018 14:47:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=ridiculous X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com From: Wilco Dijkstra To: Joseph Myers CC: "libc-alpha@sourceware.org" , nd Subject: Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l) Date: Wed, 14 Mar 2018 14:47:00 -0000 Message-ID: References: , In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0801MB2037;7:6Oi1rCDCaD2NDSLKp8DHilMSrv4We0WP3XqUz1Ce6mdXz4g51tnGE6MZcnbzH0ml9G6tycjUdK/xHsQy5OLBqs0a3nn59en4YvoKhuVhOU+9bOvkB+Ju177pdReAZlQZILyVS/7fryU9lx2bEfiJLk7m6tPPxEwhz7QL68nncTJQ0qFSvEbZLIl0armDL0svGxQ/IXgTdqMnem9VeVG28Y5b8NMDJa+MmmmItsQzT7MogBAg6EnatH9oHVZGNyk+ x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d371ab8d-03e5-4a1f-241f-08d589ba88c2 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DB6PR0801MB2037; x-ms-traffictypediagnostic: DB6PR0801MB2037: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501244)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011);SRVR:DB6PR0801MB2037;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB2037; x-forefront-prvs: 0611A21987 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(366004)(39380400002)(346002)(39860400002)(396003)(189003)(199004)(54534003)(2950100002)(86362001)(26005)(106356001)(105586002)(6246003)(5660300001)(6506007)(6436002)(68736007)(3846002)(229853002)(478600001)(6116002)(66066001)(305945005)(25786009)(7696005)(54906003)(97736004)(3660700001)(76176011)(7736002)(6916009)(2900100001)(186003)(102836004)(3280700002)(316002)(74316002)(8676002)(72206003)(81166006)(14454004)(4326008)(33656002)(8936002)(99286004)(53936002)(9686003)(5250100002)(81156014)(2906002)(55016002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB2037;H:DB6PR0801MB2053.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tXpaklbfg83odfrKoMqZj3bts5sM0R3Fo2kwDqwL5fuFL+MbA2ZC3JGll2kgC0Jcg7zjOATT+TX7uDTxfaC1viWcYJ7YsBh745nWsXHegKCFWUE3um4wMCbdTElhB4pGq0MpWQMl5vHYF2JRMWxngTKlrxbw/n8lCDi0+piGi/XbA/XFkNtec2QgpJbPLUabysXyy6U5YJlhGAc8qNbcJacxeYrMruyOHkf3SGFOQRML8Dnt0LVp2Uvto90mel/6lfocBzEcw+t6a8F6Ugo9H0TpFDDleGbUds5xm8cdOvKln2qQVvVON7Vv7vBXLuGS2d0fWOIuASADWW8NzuqC+Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d371ab8d-03e5-4a1f-241f-08d589ba88c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2018 14:47:39.3046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2037 X-SW-Source: 2018-03/txt/msg00341.txt.bz2 Joseph Myers wrote: > What variants exactly? powerpc-linux-gnu-soft powerpc-linux-gnu powerpc64-linux-gnu x86_64-linux-gnu arm-linux-gnueabihf aarch64-linux-gnu sparc64-linux-gnu sparcv9-linux-gnu 390-linux-gnu m68k-linux-gnu i486-linux-gnu i586-linux-gnu mips64-linux-gnu-n64 Maybe we can agree on a useful subset in the script - the number of variant= s for some ISAs is ridiculous, do we really need 24 variants for MIPS? I suppose = we can also remove tile and a few others like sh given the recent discussions = of obsoleting those ports? > What execution testing have you done?=A0 It would be a good idea for that= to=20 > include at least one configuration where sqrt is not inlined by the=20 > compiler, and also to include 32-bit x86 to make sure the special-case=20 > wrappers there (to avoid double rounding) continue to work as expected. I run on AArch64 and x64 when it is relevant. Finding a config that doesn't= inline sqrt may be difficult, since pretty much all ISAs have a sqrt instruction. > Why is the benchtests/sqrt-inputs change needed?=A0 I think it's correct = for=20 > benchmark inputs to refer to the include name as in user code, not to the= =20 > path within the glibc source tree, and certainly this test should not be= =20 > doing things differently from all the others. We build the testsuite explicitly with -fmath-errno so there will be calls = to sqrt. Given the include path is incorrect when running the testsuite (it uses int= ernal paths rather than external ones), we get redirection to __ieee754_sqrt whic= h is not exported outside of GLIBC. Since the include path issue is a separate b= ug I just ensure the sqrt benchmark gets the right include - when it is fixed = we can easily change it back. Btw we'll also need to create some real inputs and decide what we want to t= est: the inlined sqrt instruction or the sqrt call in GLIBC (which will usually = be the sqrt instruction), or the sqrt emulation... I'll fix the ChangeLogs shortly. Wilco =20=20=20=20