From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80044.outbound.protection.outlook.com [40.107.8.44]) by sourceware.org (Postfix) with ESMTPS id D5017385DC14 for ; Wed, 15 Apr 2020 11:59:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5017385DC14 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Wilco.Dijkstra@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duk7Smj0+hJBmh25H1VZbLIAUVrdNVwbENloZMrBqzI=; b=nCb65c+q8Pf9t1ow3XHV1R9TAvjEPyeCmM/h23NAFvfUwTjkwTNQgXW3Rt+iGUmcJTlhu2bQz6vssFh5mV3DeN98AJO+kVQIRy1pt1DQAwOfmIERh9nbmPtBYKznDuqfJibK8ltvtCwVVVdGrVuuLeU5WqaRJulGrxZo+gN9/FU= Received: from DB6PR0501CA0022.eurprd05.prod.outlook.com (2603:10a6:4:8f::32) by DB7PR08MB3340.eurprd08.prod.outlook.com (2603:10a6:5:20::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.20; Wed, 15 Apr 2020 11:59:51 +0000 Received: from DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::8a) by DB6PR0501CA0022.outlook.office365.com (2603:10a6:4:8f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 11:59:51 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT008.mail.protection.outlook.com (10.152.20.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.18 via Frontend Transport; Wed, 15 Apr 2020 11:59:51 +0000 Received: ("Tessian outbound 9bb9f2b1d83f:v50"); Wed, 15 Apr 2020 11:59:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d31feb6e7c8a3ce0 X-CR-MTA-TID: 64aa7808 Received: from af96f3bb943d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 95B6BD43-36C0-4357-800E-03D6C8A8509F.1; Wed, 15 Apr 2020 11:59:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id af96f3bb943d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 15 Apr 2020 11:59:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j7x31Zln0s86bYyPfKxTHiwqbiZfvAAmaGnGKC+zCvONoQQT+4AMDkOFLK/rIhr6xZd3JY6SYFdtJRCYCMXdIQNKF/PytDntx3Tzw/9Tjugr/8bEalFOHK07niVZEFhlD2IUb2wxLUrCWyHTEhkc/wjglpq7Nt0Nu5458JaTJ49td7kOPXPRb2iIr1mfACX9OKV9RY+0mdIZmIc3Y2GD1UrboQZzIGtmRbpwH+PGzEZByvXEjA89EdIl7rkRqY+q7GyPfXZtyApl2I4OOZNjfmzysc8V9WAPixzcr7Ixv/5jCmTCL3IOgAuuwjUZTQwIptTgaiEKMDJbZo2XpmnmBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duk7Smj0+hJBmh25H1VZbLIAUVrdNVwbENloZMrBqzI=; b=fkTtJHW5EWgE1rgXx6LR3AO5BcmwLZdbULnL71cHraog7s7D2ZhLbgy9QKPN2RdPEt4Mc4D0st44BTfrN9l0qnO5EkqaXhgr/o2rqiNx+ZW8a+kVo1DbRY2l4ZHnzlvZgvbhwRv8qFmqAbAOFY0rQUd85xyWjsiqRb8sBu8m0Jw7bhAu8cfD+fFcbUb8i58Oz+JEbe+qu6h+w7VMItcQsLqZidyvNErLCCorPs2lbT6rS1jmiTFQsvHmiE3sCe8crun4CrXCqAEN86J/XcR+iILg6A3vHAqqhcfvvrYgaIMydRC5hu/fJsCRmGPPqXP5KIMoJMR5BqXJQFwNtBf4lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duk7Smj0+hJBmh25H1VZbLIAUVrdNVwbENloZMrBqzI=; b=nCb65c+q8Pf9t1ow3XHV1R9TAvjEPyeCmM/h23NAFvfUwTjkwTNQgXW3Rt+iGUmcJTlhu2bQz6vssFh5mV3DeN98AJO+kVQIRy1pt1DQAwOfmIERh9nbmPtBYKznDuqfJibK8ltvtCwVVVdGrVuuLeU5WqaRJulGrxZo+gN9/FU= Received: from DB8PR08MB5036.eurprd08.prod.outlook.com (2603:10a6:10:ed::20) by DB8PR08MB5260.eurprd08.prod.outlook.com (2603:10a6:10:e6::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.23; Wed, 15 Apr 2020 11:59:45 +0000 Received: from DB8PR08MB5036.eurprd08.prod.outlook.com ([fe80::8dce:6db4:5358:200e]) by DB8PR08MB5036.eurprd08.prod.outlook.com ([fe80::8dce:6db4:5358:200e%3]) with mapi id 15.20.2900.028; Wed, 15 Apr 2020 11:59:45 +0000 From: Wilco Dijkstra To: "libc-alpha@sourceware.org" , "zhuyan34@huawei.com" Subject: Re: [PATCH v2] memcpy: use bhs/bls instead of bge/blt [BZ #25620] Thread-Topic: [PATCH v2] memcpy: use bhs/bls instead of bge/blt [BZ #25620] Thread-Index: AQHWExpF9kpK49vRl0yawbyn/ew2Dw== Date: Wed, 15 Apr 2020 11:59:44 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-originating-ip: [82.24.199.97] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6f7de9d8-d52d-460b-ea3b-08d7e13480f6 x-ms-traffictypediagnostic: DB8PR08MB5260:|DB7PR08MB3340: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; x-forefront-prvs: 0374433C81 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR08MB5036.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(186003)(76116006)(55016002)(9686003)(478600001)(33656002)(316002)(110136005)(71200400001)(66476007)(66446008)(2906002)(64756008)(66946007)(5660300002)(8676002)(8936002)(66556008)(81156014)(7696005)(52536014)(6506007)(86362001)(26005)(4744005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tK2OaZYABswlFBYVkZHlaxwNYaCbB2jpTkWWRNEJhqGHl65fqS5xFHDSAp1Dj6NHTEwsEXwxDcpArzR9VslY6RDiRB2zFAlsr2bYCrDX0M2rjgY8EOPmbDV3ncE/FO3HAI2VxQaCM7ZUZAif7gv2s/BMkuE8MgyKTurKf4QQI2MFuWQ7pC2Z0RXjMywyqk/DtBie53NmF0xUO5KLhz/5TFMuSBYWhDhbx3HyT4w+zWJ58pX8Pd1am0393ZZuyu/2VIEpaMkb2pK7pER1cNtksZfZP3VQldsdONq9Tf4cAOMev1XkXl3t6y9IorwkY9fQrGMYHZntmM1nnpZJDmomRhflKq3LV7s8mxIKTcqPtkK05hsBGwDOFfwZff77c9D8tzB1klcX6g3VgnWqyAjIWfVNY72ShOggiJthlDEIebBpd0mMJ5hTN+TnCJQGn49M x-ms-exchange-antispam-messagedata: AQp3Lqobxj97acc2zTIkrOhQTHhD1O6gK7i/psxESZ8+iUedYNsV2vnb/N+k4cXS0GgRr6whEsuCPMy+cgYVtRMYe/GbhNutVXjJ/WQ7qifg+3aaLx7o0loBzJ8gpZBemCzIXkMWn8ca6sRtf95yJg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5260 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(39860400002)(346002)(136003)(396003)(376002)(46966005)(81166007)(9686003)(4744005)(86362001)(26826003)(52536014)(82740400003)(47076004)(2906002)(356005)(55016002)(478600001)(26005)(81156014)(336012)(186003)(70206006)(70586007)(316002)(5660300002)(110136005)(7696005)(8676002)(33656002)(6506007)(8936002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 5eeeb86d-568a-4a50-e376-08d7e1347d20 X-Forefront-PRVS: 0374433C81 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6DwGdZMBnldWaFxcaQ2+9Tisl0e7OAkZi1h0awjJ2DLRriE3f78c3YF1yQkUDIAOYV1RsMYi9mzO91YRQBJ/PgbrEfgHkbdWPjqtdSP4TuAtu/hVYRjAsdxrHw7qc4PNuRv7jsiOmwO+0OUdyt4VsMhsSIFaOqwbvxjc9l8l1yZVOW4GmLKlZF2S3NkxA2AW9hQk3EhHjuNeURBw6m7zYHPJFotQo+dgjV8BZH7hQ8pTDx6KB+UM02bsNFykjoONMUT3rDWvilcBJnHHusyxBJFbdcjwYcKAnDN+H8L76am/3i1iYvMOnyqBuywVqy05iXeYCi9sp4kRmJyv+byGb+DIrJZNkjou0IM5dga+q3I4ck3LfjIXSZ3s1a77wvsFYBZZndonKm0VzlTVBh99qf2xwPldemrjLCosT6rpEhoEUHyqB7HPz1XztjNvP6fAsOknlPaNREnCN8TdxcjWM0ke4hbDvEcDGvj6fBjLYOB4J65LMbFiz7bEYepaqDuiCRTYuYR8gr3H3MqndYcYkA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 11:59:51.4368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7de9d8-d52d-460b-ea3b-08d7e13480f6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3340 X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2020 11:59:56 -0000 Hi Zhuyan,=0A= =0A= As Joseph mentioned the test should not be target specific. If you're think= ing of=0A= just adding a test for memcpy for now, then adding it to string/test-memcpy= .c would=0A= be fine given it should be part of the basic tests. Existing tests like tes= t-memchr.c already=0A= have special checks for huge inputs. Once we have a working implementation,= it would=0A= be easy to copy it to test-memmove.c, test-memset.c etc.=0A= =0A= In particular do_test1 shows how to do a mmap with an inaccessible page to = avoid=0A= corrupting any memory which could cause the test to pass or fail incorrectl= y.=0A= The test should run all ifuncs as well, not just one.=0A= =0A= Cheers,=0A= Wilco=