From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2079.outbound.protection.outlook.com [40.107.21.79]) by sourceware.org (Postfix) with ESMTPS id 36F2C3938C11 for ; Fri, 1 May 2020 12:58:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 36F2C3938C11 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Wilco.Dijkstra@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=238OFXl8ajEpUZwM32ypLDARITnfgW2c6X45rBTWh6s=; b=nvFXcbovFI55gUMxG5rJrg7G1Y2mZo2qT9TqGAet9px4CkOcCUvq7Zkph1DHT9zCyYQffnNg7V4VkeEPFUzEeUhT4eh6qiFxfG90Ng1t0fFZ/U/itaR8diN7NZ7wTL47xzSSiOAguRSYCcJ0Guaw1DE/S8phzmqxfxul3+SQAfo= Received: from AM6P194CA0069.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::46) by AM6PR08MB3206.eurprd08.prod.outlook.com (2603:10a6:209:46::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Fri, 1 May 2020 12:58:21 +0000 Received: from AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:84:cafe::2b) by AM6P194CA0069.outlook.office365.com (2603:10a6:209:84::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Fri, 1 May 2020 12:58:21 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT045.mail.protection.outlook.com (10.152.17.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20 via Frontend Transport; Fri, 1 May 2020 12:58:20 +0000 Received: ("Tessian outbound 11763d234d54:v54"); Fri, 01 May 2020 12:58:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c055b7523b84a6e0 X-CR-MTA-TID: 64aa7808 Received: from 8d930bac25bc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 261941A3-220C-449A-B060-B8FFDEBF996E.1; Fri, 01 May 2020 12:58:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8d930bac25bc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 May 2020 12:58:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oZ0e0INBHcYNKgfoESIUMpTkkAfkjAZOY8s7ChRwhrG2/UP0sgbMJUvkF4CdW3Bj5G+BpzuTBRpz0c+bVnpYDOUNIuuYKccwIRGhmUyO+f0XNvE+s/lsq8drDHSZzPG8L4AOW+TSu4CwiJnM+s0NjGbeGWpV5eVd74Z6HmhvU0XZLvJTaeQN8TxbMzDemvujnnN4lMflS+HPvcRA6GdVv97R+gfkvFPt9QwRVI8i9TS+/PjMG/r9UdTdVkdwpmpp+nqJyv3BJEwUq9xvXjYLG8TmGpK7r2A/YIATHb+5KTJt9JMktddO9rGQTT9WgTbx37/y6H/3UhBSISbgO8x6nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=238OFXl8ajEpUZwM32ypLDARITnfgW2c6X45rBTWh6s=; b=KMwJBZAAkCfINgZihAvEDsdAdwsDs3oSenl6gk8+5AvPo9EkHgQkEwVexA0NVbp968kF2en668sfQx/H/Ac3vScpp3jhfmyKVphlvaKia10dmYL8f5t1r0R7G7gSzz2C0+lVmLtDWY6B5EOFSCdmFJgIi+qHR1Y+jyl3B+gGqG3ZnAGs5fRdCEO68Obu2NQcD9IqsbT0CzYT8BaA4Xw+Xs6TciRIzASFKkoQcWWbC0troSgI13Gf/AHGtC+a2fs3egn538/mKG1NU7Iy+CXadEajU4Z0ZZ1+mWTxODW+WSuU9I5rBcxS9zrmiTi+bgaE+H9Q4stofrlwhM2m/zU6fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=238OFXl8ajEpUZwM32ypLDARITnfgW2c6X45rBTWh6s=; b=nvFXcbovFI55gUMxG5rJrg7G1Y2mZo2qT9TqGAet9px4CkOcCUvq7Zkph1DHT9zCyYQffnNg7V4VkeEPFUzEeUhT4eh6qiFxfG90Ng1t0fFZ/U/itaR8diN7NZ7wTL47xzSSiOAguRSYCcJ0Guaw1DE/S8phzmqxfxul3+SQAfo= Received: from DB8PR08MB5036.eurprd08.prod.outlook.com (2603:10a6:10:ed::20) by DB8PR08MB5451.eurprd08.prod.outlook.com (2603:10a6:10:113::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Fri, 1 May 2020 12:58:13 +0000 Received: from DB8PR08MB5036.eurprd08.prod.outlook.com ([fe80::8dce:6db4:5358:200e]) by DB8PR08MB5036.eurprd08.prod.outlook.com ([fe80::8dce:6db4:5358:200e%3]) with mapi id 15.20.2958.027; Fri, 1 May 2020 12:58:13 +0000 From: Wilco Dijkstra To: Florian Weimer , "zhuyan34@huawei.com" CC: 'GNU C Library' Subject: Re: [PATCH v2] memcpy: use bhs/bls instead of bge/blt [BZ #25620] Thread-Topic: [PATCH v2] memcpy: use bhs/bls instead of bge/blt [BZ #25620] Thread-Index: AQHWH7aOdGEg+ZYQFUu1d5RnhuFeow== Date: Fri, 1 May 2020 12:58:12 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: deneb.enyo.de; dkim=none (message not signed) header.d=none; deneb.enyo.de; dmarc=none action=none header.from=arm.com; x-originating-ip: [82.24.199.97] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2eb188fc-2b38-4222-9c94-08d7edcf5361 x-ms-traffictypediagnostic: DB8PR08MB5451:|AM6PR08MB3206: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; x-forefront-prvs: 0390DB4BDA X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ltYXrbCau3DVv0RkD8l9pHPtwZ3K+70f2GEahBy+L+4jw+YPxS3DTkUEXcv0LwnKlVoBIwweG9z/MY36XjsrMyAFVnyrNBQ0enxuX2Bhh+FHaOYIDdmvVZNxboKcYd0Hlcclf5kx+N0s9NgWuWH1Fl2PQB6Px/nc7wVBTP4K9rW3RKYpuyxpLpraYcN9hOuidoMjSKUuvzc1s/Sb65rFJ7G9Cr5Eu4hE8Zp6GQab4r2MIfoPaCQD5C0npXUkpW8F7mdgLFD9Gdz6OEA01NLLiK3VcuPAmzzaS+vF/C9oJYMZu63uL+x4t97BYAoPfszrkaagDGmjdaV1BgAjxyYcC+4xNCrayjGKnE6JLnNM2BagSS5my/FRWMAtrfcp0d3OIzSs6mOqrk8s3NqzjA2fogBoCzR5qQ8tzohM3I36cOQqqAxLGer2gz0WixffNGH/Tvm/WG9z1iTRgPD/z5aS9n6mqC5hpt5Y9UnVHI5jQnm1a/w7hO1lmRaU3/EtCuuv X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR08MB5036.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(346002)(366004)(396003)(136003)(76116006)(2906002)(6506007)(66446008)(110136005)(86362001)(316002)(71200400001)(66556008)(33656002)(64756008)(66476007)(4326008)(478600001)(8936002)(5660300002)(8676002)(66946007)(186003)(52536014)(26005)(4744005)(9686003)(55016002)(7696005)(357404004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: NszFlefKvCTyvCY48YcIDb/8tJ77wAhCYJE/FsWoHcWvfJ5A9gk02Kn6bbzn+3C7ua6sJifFH35ci1nTgQla8pKlVSZ7UlQdgShW+y6IArGiXgLZ/i8EUplinuh+SzwNwMXAhmrCthD2cnGDzsbm0BuYQIAPWu6oWYc3KFPev7Jd/jg/1P3Tb7qBPxIz54rb6h46Gl0kPFAYl7hcBOX+AK5z23uozJyOYkH5bb3KYbZUNaTrMyp5kpcmyZ1vejLhv5tplMrHO5XwkslyPWU0WkX827IhUqChTlR/wFhBl4ysOpGDcAvBZwQA/YyeuPVw/G6gUTncWzrj6IcYfBp63wLWkqlsG/aiG7wp10gvoAHnsbtHJFs8G2mgfKAguJNqaGG/AMon8u/r17G15dp0052oLRvmpzidkArD9Sz5S2nziLGd7231eJX4BG7sQcrwTyA5/DVXyaCxcWZIlnAGxavqMShFMUigDPgwHo9DTvXvhDMYIOIg7tXT0aMj0/fD2x1IVvWE8KVu5kqhhCphtbpFELZGWKmmLfDA7FwaSd1xaaS9akNgqYSsBdlAm9WJ5EyTakS8NVflMhguxr0nAU9uamxmswx9rX8pZrbKNkXKqQjkCQdVDVOf0kiaJfSzBEshTMa/D5ZJAZ+5kAY+X1lBJW/wDf/UKz/Lk+DUdSUXCpnDGF7dhNP39OPQFSmkxELGCd1xGRJPm2KcHvygkHm4R4b9HFIJwLdL+WgzKNvMHgC9Dk4Yk8zcWzL43YuZY9gpe7QeuykOQ5lRQeqOU6RirfIP1yWgZOQwoQesLE0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5451 Original-Authentication-Results: deneb.enyo.de; dkim=none (message not signed) header.d=none; deneb.enyo.de; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(39860400002)(376002)(396003)(46966005)(81166007)(82310400002)(55016002)(8676002)(36906005)(8936002)(186003)(336012)(9686003)(86362001)(478600001)(4326008)(5660300002)(26005)(6506007)(52536014)(316002)(4744005)(70206006)(70586007)(2906002)(110136005)(47076004)(7696005)(356005)(82740400003)(33656002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 14f4c4e9-d814-4055-085b-08d7edcf4eb9 X-Forefront-PRVS: 0390DB4BDA X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S+I+iIXreJYwec0n4eEhGuGqGU9A4HaqF3GYGQPA8UoTPHd2y+LTgVhurYxXXCyPFgwh44EjmEqOxJn0Wkw7Cai5PXrIexJDU36+dnBXECd+MYlmZBj3BNff8CP5pF3RpEFzr7SQ3+bf4XJxeWunN50ciPurne5ge94N31/THWMof93uhU3FrMXXS2wYxee/39wvD46kBIm1BHWwy++MOfHn+YjM3kIB2JuUD8fYv98phXKCvlMDVJZeZf7RR5bUMM97R/W0AR47eWf5MC2MT3/sOjufKl5nLqsO4WiOFJJp9XARTe7HjiP5jIKI9TBgMfJxEDv5LxNC1lBtvlkiMDuB7P/o+qqDADx8qaTD88JQT2rQeb1FL/zpok4NHCgdeMsVw8xbXJneP4ze7hYurmmx2v03re/LPPtgIgAS72ydq7H52wv2SO/RqSMeu5cN0H1MdOlZpSHdAN4nGHEM1iZXTnLVvXkeR3lSpKNZ6HI2yo5LavruKZaaEoCt/bumXRZoKGBQMHzspSKhhkRybA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2020 12:58:20.8384 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb188fc-2b38-4222-9c94-08d7edcf5361 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3206 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2020 12:58:25 -0000 Hi Florian,=0A= =0A= >> - blt .Ltail63aligned=0A= >> + bls .Ltail63aligned=0A= >=0A= > Is bls really the unsigned variant of blt? Why not blo?=0A= =0A= Well spotted! Indeed bls is incorrect here since the tail code cannot handl= e 64 bytes.=0A= =0A= Note there are several uses of PL/MI that need to be changed too:=0A= =0A= subs count, count, #64=0A= ldrmi tmp2, [sp], #FRAME_SIZE=0A= bmi .Ltail63unaligned=0A= =0A= subs count, count, #64=0A= bpl 1b=0A= =0A= Basically the initial test protects all the others, but when that one is ch= anged to=0A= unsigned, all the other signed checks fail, and we're basically left with t= he exact=0A= same problem. Hence the need to change all signed condition codes and add= =0A= tests that catch all possible cases.=0A= =0A= Note a very quick grep shows memcpy.S, armv7/multiarch/memcpy_impl.S,=0A= memmove.S, strlen.S and armv6t2.memchr.S using signed conditions.=0A= =0A= Cheers,=0A= Wilco=