* [PATCH] AArch64: Align ENTRY to a cacheline
@ 2020-07-14 16:17 Wilco Dijkstra
2020-07-14 20:16 ` Carlos O'Donell
0 siblings, 1 reply; 3+ messages in thread
From: Wilco Dijkstra @ 2020-07-14 16:17 UTC (permalink / raw)
To: 'GNU C Library'
Given almost all uses of ENTRY are for string/memory functions,
align ENTRY to a cacheline to simplify things.
OK for commit?
---
diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
index ae269146e3a5eafa563ec53f2d6f45bbef84d444..2d802db00834ed521ffc3d7e7016f1ee161caf7b 100644
--- a/sysdeps/aarch64/sysdep.h
+++ b/sysdeps/aarch64/sysdep.h
@@ -98,7 +98,7 @@ GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI)
#define ENTRY(name) \
.globl C_SYMBOL_NAME(name); \
.type C_SYMBOL_NAME(name),%function; \
- .align 4; \
+ .p2align 6; \
C_LABEL(name) \
cfi_startproc; \
BTI_C; \
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] AArch64: Align ENTRY to a cacheline
2020-07-14 16:17 [PATCH] AArch64: Align ENTRY to a cacheline Wilco Dijkstra
@ 2020-07-14 20:16 ` Carlos O'Donell
2020-07-15 8:15 ` Szabolcs Nagy
0 siblings, 1 reply; 3+ messages in thread
From: Carlos O'Donell @ 2020-07-14 20:16 UTC (permalink / raw)
To: Wilco Dijkstra, 'GNU C Library', Szabolcs Nagy
On 7/14/20 12:17 PM, Wilco Dijkstra wrote:
> Given almost all uses of ENTRY are for string/memory functions,
> align ENTRY to a cacheline to simplify things.
>
> OK for commit?
It's OK for 2.32 if Szabolcs says OK.
> ---
> diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
> index ae269146e3a5eafa563ec53f2d6f45bbef84d444..2d802db00834ed521ffc3d7e7016f1ee161caf7b 100644
> --- a/sysdeps/aarch64/sysdep.h
> +++ b/sysdeps/aarch64/sysdep.h
> @@ -98,7 +98,7 @@ GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI)
> #define ENTRY(name) \
> .globl C_SYMBOL_NAME(name); \
> .type C_SYMBOL_NAME(name),%function; \
> - .align 4; \
> + .p2align 6; \
> C_LABEL(name) \
> cfi_startproc; \
> BTI_C; \
>
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] AArch64: Align ENTRY to a cacheline
2020-07-14 20:16 ` Carlos O'Donell
@ 2020-07-15 8:15 ` Szabolcs Nagy
0 siblings, 0 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2020-07-15 8:15 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: Wilco Dijkstra, 'GNU C Library'
The 07/14/2020 16:16, Carlos O'Donell wrote:
> On 7/14/20 12:17 PM, Wilco Dijkstra wrote:
> > Given almost all uses of ENTRY are for string/memory functions,
> > align ENTRY to a cacheline to simplify things.
> >
> > OK for commit?
>
> It's OK for 2.32 if Szabolcs says OK.
thanks.
this is ok to commit.
>
> > ---
> > diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
> > index ae269146e3a5eafa563ec53f2d6f45bbef84d444..2d802db00834ed521ffc3d7e7016f1ee161caf7b 100644
> > --- a/sysdeps/aarch64/sysdep.h
> > +++ b/sysdeps/aarch64/sysdep.h
> > @@ -98,7 +98,7 @@ GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI)
> > #define ENTRY(name) \
> > .globl C_SYMBOL_NAME(name); \
> > .type C_SYMBOL_NAME(name),%function; \
> > - .align 4; \
> > + .p2align 6; \
> > C_LABEL(name) \
> > cfi_startproc; \
> > BTI_C; \
> >
> >
>
>
> --
> Cheers,
> Carlos.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-15 8:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 16:17 [PATCH] AArch64: Align ENTRY to a cacheline Wilco Dijkstra
2020-07-14 20:16 ` Carlos O'Donell
2020-07-15 8:15 ` Szabolcs Nagy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).