From: Pavel Kozlov <Pavel.Kozlov@synopsys.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] ARC:fpu: add extra capability check before use of sqrt and fma builtins
Date: Tue, 17 Jan 2023 12:31:32 +0000 [thread overview]
Message-ID: <DM6PR12MB31461EF7FAE0DE7A4E7C587BBCC69@DM6PR12MB3146.namprd12.prod.outlook.com> (raw)
In-Reply-To: <882721d2-adb1-1cbd-cd06-d7902dc9d2e7@linaro.org>
> This is wrong, sqrt use macro do not belong for the fma switch file.
Thank you for the review and your notice. I was inattentive when
moving changes from the branch I had. This has been fixed in
v2 of the patch [1].
I've manually checked (by objdump -d output review) that now
expected code for libm is generated in different cases (when compiler
provides support for extra instructions and sets macroses
__ARC_FPU_DP_DIV__, __ARC_FPU_SP_DIV__, __ARC_FPU_DP_FMA__,
__ARC_FPU_SP_FMA__ and when not).
[1]
http://lists.infradead.org/pipermail/linux-snps-arc/2023-January/006771.html
--
Pavel
next prev parent reply other threads:[~2023-01-17 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 16:28 Pavel.Kozlov
2023-01-16 14:18 ` Adhemerval Zanella Netto
2023-01-17 12:31 ` Pavel Kozlov [this message]
2023-01-17 12:12 ` [PATCH v2] " Pavel.Kozlov
2023-01-17 14:31 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB31461EF7FAE0DE7A4E7C587BBCC69@DM6PR12MB3146.namprd12.prod.outlook.com \
--to=pavel.kozlov@synopsys.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).