public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] getconf: Add NPROCESSORS_{CONF,ONLN} [BZ #31661]
@ 2024-05-30 14:05 Mohamed Akram
  2024-06-05 12:55 ` Arjun Shankar
  0 siblings, 1 reply; 2+ messages in thread
From: Mohamed Akram @ 2024-05-30 14:05 UTC (permalink / raw)
  To: libc-alpha; +Cc: Mohamed Akram

These are required by the upcoming POSIX standard and are available on
other platforms.

Link: https://austingroupbugs.net/view.php?id=339
Signed-off-by: Mohamed Akram <mohd.akram@outlook.com>
---
 posix/getconf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/posix/getconf.c b/posix/getconf.c
index 6a2127b3..b35d55a3 100644
--- a/posix/getconf.c
+++ b/posix/getconf.c
@@ -121,7 +121,9 @@ static const struct conf vars[] =
     { "WORD_BIT", _SC_WORD_BIT, SYSCONF },
     { "_AVPHYS_PAGES", _SC_AVPHYS_PAGES, SYSCONF },
     { "_NPROCESSORS_CONF", _SC_NPROCESSORS_CONF, SYSCONF },
+    { "NPROCESSORS_CONF", _SC_NPROCESSORS_CONF, SYSCONF },
     { "_NPROCESSORS_ONLN", _SC_NPROCESSORS_ONLN, SYSCONF },
+    { "NPROCESSORS_ONLN", _SC_NPROCESSORS_ONLN, SYSCONF },
     { "_PHYS_PAGES", _SC_PHYS_PAGES, SYSCONF },
     { "_POSIX_ARG_MAX", _SC_ARG_MAX, SYSCONF },
     { "_POSIX_ASYNCHRONOUS_IO", _SC_ASYNCHRONOUS_IO, SYSCONF },
-- 
2.45.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] getconf: Add NPROCESSORS_{CONF,ONLN} [BZ #31661]
  2024-05-30 14:05 [PATCH] getconf: Add NPROCESSORS_{CONF,ONLN} [BZ #31661] Mohamed Akram
@ 2024-06-05 12:55 ` Arjun Shankar
  0 siblings, 0 replies; 2+ messages in thread
From: Arjun Shankar @ 2024-06-05 12:55 UTC (permalink / raw)
  To: Mohamed Akram; +Cc: libc-alpha

Hi Mohamed,

Thank you for submitting this. Looks good to me.

Reviewed-by: Arjun Shankar <arjun@redhat.com>

> These are required by the upcoming POSIX standard and are available on
> other platforms.
>
> Link: https://austingroupbugs.net/view.php?id=339
> Signed-off-by: Mohamed Akram <mohd.akram@outlook.com>

OK. I double checked that the latest draft of the Open Group Std. Base
Spec. Issue 8 now includes this change.

> ---
>  posix/getconf.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/posix/getconf.c b/posix/getconf.c
> index 6a2127b3..b35d55a3 100644
> --- a/posix/getconf.c
> +++ b/posix/getconf.c
> @@ -121,7 +121,9 @@ static const struct conf vars[] =
>      { "WORD_BIT", _SC_WORD_BIT, SYSCONF },
>      { "_AVPHYS_PAGES", _SC_AVPHYS_PAGES, SYSCONF },
>      { "_NPROCESSORS_CONF", _SC_NPROCESSORS_CONF, SYSCONF },
> +    { "NPROCESSORS_CONF", _SC_NPROCESSORS_CONF, SYSCONF },
>      { "_NPROCESSORS_ONLN", _SC_NPROCESSORS_ONLN, SYSCONF },
> +    { "NPROCESSORS_ONLN", _SC_NPROCESSORS_ONLN, SYSCONF },
>      { "_PHYS_PAGES", _SC_PHYS_PAGES, SYSCONF },
>      { "_POSIX_ARG_MAX", _SC_ARG_MAX, SYSCONF },
>      { "_POSIX_ASYNCHRONOUS_IO", _SC_ASYNCHRONOUS_IO, SYSCONF },

OK. These are new, additional names for existing variables.

> --
> 2.45.1
>


-- 
Arjun Shankar
he/him/his


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-05 12:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-30 14:05 [PATCH] getconf: Add NPROCESSORS_{CONF,ONLN} [BZ #31661] Mohamed Akram
2024-06-05 12:55 ` Arjun Shankar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).