public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
To: Junxian Zhu <zhujunxian@oss.cipunited.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
	Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH v2] mips: Use builtins for ffs and ffsll
Date: Tue, 13 Feb 2024 11:45:24 +0400	[thread overview]
Message-ID: <EDA1CDD2-BC6A-423A-A454-D4EF4A3CFA8F@linaro.org> (raw)
In-Reply-To: <20240206083456.721-1-zhujunxian@oss.cipunited.com>

> On Feb 6, 2024, at 12:34, Junxian Zhu <zhujunxian@oss.cipunited.com> wrote:
> 
> From: Junxian Zhu <zhujunxian@oss.cipunited.com>
> 
> __builtin_ffs{,ll} basically on __builtin_ctz{,ll} in MIPS GCC compiler.
> The hardware ctz instructions were available after MIPS{32,64} Release1. By using builtin ctz. It can also reduce code size of ffs/ffsll.
> 
> Checked on mips o32. mips64.
> 
> Signed-off-by: Junxian Zhu <zhujunxian@oss.cipunited.com>
> ---
> sysdeps/mips/math-use-builtins-ffs.h | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 sysdeps/mips/math-use-builtins-ffs.h

Please CC reviewers of previous patch versions -- Adhemerval in this case.

LGTM.

Do you have commit access?  If not, please ask Adhemerval to merge your patch.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Reviewed-by: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>

Thanks!

> 
> diff --git a/sysdeps/mips/math-use-builtins-ffs.h b/sysdeps/mips/math-use-builtins-ffs.h
> new file mode 100644
> index 0000000000..2ab6a03a16
> --- /dev/null
> +++ b/sysdeps/mips/math-use-builtins-ffs.h
> @@ -0,0 +1,3 @@
> +#include <sysdep.h>
> +#define USE_FFS_BUILTIN (__mips_isa_rev >= 1)
> +#define USE_FFSLL_BUILTIN (__mips_isa_rev >= 1)
> -- 
> 2.43.0.windows.1

--
Maxim Kuvyrkov
https://www.linaro.org


      reply	other threads:[~2024-02-13  7:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  8:34 Junxian Zhu
2024-02-13  7:45 ` Maxim Kuvyrkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EDA1CDD2-BC6A-423A-A454-D4EF4A3CFA8F@linaro.org \
    --to=maxim.kuvyrkov@linaro.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=zhujunxian@oss.cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).