From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id AE0F33858C52 for ; Tue, 13 Feb 2024 07:45:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE0F33858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE0F33858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::236 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707810341; cv=none; b=FZPQFwfiquVykyvOjJvGruheK9Cr61gZ54an0g1vR8Yg0p+rSuUcS/w+wJr2KEYljNBvqWAYlA0Nmref4PYOFLuCiRryK6nSlnIedwODOS40OujegB/bNuzC2Di54e8ollsQ48hLCAOywMmCw/A7jyIJaeKVk1yKxp4VuE9/v9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707810341; c=relaxed/simple; bh=TRVSpWlVpARgFAsucdbp1+k4wYDlwUY8YpdwQPRFhmA=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=HA8v0XhwAbfNEhXPNfcBdbMw1m0NbWiZpGvsRUpnAUwHaCPLfz+RRNCqF2h3m7zrBgy0sBgbqTOZqVz8TF90ZrVAzONTrzqpiSBbfUH2A1kjXI/A2Mwex1+x7AhQhAyFLkikA8vUou0MZlvoXsQbtDVTSkdoxM860tP/EHEtXGE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3bc21303a35so1438533b6e.0 for ; Mon, 12 Feb 2024 23:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707810338; x=1708415138; darn=sourceware.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=reemTpUljE2hql9xjd8IpMD90PNtn/7WmrU9Ej9NrME=; b=O8QuyCsY+47ihFMPXBSYXcKkK7B4IXRd0rWcSRzSiTdPmxhA0TiX/G5mtAdjZqvWSe mJO9F3y0t+pMgFwrzaDoqJX9l9k4xcgp0IxmWLyqnnE67Sa8fNh19Bifvga7zEnaJh04 ZnXm2AVwRVI7c5Kpal1XZrnTzUb/9dZMLS1sQVa9L6kSccmNsi0NiLVDw3eQd32WX78r 4frG7oZbcra2OBgWwwVD2wW+7xfAgXCje9yWFHBh1kSg2jrmXQz9BbdwZEgFqCWpSbc4 tV7o3X9IxGD+8Bf6QM3sBBIV+5A0QIKb+0ipp0PifuzWTdyHqV0DDFfOGm0Z+a6zFQNs DqpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707810338; x=1708415138; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=reemTpUljE2hql9xjd8IpMD90PNtn/7WmrU9Ej9NrME=; b=bgt/B/rHnpZvRRQjJhIQSKDmssAtGsYcVV49ilLETiqn+yJ42Iw35C/Zr53eCGuWKS E90iBLb9xHybj1wxZDbXfeBqnfMliA2yyPWyROgi31ekDCWfG+DWdXK5nACgddaoYiOa +wfOTolxpbTCulUZJqBb9SYBgjIIrX/UGj9KFlV2CUrVyB7f7QdBv7orAFLQP4g1wSEl +gsT8jBAsaIO1hfSN4ZSshHzgR3Alwqi2wv95tf5nbQR9vU648hoPHiwUb3N0OnuzOcH itGMbV/8PIxi1Ax2QlCKIj8fvhlDWPMCDtijVQ/VsRuEgVNd7MvJVHT6aNFlas15s2/H ENWw== X-Gm-Message-State: AOJu0Yw4GwauMh2SIYGzPEytJ5NQkncsjQizZEyZoCJa6v4GE1BhizZ5 2MmhHVWLbl1FjI+EAhO+d/kjpl7di48u4lhepQacW8IFeD85xNfxNVC4cRrccw== X-Google-Smtp-Source: AGHT+IHdVSxasN4oAis0//ZPdCEMWUDJYTrgQ/MLG7AgCuffBGHM5QJWdZ4Iech8WCSaj2H3BSsofw== X-Received: by 2002:a05:6870:468a:b0:21a:16a5:cb2d with SMTP id a10-20020a056870468a00b0021a16a5cb2dmr8492961oap.3.1707810337945; Mon, 12 Feb 2024 23:45:37 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXDdCBCLdI9sx1zzt37KsoHeL7XTnLoVukrkgsqetzgW4xLKHNAkxlio6G77oejKdPRca267qej4WPzzNM4pUGL2SFwr6bNBnpL+aQOQQ== Received: from smtpclient.apple ([37.252.94.180]) by smtp.gmail.com with ESMTPSA id wx4-20020a0568707e0400b00219a43da092sm1748460oab.18.2024.02.12.23.45.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2024 23:45:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: [PATCH v2] mips: Use builtins for ffs and ffsll From: Maxim Kuvyrkov In-Reply-To: <20240206083456.721-1-zhujunxian@oss.cipunited.com> Date: Tue, 13 Feb 2024 11:45:24 +0400 Cc: GNU C Library , Adhemerval Zanella Netto Content-Transfer-Encoding: quoted-printable Message-Id: References: <20240206083456.721-1-zhujunxian@oss.cipunited.com> To: Junxian Zhu X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Feb 6, 2024, at 12:34, Junxian Zhu = wrote: >=20 > From: Junxian Zhu >=20 > __builtin_ffs{,ll} basically on __builtin_ctz{,ll} in MIPS GCC = compiler. > The hardware ctz instructions were available after MIPS{32,64} = Release1. By using builtin ctz. It can also reduce code size of = ffs/ffsll. >=20 > Checked on mips o32. mips64. >=20 > Signed-off-by: Junxian Zhu > --- > sysdeps/mips/math-use-builtins-ffs.h | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 sysdeps/mips/math-use-builtins-ffs.h Please CC reviewers of previous patch versions -- Adhemerval in this = case. LGTM. Do you have commit access? If not, please ask Adhemerval to merge your = patch. Reviewed-by: Adhemerval Zanella Reviewed-by: Maxim Kuvyrkov Thanks! >=20 > diff --git a/sysdeps/mips/math-use-builtins-ffs.h = b/sysdeps/mips/math-use-builtins-ffs.h > new file mode 100644 > index 0000000000..2ab6a03a16 > --- /dev/null > +++ b/sysdeps/mips/math-use-builtins-ffs.h > @@ -0,0 +1,3 @@ > +#include > +#define USE_FFS_BUILTIN (__mips_isa_rev >=3D 1) > +#define USE_FFSLL_BUILTIN (__mips_isa_rev >=3D 1) > --=20 > 2.43.0.windows.1 -- Maxim Kuvyrkov https://www.linaro.org