From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id D7CF13858D33 for ; Thu, 16 Feb 2023 01:40:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7CF13858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Content-Type: multipart/signed; boundary="Apple-Mail=_9AB4488A-A1DD-4869-9A47-C52F6FE78E8C"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH] elf: Restore lconfig libc6 implicit soname logic [BZ #30125] From: Sam James In-Reply-To: <29e67aba-b51a-be4c-0408-de87d0aae4ad@linaro.org> Date: Thu, 16 Feb 2023 01:40:27 +0000 Cc: Joan Bruguera , libc-alpha@sourceware.org Message-Id: References: <20230215014124.4144451-1-joanbrugueram@gmail.com> <29e67aba-b51a-be4c-0408-de87d0aae4ad@linaro.org> To: Adhemerval Zanella Netto X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_9AB4488A-A1DD-4869-9A47-C52F6FE78E8C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 15 Feb 2023, at 13:19, Adhemerval Zanella Netto via Libc-alpha = wrote: >=20 >=20 >=20 > On 14/02/23 22:41, Joan Bruguera wrote: >> While cleaning up old libc version support, the deprecated libc4 code = was >> accidentally kept in `implicit_soname`, instead of the libc6 code. >>=20 >> This causes additional symlinks to be created by `ldconfig` for = libraries >> without a soname, e.g. a library `libsomething.123.456.789` without a = soname >> will create a `libsomething.123` -> `libsomething.123.456.789` = symlink. >>=20 >> As the libc6 version of the `implicit_soname` code is just a trivial = xstrdup, >> just inline it and remove `implicit_soname` altogether. >>=20 >> Some further simplification looks possible (e.g. the call to = `create_links` >> looks like a no-op if `soname =3D=3D NULL`, other than the verbose = printfs), but >> logic is kept as-is for now. >>=20 >> Fixes: BZ #30125 >> Fixes: 8ee878592c4a ("Assume only FLAG_ELF_LIBC6 suport") >=20 > Patch looks ok in general, some comments on the test. You used an old = revision > and then patch does not apply cleanly[1], could you rebase the patch = and send > a v2? >=20 > [1] = https://patchwork.sourceware.org/project/glibc/patch/20230215014124.414445= 1-1-joanbrugueram@gmail.com/ >=20 >> Signed-off-by: Joan Bruguera >=20 > We do not signed-off-by on glibc, so no need for it. >=20 = https://sourceware.org/glibc/wiki/Contribution%20checklist#Developer_Certi= ficate_of_Origin says we do? >> [snip] >> +gcc /dev/null -o $testroot/lib/libsomething.so.1.2.3 -shared >=20 > We can not assume gcc will be presented in PATH, you need to use the = CC used > on build. So pass the $(CC) on tst-ldconfig-no-soname.out rule and = use it on > the script. (Indeed, GCC may not be the used compiler either, or specifically 'gcc' = but some prefixed or versioned gcc). --Apple-Mail=_9AB4488A-A1DD-4869-9A47-C52F6FE78E8C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY+2JjF8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kF4BAQCJnb2e/1uUCX/Kg/kVvQdWv2Wy0UcEJYamuEHdHz3L2gEAgLFQ4IuaxTic 5con41G3nbZczGMIcjwhZAjogXf05w0= =0pLz -----END PGP SIGNATURE----- --Apple-Mail=_9AB4488A-A1DD-4869-9A47-C52F6FE78E8C--