From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 008B43858C62 for ; Tue, 15 Aug 2023 01:48:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 008B43858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692064102; x=1723600102; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=xLwSFQ9zD/1jaTNWGyHl8SfNJGqZesrn5TvFboXT0GM=; b=dLMtyxdACEHQJqrwmTqkTiMl9fUElfJNE8YKYLSHqwfS9gqOp/hpks3c OBScbfeolY7dXZaDi0YWzpw3w8zYWSqBFCKMYW1DYfyjKnV7bgwS8xtik 7dGF/YEQNJVmPzQ2gIWE5vdDanWSeXXjfzP9ujAEZM/w7hAorhexrwzi2 82464vB4CKA6TsVQzLFKadqqCVcNGjvj22on1jQ7qzHPocDzRqhAj0CGE BSfINYD38CDjIyrJMW80aph41zXeysvzJLceFdfmMjWjkUTSCa9Pg5eKz 0crmIkcqrIZu3PvRX/5uJblmHfBPVA2aBWCG1VSd+fAfMfI57bBa/5Uxl w==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="458536224" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208,217";a="458536224" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 18:48:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="1064283452" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208,217";a="1064283452" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 14 Aug 2023 18:48:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 18:48:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 14 Aug 2023 18:48:20 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 14 Aug 2023 18:48:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8RpS2TI38KQyeoNSzlyY7EsPOqipfpcunOfX6knYd2vXwxNQ0FaD6sRFLELZxo5xGWVev+qXrRAQ3iImXiQaVjxrqmgle0IEWRlQOmAinjFS9eqnU1/53KwEb1H0fvb0w1CyUNyyyvf0PrL2wQgTn2g3uuC/d7oli7Ma3SFmjFmEAWZ8Cc4g5IcXg8wBFvo+CnEaNhndYlFj4vQ4IE46IMuOQhXfhMrDqHgKhEgDB3A6HQ+dkAPvc9H78qiIiE57ydgT40XKt8InWuFzFqa+ymJDEFiJUjaMvzy1HoNiHWX1W1TcOqegJhK083fTS492ubF9rwftujWTPEgNoNA9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FdNk/0H5YhFkjFqSLpZHbdTo417s2ftr/zwoA9dJ29Q=; b=X9QIDneZHpEz4dKX5IBv8w2Fd4AdRKYu7gXKJ1/B1eisuiJ5spoj26pA6gI6XLhQBz/b+lmyipMTInsSKrEWmKgKH4bV9vncjjaQWAEWvwNre2ybm/idFszu/9wHbc9Rrc8Ly8OCgdBhitoUszOXnfURhSKB2MlDS1gYzuo+CaESG/waONAQuMu0YPD9SPn0UhVQhx0QPD8JZmKt3Fo/Ue/1bpWrOPxJClG5ec4CZoeQX+7StJ8R6JAdu2QVZyeeYSq2kWME7LvgAq2L2b9d5kR2nPeCaUzLo1TdzHEQEul2UahYg8bAiXCvBaPqK1gciWv0HKHxEbDGSVPgf2wrOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6466.namprd11.prod.outlook.com (2603:10b6:208:3a6::21) by DS0PR11MB7832.namprd11.prod.outlook.com (2603:10b6:8:f5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Tue, 15 Aug 2023 01:48:17 +0000 Received: from IA1PR11MB6466.namprd11.prod.outlook.com ([fe80::8038:ec40:957e:dcb9]) by IA1PR11MB6466.namprd11.prod.outlook.com ([fe80::8038:ec40:957e:dcb9%3]) with mapi id 15.20.6678.022; Tue, 15 Aug 2023 01:48:17 +0000 From: "Wang, Yanzhang" To: Carlos O'Donell , "libc-alpha@sourceware.org" Subject: Re: [PATCH] RISC-V: Enable static-pie. Thread-Topic: [PATCH] RISC-V: Enable static-pie. Thread-Index: AQHZy+M/3+hew0VMFkiuU3j4uzsyUK/pyjCAgADSWQs= Date: Tue, 15 Aug 2023 01:48:16 +0000 Message-ID: References: <20230810233348.1214955-1-yanzhang.wang@intel.com> <38355557-5f5e-8149-0b01-8444419c7b0e@redhat.com> In-Reply-To: <38355557-5f5e-8149-0b01-8444419c7b0e@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6466:EE_|DS0PR11MB7832:EE_ x-ms-office365-filtering-correlation-id: 1cd2f0cd-bea8-4b82-e856-08db9d31b217 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VHMmfEV6PJFNkOsYxxTz2TksH2Ld9U7EX4D3ZclkL82Sj3f61d7YARW3Qhavjk61x173cz9+RiQRl+nvU2h1CefsG8tfYi9mnZ7z7zl1ZqZPQg1dcEcyi4QLfVP/4drdQ6XJ9oLq/4yUwvdmR0lBULChy9eT3CBZkRaxnMQfH27ct+iG6lCas4DCTi8PYfmood1nIqh3xHWfsOnYcgrkx2podZJcn0MJnonDaBjY9eLM/QdBVLa6vmiUwBe887wRxm3Q0v79MkLt/yFyCbL1D/oRK+2idjvxdIcPrp/bk6YBt3U+Oljus26w++klHKfc86lC77gaIOlGHeRuLaWUb45uwi6QMDVb6Tdukx8dZgpMF+e5MrFgzXsxwXm0+Wr6OAbl4zFxRwhcKGqTTQn18DhTpoFzCkX4s3UCa5mYadBFaVSF2zohBAH8ul6qMGIloIJj5iWiZSRR4cy6QJDjok1UCAYKJUg1gj8Dxy4gUtG0xf5TD6NaeILiWWjNHq/rEC9pJPCaWB1WWyXvn6WFNQo3gSu/OVrd399KZmvNL590FV8wTNfHf84Kh5IzGbr39HGMmnYFWDaiD5/GNeqFQv64aTjLa2D6NmwT37iJpaI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6466.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(39860400002)(376002)(346002)(396003)(451199021)(1800799006)(186006)(19627405001)(9686003)(71200400001)(6506007)(53546011)(7696005)(122000001)(33656002)(55016003)(38100700002)(86362001)(82960400001)(166002)(38070700005)(83380400001)(2906002)(26005)(966005)(478600001)(110136005)(66476007)(91956017)(76116006)(52536014)(8936002)(66946007)(8676002)(316002)(41300700001)(64756008)(66556008)(66446008)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fryxzSLC6IUaz5ilO+Odgu8J7NaAKxlmwSjrNPLt4lFTcoZxxF8tPaiMf15N?= =?us-ascii?Q?/9S2WcfBxHMTjscIgX2cl1m9B272HvxaM6w879uJ4Ui9aGsaXlIcxc9l9Cur?= =?us-ascii?Q?ZGtynR2Z+n3ayXmxmT2ArLnjBBLBgFJj9JEP0TyZPOhEdCI4gGkmyf9qwWE4?= =?us-ascii?Q?xhNNoratzQHRlbP1rovCFPWH2JmyMArFJtK+YuSTPNVFjEEqTOdKr5xoeDgB?= =?us-ascii?Q?RntVRgv2oV+YBxmHtv8Nsh4qqf+74lTsyhFRCDd5fo/GvGUmEBSFkiZ0VtfA?= =?us-ascii?Q?v9ri6mM3N2z4W/QmRBD74o9oOHwhjq/jx3A3oPW9+FJDWG61h/V07b5HeAsR?= =?us-ascii?Q?zfBiRiJUrs9f/odVX6FBi1wjjY3qRM5pJtoUMrz8At1KW+dpYgQ/5al7QTyX?= =?us-ascii?Q?JvPdlLqQxBpS2kk2ZX95a4xz/+Fb90K7qtH/D3WswH4yabHorI9L//8XanuT?= =?us-ascii?Q?17MnIAnqQfPLQwcsYJMLEPoWMWaUP1Z1JuaTe6Z5WlB/++Yk348macKuFXHF?= =?us-ascii?Q?oaVsrME0sHJf4aWP9UXDk9fiu+hmjBPjsJmvI4GRbAkqASeH/deQ2hyiyKwD?= =?us-ascii?Q?ho9bLIdNiVWuL/CQV6OTUvulgCcF2gq4cF25MvjIHNtXv/HQYKcqhbYbVe+B?= =?us-ascii?Q?XIZH/fCIre2IytiOkKEUz1RKKQYb/oLPDPK8sRiIhkEeIN7fhkbRrbM0vOOC?= =?us-ascii?Q?+Uahgzcngr+PY/lStAP1MkWLKJ82t+Byd4VchC4hKt9AZAf5uEzeB/6AlTWC?= =?us-ascii?Q?TZBgM+YFtih/v/Z+XDxKnd87xK7G3Tgc7HrxMBoKjwUMUpBWu6PCnIPfmveA?= =?us-ascii?Q?lHx+FTgPM4F12L5lPda8Ujh835Qh7GykrZ5HRqvHekWmRelIwGw5c3JbQLuC?= =?us-ascii?Q?KokVA8T64mNfDnw+zjz+51KfcZoa53Yl4k2n8xNwX+dx0HpuEZQui8G+XP1l?= =?us-ascii?Q?BtV2BrxzkD4MmkW522gL0tG6Lj7snBPm44vGwt8CioA3DUslUxpyZWybY4Pj?= =?us-ascii?Q?JwEjC9ZhTmh0KitTmbV8PVYl5AcMYl+9TpJSeOrdzXKccfwMphnl3AJCXITs?= =?us-ascii?Q?APEMgERycn5p6xxJTnZIuSIztDNWkhC/MHr9GscYEPYs0Tl8HabUCkohfFxx?= =?us-ascii?Q?qS5We2p1pSIkW6M5TNB6Apu+MNfT3hflc2h4R90fcpvGDWTHFDZvIUmJfoFP?= =?us-ascii?Q?u1dPVDVVhoyM/Itf1Urx6+QFJIG3ZIhlrVL6ItM8v7xrjBLN2EzSPEIe1/5r?= =?us-ascii?Q?Hwnr8D/hYPPoMmuh/LbHIJyeB+jcdAd2JgS86cOqTyzd0Ha4/8kciDhj3/2F?= =?us-ascii?Q?0Z9FURJnqys/awIhaXcbO83cGjFhkJ8/EX5Dfq+5s5w8Th/D510qNE7zsV1J?= =?us-ascii?Q?zDG1iyYN9Tiy8U+t/8R9b75krq7EV5I1HUhGnr7a+dWbKWy12qkgqu/VrRWu?= =?us-ascii?Q?Lr/zhQl5uPMuVVW9jTdPAWVuD1/pl/+rp1t2XkxS801WH2zQPb1IStrOyORZ?= =?us-ascii?Q?rFPlPGwuEoETgniQz7Z536cKsNIy8ZlSEyC+Q4iYt3nw9Iyr5gpT8gQ4P1M+?= =?us-ascii?Q?lvub8lFaPPr7B9IA0g5NQSJ8B0U+ns03f0oBXuCj?= Content-Type: multipart/alternative; boundary="_000_IA1PR11MB6466CF11ECAC0CAE6F5FCFBFF214AIA1PR11MB6466namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6466.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd2f0cd-bea8-4b82-e856-08db9d31b217 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2023 01:48:16.9566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wU8MkgmxMz2J1ZSZCbitHXPRWvkJ+XJeteXH/U5p2EI+f+ZrehDzO6r5KeT5rkH4Pf3woGupwuNLK7O5UuLcDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7832 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_IA1PR11MB6466CF11ECAC0CAE6F5FCFBFF214AIA1PR11MB6466namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Carlos, Sorry for the inconvenience. I have pushed a new patch and should be right now. Thanks, Yanzhang ________________________________ From: Carlos O'Donell Sent: Monday, August 14, 2023 9:12 PM To: Wang, Yanzhang ; libc-alpha@sourceware.org Subject: Re: [PATCH] RISC-V: Enable static-pie. On 8/10/23 19:33, yanzhang.wang--- via Libc-alpha wrote: > From: Yanzhang Wang > > This patch referents the commit 374cef3 to add static-pie support. And > because the dummy link map is used when relocating ourselves, so need > not to set __global_pointer$ at this time. This fails pre-commit CI. https://patchwork.sourceware.org/project/glibc/patch/20230810233348.1214955= -1-yanzhang.wang@intel.com/ Patch conflict in configure. Please make sure you are regenerating properly. > --- > sysdeps/riscv/configure | 2 ++ > sysdeps/riscv/configure.ac | 3 +++ > sysdeps/riscv/dl-machine.h | 2 +- > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/riscv/configure b/sysdeps/riscv/configure > index 2372225a26..340163779f 100644 > --- a/sysdeps/riscv/configure > +++ b/sysdeps/riscv/configure > @@ -29,3 +29,5 @@ fi > $as_echo "$libc_cv_riscv_r_align" >&6; } > config_vars=3D"$config_vars > riscv-r-align =3D $libc_cv_riscv_r_align" > + > +$as_echo "#define SUPPORT_STATIC_PIE 1" >>confdefs.h > diff --git a/sysdeps/riscv/configure.ac b/sysdeps/riscv/configure.ac > index dbcc216689..36da2b5396 100644 > --- a/sysdeps/riscv/configure.ac > +++ b/sysdeps/riscv/configure.ac > @@ -16,3 +16,6 @@ EOF > fi > rm -rf conftest.*]) > LIBC_CONFIG_VAR([riscv-r-align], [$libc_cv_riscv_r_align]) > + > +dnl Static PIE is supported. > +AC_DEFINE(SUPPORT_STATIC_PIE) > diff --git a/sysdeps/riscv/dl-machine.h b/sysdeps/riscv/dl-machine.h > index c0c9bd93ad..ad875c0828 100644 > --- a/sysdeps/riscv/dl-machine.h > +++ b/sysdeps/riscv/dl-machine.h > @@ -323,7 +323,7 @@ elf_machine_runtime_setup (struct link_map *l, struct= r_scope_elem *scope[], > gotplt[1] =3D (ElfW(Addr)) l; > } > > - if (l->l_type =3D=3D lt_executable) > + if (l->l_type =3D=3D lt_executable && l->l_scope !=3D NULL) > { > /* The __global_pointer$ may not be defined by the linker if the > $gp register does not be used to access the global variable -- Cheers, Carlos. --_000_IA1PR11MB6466CF11ECAC0CAE6F5FCFBFF214AIA1PR11MB6466namp_--