From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2029.outbound.protection.outlook.com [40.92.40.29]) by sourceware.org (Postfix) with ESMTPS id 543F7385781B for ; Fri, 2 Apr 2021 23:06:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 543F7385781B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=i@maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hh4fCve8iPpodA4YAG3u8UWDExTjhZY4wX0jWoGb844ke98R13phCE0PzMZZlKNXg8W+P6OMyLdGNXJQ9lNGYBzhv8lX3B+iWXkt41bDhBJWHqdd5PBn5EcgaOI3847iJ4Goe4eBVPHbij9w5iWbTI3vigpFhRGoAtj/Br0Kn+u0RMW9H4mbXZkfv5rLm33XxSR8N7nbSt0yGp1K3vJTMqFGKN7cSYzy409zGN/BSzBTaJABtqHQy+o/iFizFWL0TN0DR3XUJcLIDahpkXmOLtOzbkmk4Fjs10u2DDj9oNOWzPAP+J5FD+/ievX1NUszMN5g2jMg8j26+5RrxIERTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E4UfJXyHSHXbJ1nsczr9vmidcZ/4KsZfU9ZeNQbk2DY=; b=N/XhaBk7Nu+d0fPvOJn/m4mH5J+HT+tE4G8gnOk6q1B1aQhxdCGrfiID1JZUpcpq4tdRV6vFEIvedOw4FZvbVcfIRVAZg/NdDORVZdyPNdRcrgFUKbNdY3+HUhZeT1PWRxMrVsZ5Rl+hgJ3Kjop6d/IYxMKs1TS4FdB7z99GzWUAhlcYGCKv6ZUz383Qd6zJDwKJhS6Y//0lIRt5oiqpgw2+cLzqM5JXqgUBf1E1WjUN+xag6QDXgi1W/AHlEuqYGt7yyWpQiXn59z2XpajNH7w7e7F/cYW+vzczJgEdQIKqFDnkMqruW2qLFNejjRQpT+mR3KARTtiBypU/bHjY3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6NAM10FT031.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::43) by DM6NAM10HT005.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::445) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Fri, 2 Apr 2021 23:06:14 +0000 Received: from MWHPR1201MB0110.namprd12.prod.outlook.com (2a01:111:e400:7e86::4e) by DM6NAM10FT031.mail.protection.outlook.com (2a01:111:e400:7e86::157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28 via Frontend Transport; Fri, 2 Apr 2021 23:06:14 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:B2C6D6BF8695C47EFA79951EEF1FF01058A0A5CECF0FE438BEE4E1C333A043F4; UpperCasedChecksum:AB3890BF10C5015417688DDB5AF01C37D2C6B2D7AA25C9F00A0423D0B5061DF1; SizeAsReceived:8935; Count:47 Received: from MWHPR1201MB0110.namprd12.prod.outlook.com ([fe80::908b:cd46:355:b6b3]) by MWHPR1201MB0110.namprd12.prod.outlook.com ([fe80::908b:cd46:355:b6b3%7]) with mapi id 15.20.3999.029; Fri, 2 Apr 2021 23:06:14 +0000 X-Gm-Message-State: AOAM5314qbfSKd/KYlPqz+ZYmhxjEOEmgIxax3OqH+xxj0xLIXV6Q1l0 sx68aqXgHYXdxGWqBulL89U4nQTpquI5yzymSLE= X-Google-Smtp-Source: ABdhPJxbWuGMJcQvQzhsuViOwifa5px9SXQHz3GFbJ4G81YurNLtDwxqe3pygKPF/PHmM5PpgcFK2veDaA7jdFWZ8gQ= X-Received: by 2002:a05:6214:12a1:: with SMTP id w1mr15070794qvu.57.1617404771994; Fri, 02 Apr 2021 16:06:11 -0700 (PDT) From: Fangrui Song Date: Fri, 2 Apr 2021 16:06:01 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: dlpi_tls_data is incorrect NULL when dlpi_tls_modid>0 To: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-TMN: [l9YSkYUi0dta8+RyFAHb0GwpzhIbbfog] X-ClientProxiedBy: BL1PR13CA0443.namprd13.prod.outlook.com (2603:10b6:208:2c3::28) To MWHPR1201MB0110.namprd12.prod.outlook.com (2603:10b6:301:56::8) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mail-qv1-f43.google.com (209.85.219.43) by BL1PR13CA0443.namprd13.prod.outlook.com (2603:10b6:208:2c3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.11 via Frontend Transport; Fri, 2 Apr 2021 23:06:14 +0000 Received: by mail-qv1-f43.google.com with SMTP id u3so983427qvj.8 for ; Fri, 02 Apr 2021 16:06:14 -0700 (PDT) X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 8dab4546-7a00-4c68-6dde-08d8f62be9de X-MS-TrafficTypeDiagnostic: DM6NAM10HT005: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oQW2VIpHmvwlUDYL4YGpFA18LkvNB5nML3I57tUDPxTqBsGUJqy5EB0cU6Jju4TcRgzQpJYEXACsaUjodzVCCC5Hg2PE9b7a54t/AqdRhvsdb4/vrPSQZRSUhWuhhUljffq1wTbSMOlj7owJ+jDEnaLZiWfORQ3+9uiLlzcRrSQNzKM7buF9wFW9jMn30trlzx5BrwzHgniur3IsZWDsO7ZW86WqWcy4ljK3f0L1OOkEhCUHElhM9rKhWjDZkjUTRTaxDPJnLyMJi8JJmt9VhOajrdOtb/40XLSE5tFb+x48BtNcKECrTTiyoCKOJ1ynBuCXVvVXYvltqOgR8KK7B82CnvmKPybVrDR1aciYgzuUIhU/WfwGdFUJgONYRSRuFz7Y7SptGbexTtQRER6PYclwJNQpCEBW0OafDqsICJcIjYI8yTV72eCq6VILQPT1 X-MS-Exchange-AntiSpam-MessageData: PXYuWNe3QStcZrLPqUBrOg1zOYtspSI91b9TYRLbzdI7/YdcrbckSKi1zDCCw/+eopNpRDO/YTAmjeHTfikkzpFJd17YVr0H706BOi3ipifp1GWJJ6JufTmkUrAuD1E1EqzworhV3mDHKgntGPIwnw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8dab4546-7a00-4c68-6dde-08d8f62be9de X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2021 23:06:14.4868 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT031.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT005 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, KAM_NUMSUBJECT, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2021 23:06:17 -0000 I was trying to clean up llvm-project/compiler-rt sanitizers GetTls function https://reviews.llvm.org/D98926 and my change was reverted due to an annoying Ubuntu 16.04 glibc 2.23 bug (seem so on both amd64 and ppc64le) dlpi_tls_data is incorrect NULL when dlpi_tls_modid>0. Thread 1 "tls_race.cpp.tm" hit Breakpoint 6, __sanitizer::CollectStaticTlsRanges (info=0x7fffffffe8d0, size=64, data=0x7fffffffe9d0) at /tmp/llvm/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:294 294 if (!info->dlpi_tls_data) (gdb) p *info $5 = {dlpi_addr = 0, dlpi_name = 0x7ffff7ffe6f8 "", dlpi_phdr = 0x400040, dlpi_phnum = 10, dlpi_adds = 10, dlpi_subs = 0, dlpi_tls_modid = 1, dlpi_tls_data = 0x0} This works fine on glibc 2.31. # dlpi_tls_data != NULL when dlpi_tls_modid>0 $1 = {dlpi_addr = 0, dlpi_name = 0x7ffff7ffe720 "", dlpi_phdr = 0x400040, dlpi_phnum = 12, dlpi_adds = 10, dlpi_subs = 0, dlpi_tls_modid = 1, dlpi_tls_data = 0x7ffff7a35740} So do people know when the bug was fixed? From the file log the info.dlpi_tls_data assignment code hasn't changed since 2011-09. commit 74718d13e4638ccc5922c2197b9088ff5fc00251 Author: Ulrich Drepper Date: Fri Sep 9 06:43:43 2011 Fill in real information in __dl_iterate_phdr