From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2089.outbound.protection.outlook.com [40.107.14.89]) by sourceware.org (Postfix) with ESMTPS id 2238E3857004 for ; Tue, 17 Oct 2023 09:58:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2238E3857004 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2238E3857004 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=40.107.14.89 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697536689; cv=fail; b=X17jr3PULuoJ2RRPS7z2YLn19HkSNpzcd/c+MPtxE9b01suH/Pir60Q2pVdSu1ogmCjMSmQh7+KynG2ukON8AcRy0slmdxH0p4IjEwjc7s5XrDmHX5i1wHEWBK1jqbKHCWFCrgjN8hnMfb2ggyMrkA4erWDDdlWTSiV/bo4VCbI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697536689; c=relaxed/simple; bh=RWAFkxMNxT0gWmYkGhtMBnPq3so2LzWwdA+1BkIi3IA=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=iXGdKoOEEjbAS0o1xIKPh1NG9gKiGRVNrD/i6jx5y+xGLmakzxxRcxE0ZW88eV93vnmruLXBWvmIsEMkhJHCKG2KQYXdFu72TG0n+ABu747HBBdds9QbPU0zGO33WQqs/PZOIlsVPWTXZO2nWuSjqlwQB84tFQp1k411zIg+Qkw= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p7IekJPMdFuRfE8o5AjiUmhqSDwl4wcuGcRly9vFYco=; b=9K5kI7FJobkdD+aEc/iNvjUQf8DGEJ5SY9wgVI2FOgOQ4g1jIVqCV6VtOc8kaGabDcSl0W/ERR12wmBIhWNiWj3eJg1nuKC1M7rmb3KViPOa8fdvSs1Jx+NKjux4IJyLyTF30EiyurBXGFKMavweH4tGfP0AGAoMHft4KBk72C0= Received: from DUZPR01CA0004.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::20) by PAWPR08MB10308.eurprd08.prod.outlook.com (2603:10a6:102:369::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Tue, 17 Oct 2023 09:58:05 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c3:cafe::40) by DUZPR01CA0004.outlook.office365.com (2603:10a6:10:3c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34 via Frontend Transport; Tue, 17 Oct 2023 09:58:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.20 via Frontend Transport; Tue, 17 Oct 2023 09:58:05 +0000 Received: ("Tessian outbound 0ae75d4034ba:v211"); Tue, 17 Oct 2023 09:58:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3fbf0214aa296b51 X-CR-MTA-TID: 64aa7808 Received: from 0783e4c1e577.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 36F9300A-A037-426C-9D5E-EDB1082BD516.1; Tue, 17 Oct 2023 09:57:58 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0783e4c1e577.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 Oct 2023 09:57:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/Xbgb4URRFA4I+FclxYx96hJAxGh2m/A2qsGEmvEH83qQBtMUzwY3mf5CXZ4GooNC8v3E80h0LZqHooH73opdDf2wqBa1WiCAHDbOY9Y8PfwKj6wfkjnbvaUcTVltn1l9bPpTe8d9bzDzgf4AmdtHjsWX9yFW3ba0GHuBodKCXfJtIARlX7L5ioe/0hq85Td9hjNPqR2J+HZGvtq/H/KDJnAve0HjFKSrSemjFjNF92oOq46+ntuZRSAZvvgtii995CLfMh+inURRvppcjFClWHnq2QzigTKz3490jrhHB81pIyTlP0y0C5Gw9K0W5mpZ+VeU5wrHzhCBJ15vfbCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p7IekJPMdFuRfE8o5AjiUmhqSDwl4wcuGcRly9vFYco=; b=QvnfeYx2FDR1IyAu1Gg6F+mhAM8BFzzkPUrLErr1PuUpQpN5Jel5Hx+jQf8t6iUwsuldIo/RhHQco7qpySHAj53MxSlVueMzriZ1OVStWJGcM1BIzCCkCrQ45LkrjJlqbjXcZvGB6ixTC1UKOexDPddW8+j5sC0YIwzVJ55ptCSm5LhRRud0lkn3SZJH6+vO0CoSa9H1g5cZ9CE58GhtJcWfcmqjYL+4JWyf/9ugITQjcWjv+Ol+GK41AsX1c7mDMEDH986R8zHio3aiSL7H3wP/RtrlFjBUqoCrikbvk2ShpCoBImtWAV51zPaOSKRNo/wLUfBeFywhx1XyY7QHSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p7IekJPMdFuRfE8o5AjiUmhqSDwl4wcuGcRly9vFYco=; b=9K5kI7FJobkdD+aEc/iNvjUQf8DGEJ5SY9wgVI2FOgOQ4g1jIVqCV6VtOc8kaGabDcSl0W/ERR12wmBIhWNiWj3eJg1nuKC1M7rmb3KViPOa8fdvSs1Jx+NKjux4IJyLyTF30EiyurBXGFKMavweH4tGfP0AGAoMHft4KBk72C0= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by AS8PR08MB10072.eurprd08.prod.outlook.com (2603:10a6:20b:634::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Tue, 17 Oct 2023 09:57:53 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::31cd:30d1:37a7:3e8]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::31cd:30d1:37a7:3e8%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 09:57:53 +0000 From: Wilco Dijkstra To: Noah Goldstein CC: Adhemerval Zanella Netto , James Tirta Halim , "libc-alpha@sourceware.org" Subject: Re: [PATCH] strcasestr: check if ne[0] is in hs with strchr or strpbrk as does strstr Thread-Topic: [PATCH] strcasestr: check if ne[0] is in hs with strchr or strpbrk as does strstr Thread-Index: AQHZ4dAd5lZhjOSe8k+Jyf663Rm12rBJLmuAgANvNACAAAh9XIAAOYsAgAEcKYM= Date: Tue, 17 Oct 2023 09:57:53 +0000 Message-ID: References: <20231014083253.138510-1-tirtajames45@gmail.com> <8deea669-21b6-442b-a58a-05be075290a8@linaro.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|AS8PR08MB10072:EE_|DBAEUR03FT011:EE_|PAWPR08MB10308:EE_ X-MS-Office365-Filtering-Correlation-Id: 51037a9c-0244-4a2e-e685-08dbcef78ece x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1ZQpOlR7tSWfGtTjY0Fgu4tzmlYPVz8Gpg1tfahviG5a8km6fb04YFGRfVewSDhNIXdgnLYqnidaf6fcerBuUvViO/nzTlHtXoktizdXcH2ikewF8D6D4prQS9ax5BfTPxDYrdmeGOdkI97OInG7YP9d9rbdjO8AZpgE5p1R8o9803MNR+6pz82TeMODRZOicAwpaMgqBUy2caQVnA6ZCeOlNiqQFnIYSTSgKiEvbLwWH8HlB0y+3jNlPf7D0HoDXePQH0pbkzwmzxW68L3jtcVFY51UANNSbJZ6gfyaLvluhDcEcsFw4QCvCoWfBIRBkBJSn0hg1iKJl/Ms3chpmX6tjdESYYDg0OczCX3+qq/gVo8Oc2gbFc1B1jJwYNWmFBpmhlJJpPgwesNcF2fxTXa2MKhvyzpSfqQseY/4gP5k9NtIIZS+3cMPPI1ppD3l5o9IOC7wSOQR36d+PsNHiIPo56KsTg6E2+Cpp/No5PxXicHXlv+05VH4MRHmkh4jAkBsLnzy96feAcjdLRd6FEDbeRwWAB/VNY0wfygJoOeLaZe+7Cljn8gpJ66/GVsKn1UTAF+pbgMNHxWKHegfR7MiL1QXEKvuCesLiS8AKK4RoxZizTRCt3JP3xkYdjFtgc6rq87oI1BJ/009h1qPcp/uB/DoGaVoz9upOUkR98ewj4BZ2N9ZV840uUcDvzbEukzHDAO/40ouY8/ylOhH3Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(396003)(136003)(346002)(39860400002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(55016003)(478600001)(66476007)(54906003)(64756008)(76116006)(6916009)(71200400001)(66556008)(91956017)(66946007)(66446008)(86362001)(38100700002)(316002)(6506007)(26005)(41300700001)(7696005)(5660300002)(4326008)(38070700005)(122000001)(52536014)(9686003)(8676002)(33656002)(4744005)(2906002)(8936002)(40753002)(133343001)(17423001)(156123004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10072 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d416bef-4586-4dc8-5834-08dbcef78821 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: keO6G9yz81NjIZInJiG7qTGvFoUHmpNk0dvezqVyVU6IlYgCJqWb37D2KgJHOtD4mSQIFZmAG3jwCIHEpsvcoSy8rF/HM+8F7Vphjiepuw6p/qfXjWRf8sNGUaLDRj+PtCOK74jQR65MOEfffDv2RUOMqBa9a5X4zl+B1/dE2w31MKe5mdjZZDFa07gwBECzuVPixoS1rJqwZgpQbqq+Y9Yaoe1DiDioBFfmRraI0gfPeFkoF9nrUHAzDkV7hOfzjc1iu/ffb6J9aqUtQcsadQAYryTjeBDlNqmv88yiupxtdmTU+/sjs5MI3+uHuQNs/E8ZXgG8uDC4P9rsPnJqA3MjOohON35sGf68+yA+FvNN6YagQQJ4bN+r87Cu2y0Lr8wCr3YJ/5c5Vc63SN5vc0qydQuOdtbqGcPxLkDwyP77NHGsiNaJnutgN+o7Qnbku/xfHf9nMxPIcw6u7kzUt9exwuOOAT9IjUJkVUDWh+9TCH6g/KWUqFG9vGNbWliAtd+vAjxiaNTuSKJrcGa4/cqLwXa6g9IIL+UcsAJZO0oQK4dXwrPEDcmTe1ATHNTvD4QortknOGaahFTm7IabfpGtRhommjb0iVHSNLbm70O0jTenT0QabxNF9MoIR8s33mp1sKg/mSVq6n7MvJYKAz6D/wTzs8oOzkHq8JeeN4ZxyoURT3uGvDt5p6qf2jU+CnyjCr9GETo5XYMz9fe1vYHYcvqGIBH27llpbtxNy8B/NAA/yeoQdsq+6tqyRGgK6aCc/vfTzWVKRTsCiw4YP63/nD14X/ioawZ6F6Ew1F32Pp5yfRDilggLrjlaayg8q4FQrKkPieYBSitzHRP2qg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(396003)(39860400002)(136003)(346002)(230922051799003)(186009)(82310400011)(1800799009)(451199024)(64100799003)(46966006)(40470700004)(36840700001)(47076005)(33656002)(40480700001)(40460700003)(55016003)(70586007)(316002)(86362001)(70206006)(82740400003)(356005)(81166007)(36860700001)(54906003)(26005)(336012)(9686003)(7696005)(6506007)(8676002)(8936002)(4744005)(2906002)(4326008)(41300700001)(6862004)(5660300002)(478600001)(52536014)(40753002)(133343001)(17423001)(156123004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 09:58:05.1069 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51037a9c-0244-4a2e-e685-08dbcef78ece X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10308 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Noah,=0A= =0A= >> I ran it on my x86 machine (with proper AVX-512), and the "optimized" st= rcspn is=0A= >> slower than the simple byte loop on bench-strcasestr.=0A= >=0A= > "optimized" being the sse4 version?=0A= =0A= No idea, I just ran the benchmark as a smoke test. However this code looks = wrong:=0A= =0A= + s =3D (char *)strcspn(s, a);=0A= =0A= Cheers,=0A= Wilco=