From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2059.outbound.protection.outlook.com [40.107.105.59]) by sourceware.org (Postfix) with ESMTPS id 2E1933858C52 for ; Sat, 4 Feb 2023 11:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E1933858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F1cMrweVtZ2jyjmnYkv8zf99AyBmaYAIHnLnTaKXzlA=; b=pAvrKVSKTGOhl9YHJyz/eAwkWaCm5Ti5oY3kQfao2hHbXhKUG6wkt93ByYn8lCkv/4Ui+q9g4R8cADKXeCXuoD/4lwngWM8KiDDHaqa1kwaHBhNSiRTagvsunn4E/bItJIDZQBHDRAf+5aqf01KeHX+ho2wBjd+VSsXBJ0BoY1M= Received: from AM5PR0701CA0064.eurprd07.prod.outlook.com (2603:10a6:203:2::26) by DU0PR08MB9463.eurprd08.prod.outlook.com (2603:10a6:10:42d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Sat, 4 Feb 2023 11:38:12 +0000 Received: from AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::5e) by AM5PR0701CA0064.outlook.office365.com (2603:10a6:203:2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22 via Frontend Transport; Sat, 4 Feb 2023 11:38:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT043.mail.protection.outlook.com (100.127.140.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32 via Frontend Transport; Sat, 4 Feb 2023 11:38:12 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Sat, 04 Feb 2023 11:38:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 72e9d8d235eae80e X-CR-MTA-TID: 64aa7808 Received: from 9f9f33df401e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9C281460-4CE7-4785-A6AB-AFA87A2E97C2.1; Sat, 04 Feb 2023 11:38:05 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f9f33df401e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 04 Feb 2023 11:38:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nsLXIiKwpuq7taVzAP4i2bBSQnqhpziDo13N+ygV6nZ9D+XQuX64rodDPPiKwAlCIdDfQKxq12e65I58B5/24FOLPlb3Ga83rGQvVPOx5/YKLtkqzXCRwAVN7kZ0f7/VHzNfEpF/jIhcpvi+qIyNwa69zE+HxqNqDRBoRrEpGfQwKACc+n0uSREwiULErB8ChlZgfyPvghGKgqJTVcWK398OWMQg5lZCr/gRcFFMrTuhIXh7ps+8jDXNWk9+qcPpZstssJWNpIIuHy9XaYE5By1Rf3ev+L95Xa+iQiLzIg3vz/NNckxy+4M6QY5OYkQ8N2uflXSz1r9bYGzm4+T1Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F1cMrweVtZ2jyjmnYkv8zf99AyBmaYAIHnLnTaKXzlA=; b=OhMaUHVB6DDPx/IgAdgTEqhewDO1hkxAzundhN9ZxPTncVFRCfPdbYsmYQaDrmW/lMV2xE3Em2Mb5gJSHimGtAa4AcBp/DIV0WK25BlZ1tM7gTv368CrwMkpDYuyDLG9HjKreeOgsH91+gnnNowKFrYIZV6l2IrgyIjXSsjutKMfQSBkYZDIxFjY/ji/KJ2fM73PYhlk3j0jpcH5E49oHABcnoysZwHk3b0TipAOHB1aHIYIWGo0GTt305V8eAoTIxv+wcuCD22rreGc0xNUm7QzWZMk37eHC3lkrkCpmQ5kg60dcP7EKFxGssaVkdy0U4ssO10onyplo0CYhJae8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F1cMrweVtZ2jyjmnYkv8zf99AyBmaYAIHnLnTaKXzlA=; b=pAvrKVSKTGOhl9YHJyz/eAwkWaCm5Ti5oY3kQfao2hHbXhKUG6wkt93ByYn8lCkv/4Ui+q9g4R8cADKXeCXuoD/4lwngWM8KiDDHaqa1kwaHBhNSiRTagvsunn4E/bItJIDZQBHDRAf+5aqf01KeHX+ho2wBjd+VSsXBJ0BoY1M= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by GV2PR08MB9352.eurprd08.prod.outlook.com (2603:10a6:150:da::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Sat, 4 Feb 2023 11:38:03 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%7]) with mapi id 15.20.6064.031; Sat, 4 Feb 2023 11:38:03 +0000 From: Wilco Dijkstra To: Richard Henderson , 'GNU C Library' Subject: Re: [PATCH] Replace rawmemchr (s, '\0') with strchr Thread-Topic: [PATCH] Replace rawmemchr (s, '\0') with strchr Thread-Index: AQHZN9BKeDl6MDok3kWX+F+boTUVFq6+H2gAgACE88c= Date: Sat, 4 Feb 2023 11:38:03 +0000 Message-ID: References: <4514eccc-02fb-91e6-a770-bae744baebc2@linaro.org> In-Reply-To: <4514eccc-02fb-91e6-a770-bae744baebc2@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|GV2PR08MB9352:EE_|AM7EUR03FT043:EE_|DU0PR08MB9463:EE_ X-MS-Office365-Filtering-Correlation-Id: 298e6a1a-aa4e-4162-3bd7-08db06a44c35 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: y/ChA10aqjE0Lu/0YHuphAICm20/0wXRRx93dwCu4XTolMaFgZGiGak+mIta4xBPGNfujKMtXAph1vBKq2c6JIvXnjKbgPTUiFdBRPCkHdJoVno2JgzGowTUPJW8ZCd+1yPteqKH9NOEqIWkqlNhJFoRvyALmug2PEumf+eCxOdMORloPn5kMVvezz0Rcp5cz/03+PwPacJCHvYlHSwyhN2K35tnMCnd0KObIeFA0O97rgImoeSGDGCh13yWpaz+yXn8C/v9FPHad1ulrWTUoqD28zZdmgWmNqonyjglGBYSSz69cOuTO9MgHS+9NwlbCeXLoUrxSTTFfLff6r8ZGjFYzNvQtmUJ7GFqjTSfhrkmPBnhwKo1bJyeo6dnnMtonJqcEdhYYwTyS+CHhCZAZ/K4ZhAbCqKnV1450VmXxaK+rFbKTTht7K5JY6/kjHVhuQcjxBzqASGe2i9OmG3NGRpWttlAl9AjkWUtMBeSTfyjlTsZwXBqu1Ik9dif2BgtPoPO5XjjJPPc4pbFpe6E5Ag7e7oM+/RWfhl/cCvgC/8vYFDOI8BA+UxLCl2N6QC/CNoy0KVbDXuIJYTHCW3xxGVHMcutgv9yx+UH/bw55nSWxMXVllbnc8H6I9bvVlQLR1fOSjX8QwKZlHjYN4kf5B5/46klCH4ajOFalQC9/c5EuxGjdOvEUEjpAKpfNhNJCLrf4SbkO6z79t/ZQOktR21MjAXIuUn6Sm1KT/285aOko3vEWdlBv1lcSqqIgPZh X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199018)(38100700002)(33656002)(86362001)(38070700005)(478600001)(55016003)(2906002)(5660300002)(71200400001)(110136005)(7696005)(9686003)(8676002)(41300700001)(52536014)(66476007)(4744005)(316002)(91956017)(8936002)(66946007)(76116006)(122000001)(64756008)(186003)(26005)(6506007)(66446008)(66556008)(17423001)(156123004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9352 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 65875833-1dac-4d73-b879-08db06a44691 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YDS+S3zlQklLtpb4WKe4p5LOIEdGSmCrwjyEOgObJaxj/ObLNRDLaF0ljCd2dAzGI15ptOkMDuTMQl4d6iLy/MMIX17dtnEiXbxNsK3HHYHBCIjcPTY9ukWP4OyCM52UOZeni603lbIZeophPGf3ofkgfZ5gSoETPe1E0/wMJa/SVlINvuSdMYSfnYEpdp8urEGKAYsOlhUG6ltm3twbCd2o/RUfjEfF61rQ6T9cmhVk/BrdfalwYJ43wUcp0p/N44HnUacZhyH5uD1fX0gsBxF6mlSLVsezj32QpBvUAem+8o/HFCgcaY9vhwkHjCJRNzesjT/n4nnQ/zrAzoGDkCd7Xgz10EfIuQMsY2zIl4CNN5vFTSAt4EeIgrXW+iipPAYWI+3Xx8uoIi7fEiY565iI6EcJCiEOsY0/21OMWm/bn9bOA33CSYXcrOUSqdPC+Ax7e2x/BekMa7izrohKctokTh5dNDyyNKTf0ES/rlnrHqWRjeluBL2AwCpDaa83olU5xF4LQRn4LFfgfBVzZeiXrvrYrjvUI9Qop1B4Z2uzOQBnPeZAK/2lzEl8dheAIvhmQQOnqj27UyRtiki5FrJHuyBo6iMTEMgmSM4zooRXtMe63CKlr9aUEYBg8wXvA+N33rxHJwHVILadUltSIavg4j3R6Ez6bRi2SYUczNGG1FHdwdKk65QoewyxcknAg3Z/KeZ7yDqAayn7LbjsZgb9adxTUs1EHU02RMuJHddo2+pvXpkEC6QeJMEE3t69 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199018)(40470700004)(46966006)(36840700001)(33656002)(40460700003)(316002)(110136005)(7696005)(8936002)(5660300002)(70206006)(2906002)(70586007)(8676002)(52536014)(41300700001)(356005)(81166007)(82740400003)(36860700001)(478600001)(40480700001)(4744005)(55016003)(9686003)(26005)(86362001)(186003)(336012)(6506007)(47076005)(82310400005)(17423001)(156123004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 11:38:12.5392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 298e6a1a-aa4e-4162-3bd7-08db06a44c35 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9463 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard,=0A= =0A= > While the compiler does lower the strchr to strlen, why not use that repl= acement directly?=0A= =0A= I'd prefer that and be explicit about what function you're using but like w= ith mempcpy=0A= (which also gets expanded into memcpy+size) there are always people arguing= the=0A= opposite... Since we taught the compiler to do the right thing in most of t= hese cases,=0A= it doesn't really matter as it's now syntactic sugar.=0A= =0A= Cheers,=0A= Wilco=