From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) by sourceware.org (Postfix) with ESMTPS id 657AA3858C60 for ; Thu, 16 Feb 2023 16:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 657AA3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CaKtx/XrsBv+hxcMGT0J1Myu+CfiynFNkgHbK+4pkI4=; b=PZRbIfGc04EI8Wr0RqbOdHZqHwM2ClkNRI6ZxwwUzYr3ZHP6orVjuhQX5TjstV7VgIp3IDYrNKRiatH839RbtgwEAgFprDOvRgQxrQ1My6jv4SEXCkJyzB6sNg6kEDqABB880ci732wAz0ruwstHUnI3dLWAKd/yrc339yzoYl8= Received: from DB7PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:10:52::23) by DBBPR08MB6250.eurprd08.prod.outlook.com (2603:10a6:10:1f5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 16:57:24 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::f) by DB7PR02CA0010.outlook.office365.com (2603:10a6:10:52::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.28 via Frontend Transport; Thu, 16 Feb 2023 16:57:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13 via Frontend Transport; Thu, 16 Feb 2023 16:57:24 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Thu, 16 Feb 2023 16:57:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9c8eb79f1c1498ea X-CR-MTA-TID: 64aa7808 Received: from 0783025fdc41.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E305D2C-00A4-4D93-8F30-4E2E52003F54.1; Thu, 16 Feb 2023 16:57:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0783025fdc41.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Feb 2023 16:57:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fzps+f7gX1I1ATlbHnGSQ2r8eVucWC0RdD60owsMK/52KgH4wkH5PIDaMYF4qh59jCxsADnvDKOIWuv927qyDzEHVRlqzG7zwybSsmDSLX9RXRxcwjb8wknqUuIhUDJFFdAlRcoeZRPhGPTcCo2Tb60mgQzbXc/IrIzsM7autQtb8KkTxfzAooBHQ7VNehxFKw9WI524UNYWP1rVgUOYnFGwr/CGBmLlk0/Q3KIeHzCihzVUAXNek8B5yRovRUA9j9+/HcK1JRLp0sNc46SrltDBRIm6aeBTXvpqDsOK61jB0k54cp1y8GXnoOhH3JvY0XsTUc2aT6w/pEwpap3qfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CaKtx/XrsBv+hxcMGT0J1Myu+CfiynFNkgHbK+4pkI4=; b=hw/ASJDU1xWm4wDDL3oF5k/jMaVipsIHyIdcYlxXXpkH9og27mM1hGYpayM7FYAP44B/YT3pW9fuHroZZPMoIMcahWuy3/j8iBKHF5lRDxADK3VWPznmoRGqq/4fz/Crriok4bMlKbYcnWz16p2yC08drPCysVsPycoGtT2uYtyzswr10xRwNKCE8JBU+kVUc35znoLjUvrNdkw4N5Ue4it17+Th+kxDBPiczmcxlhn8F5Kqjp1yxO5MYmomJ0r6D0bEJVs8YS8ZOT6+HVS2fSzHNPB7eBOhWiufMlXPDrK+8BC9+Ak2QW79IhqSgJuL5wxOruVVsdrQnhQ7MwfxjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CaKtx/XrsBv+hxcMGT0J1Myu+CfiynFNkgHbK+4pkI4=; b=PZRbIfGc04EI8Wr0RqbOdHZqHwM2ClkNRI6ZxwwUzYr3ZHP6orVjuhQX5TjstV7VgIp3IDYrNKRiatH839RbtgwEAgFprDOvRgQxrQ1My6jv4SEXCkJyzB6sNg6kEDqABB880ci732wAz0ruwstHUnI3dLWAKd/yrc339yzoYl8= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by GV2PR08MB8344.eurprd08.prod.outlook.com (2603:10a6:150:c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Thu, 16 Feb 2023 16:57:15 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%6]) with mapi id 15.20.6086.026; Thu, 16 Feb 2023 16:57:14 +0000 From: Wilco Dijkstra To: Kito Cheng CC: GNU C Library , Joseph Myers Subject: Re: [PATCH] riscv: Set __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 Thread-Topic: [PATCH] riscv: Set __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 Thread-Index: AQHZQUbdy2o0Jf709kiqxyLNuKHNoK7RmD4AgAAm1o8= Date: Thu, 16 Feb 2023 16:57:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|GV2PR08MB8344:EE_|DBAEUR03FT030:EE_|DBBPR08MB6250:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a040a9a-1d65-4be8-3f50-08db103ee0c1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Wy2aPCLh0AOMRpvMhGYe+oxvIE19JWB54kptFpsVHyb301zXB3JbTKskOUEdb0Xcpj1Z1570mW3TH8zaJA2hdApxX+379fITNYPGSDEILLxuOxuCkLRsURXEF0Ri5tg8FGUpqMCZyycoUdTapTltJi/1fHsvJFfi6za33ILRj8gFl2nu5fMx2v75KzBDxx4CNsa8ji/SBgSqOdDdRSK8aDTA6uekLKRxSO3qDXO+GZEcjXUj/1XbIYcsny8NfFsVpjxIOep3dLuGhJjsjCsTjKtB/Nf7d3E+yCSCC8aPtDV8t1VpsPbNgIda/SHaC8ThJJa4E7y//q2Y7BJ9G7/k3wsL16ZA1HNvnO8gFFpo3qZtaJgkxzycTY1TGTdMuIt2xzEvQ4FW0BDAleu4Dul0uuAnGQ+sZ7ck5NsK0xV1jys2sJyLD/OgdMHoxilgA6NTQzPp1LQ53o15rJXJ2jkAXk4JAvoQZFH+WBmF26uNI/ylNYR8Ppv+pO6rYUY/nOTE3PqFiEZLudtgQ/ywsSNJo6W6/nu0+6hXizawC1vZ4F3EfNiRwcdR3HxsdMTdACPiYIHKVoyaF2Degc62sxfDIH0vMHgZqnD6v+XVFx3Y4RqS3AANYe7Hg6+M9fibpz0SORCUNlAUF55D2Soakgzqg+a1S9Z4FB579g4j0hoDfBWNT/ic8CSWRerQjKJnU4VB+TeUglo2EJnFr7dQZ8A64w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199018)(122000001)(86362001)(38100700002)(7696005)(66476007)(55016003)(316002)(54906003)(4326008)(4744005)(64756008)(66556008)(76116006)(91956017)(66446008)(8676002)(41300700001)(6916009)(33656002)(66946007)(71200400001)(52536014)(5660300002)(2906002)(8936002)(6506007)(38070700005)(478600001)(9686003)(26005)(83380400001)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8344 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 553477ec-5131-4876-484f-08db103eda87 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dFrR1E2sDcyZzWt7anELUEXCFH8QknELwZXwwAMxGhmL6UQhIUfspbB2QdjU7fXovoD/7fpy1pHZY6THDl6L7nZ6nBxXig52qdDQFOIa8vHf8znbDJ46terutj47Hw+FiyD2/4xtqLweyG6zYokJ1eZj7lm/5mLaKWRfK9+UcA70k38IPrv5s/Pt4MO/4qABhEDwWg+QrKGyei9XW0jWxX9OfCCXzobceYDLeQZZjmXt2JdHdqktf/Mmnt3SEoB0aIRZwf1i/K33juZQdCfuvEUwCzpSYVTiB8MKhFDAev1ZO1goK04Txj3QFWRqNk8fRz4je3b0iD+/1US4WqVsem4LmF1LoY1Oj1qfl4vefgCqI/42pnKfI3Z83UPJu1pUqPXhfud/w5jKJ4m164Av+3t+UP4u5quYEXFJkk83SY5oQ5734OJWhcc4uEvqg1Js18iC22P24nKdtEAYFFZQToqpPeG6ETce3mbLHBJ7Yr9Owuf1jXiz077DHEz6225FAn9HOq/m1oJEmMztgw6eNKZ8b5BJnjD2h0Ih1dc2mW0gtgS7xQv72+sGpqT2bEOxGSzGs6sDPzHNQTZkermaheAtpeKLWpUKSDALIZU83agIF9Ccr+h4EgW4M6EO+3L8S2U2W8d5mPlZigTwqKpSyyVvIBzyoZBlWA44m2GAQSJb8hFoeKRI9rQEp//WhytqycRXmN8oAItTOBNFs0SZEQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199018)(36840700001)(46966006)(40470700004)(5660300002)(356005)(81166007)(52536014)(107886003)(86362001)(478600001)(6862004)(40460700003)(316002)(54906003)(70206006)(4326008)(33656002)(7696005)(55016003)(8676002)(40480700001)(9686003)(26005)(8936002)(41300700001)(186003)(6506007)(70586007)(336012)(2906002)(36860700001)(83380400001)(4744005)(82740400003)(82310400005)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 16:57:24.7522 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a040a9a-1d65-4be8-3f50-08db103ee0c1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6250 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kito,=0A= =0A= > According to the comment in the flt-eval-method.h,=0A= > it says its mapping -1 to 2 is because it's the most conservatively=0A= > safe assumption[1],=0A= > so that's why I consider fixing that for RISC-V port only.=0A= =0A= The most conservative option would be to map -1 to 0 since that is what=0A= the undefined case already does, and this is correct on all targets (68k an= d x86=0A= have overrides that force it to 2 - IIRC s390 used to use 1 but now uses 0)= .=0A= =0A= > I am happy to send patches to update the generic flt-eval-method.h if=0A= > there are other maintainers that think it's reasonable to change the=0A= > default mapping in glibc.=0A= =0A= This bug affects almost all targets, so we want a generic fix. Mapping -1 t= o 0=0A= seems a reasonable default, but we could also decide to decouple the=0A= float_t/double_t ABI from __FLT_EVAL_METHOD__ if it is no longer treated as= =0A= a fixed value for the whole application.=0A= =0A= Cheers,=0A= Wilco=