From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: [PATCH] Benchtests: Remove simple_mem(r)chr
Date: Wed, 8 Mar 2023 10:44:42 +0000 [thread overview]
Message-ID: <PAWPR08MB89822E5EA357E7224832950683B49@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
Instead of benchmarking a slow byte oriented loops, include the optimized generic
memchr/memrchr implementation. Adjust iteration count to reduce benchmark time.
---
diff --git a/benchtests/bench-memchr.c b/benchtests/bench-memchr.c
index b99995e293f30a0ddbc68722552764b804521eb4..90bd3879e32e81950c633cf7f2d4f3f6a92d2311 100644
--- a/benchtests/bench-memchr.c
+++ b/benchtests/bench-memchr.c
@@ -16,6 +16,8 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+#include "json-lib.h"
+
#ifndef WIDE
# define SMALL_CHAR 127
#else
@@ -31,35 +33,25 @@
# endif /* WIDE */
# include "bench-string.h"
-# ifndef WIDE
-# define SIMPLE_MEMCHR simple_memchr
-# else
-# define SIMPLE_MEMCHR simple_wmemchr
-# endif /* WIDE */
+typedef void *(*proto_t) (const void *, int, size_t);
-typedef CHAR *(*proto_t) (const CHAR *, int, size_t);
-CHAR *SIMPLE_MEMCHR (const CHAR *, int, size_t);
+void *
+generic_memchr (const void *, int, size_t);
-IMPL (SIMPLE_MEMCHR, 0)
IMPL (MEMCHR, 1)
-CHAR *
-SIMPLE_MEMCHR (const CHAR *s, int c, size_t n)
-{
- while (n--)
- if (*s++ == (CHAR) c)
- return (CHAR *) s - 1;
- return NULL;
-}
+# ifndef WIDE
+IMPL (generic_memchr, 0)
+# endif
+
#endif /* !USE_AS_MEMRCHR */
-#include "json-lib.h"
static void
do_one_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s, int c,
size_t n)
{
- size_t i, iters = INNER_LOOP_ITERS_LARGE;
+ size_t i, iters = INNER_LOOP_ITERS;
timing_t start, stop, cur;
TIMING_NOW (start);
@@ -250,3 +242,15 @@ test_main (void)
}
#include <support/test-driver.c>
+
+#ifndef WIDE
+# ifndef USE_AS_MEMRCHR
+# undef MEMCHR
+# define MEMCHR generic_memchr
+# include <string/memchr.c>
+# else
+# undef MEMRCHR
+# define MEMRCHR generic_memrchr
+# include <string/memrchr.c>
+# endif
+#endif
diff --git a/benchtests/bench-memrchr.c b/benchtests/bench-memrchr.c
index 4f594ee7cdbe05c3ec4425b5d922ce2b9912b660..1f8c8845037db84ca0d4201ed991a09cdf19d57d 100644
--- a/benchtests/bench-memrchr.c
+++ b/benchtests/bench-memrchr.c
@@ -21,20 +21,12 @@
#include "bench-string.h"
typedef char *(*proto_t) (const char *, int, size_t);
-char *simple_memrchr (const char *, int, size_t);
-IMPL (simple_memrchr, 0)
-IMPL (memrchr, 1)
+void *
+generic_memrchr (const void *, int, size_t);
-char *
-simple_memrchr (const char *s, int c, size_t n)
-{
- s = s + n;
- while (n--)
- if (*--s == (char) c)
- return (char *) s;
- return NULL;
-}
+IMPL (memrchr, 1)
+IMPL (generic_memrchr, 0)
#define USE_AS_MEMRCHR
#include "bench-memchr.c"
next reply other threads:[~2023-03-08 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 10:44 Wilco Dijkstra [this message]
2023-03-08 15:18 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB89822E5EA357E7224832950683B49@PAWPR08MB8982.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).