From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2079.outbound.protection.outlook.com [40.107.241.79]) by sourceware.org (Postfix) with ESMTPS id 2B4E43858CDB for ; Thu, 23 Mar 2023 23:01:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B4E43858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h/VqLW2GGR1JxZOGnBO9adCtwOWzGyCrJ3gBQK2S1Ts=; b=qpmcm9KhPxIVVtzgjOo9Qr+O2sOs+ZUMCc0j2tzCvsxqR2iaHdZ1FBX2bcqTeUAcn8pozam7mpDevFaenN6ai4oQjpEDiDTVVkRKNzTVRBdDPLi2ACBfIXbl4Lr9nhVJMSeeELqRrRcj1JJo5hIV+rzYxSNVp+8SpnigcKFvkt4= Received: from AS9PR06CA0602.eurprd06.prod.outlook.com (2603:10a6:20b:46e::7) by DU0PR08MB8208.eurprd08.prod.outlook.com (2603:10a6:10:3b1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Thu, 23 Mar 2023 23:01:38 +0000 Received: from AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46e:cafe::c9) by AS9PR06CA0602.outlook.office365.com (2603:10a6:20b:46e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38 via Frontend Transport; Thu, 23 Mar 2023 23:01:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT044.mail.protection.outlook.com (100.127.140.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.22 via Frontend Transport; Thu, 23 Mar 2023 23:01:37 +0000 Received: ("Tessian outbound f2a8d6d66d12:v135"); Thu, 23 Mar 2023 23:01:37 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fb65a37c8c4c03d1 X-CR-MTA-TID: 64aa7808 Received: from f378f31130ce.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B7F7E385-BB94-4804-8E00-C2F236BC467E.1; Thu, 23 Mar 2023 23:01:30 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f378f31130ce.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 23 Mar 2023 23:01:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JeSm7FEKXaf//F99Fthge9Fzx/Vule/ogDAAIxrqCx/9HG1Vf6z8GfZJkln08QBkuVPFkZWcuuCofzbDz7/GflCUou/lUi2+Ph8XH4WK7GAacnFtQABAPqrei8Exgrbp5vbIfKae9xy+LsX+F03Rp/B/d5qHdcsi24ELg67euFPlbCXW7mmWOcdNnpHv6TD7YjMy1Q5Yd8E9UsyASeaZvwLOEcBka9UOTcEAYqDqfFofiDDQ5Hzao0SugvnwHGVlZqsNci4pJOqz8W+y8xnNBZrmrmQne+HzIxznIVWOcFD+yphE2qznR7mB5T4jJn2DuB2C7YgNFerm4ocenZeE+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h/VqLW2GGR1JxZOGnBO9adCtwOWzGyCrJ3gBQK2S1Ts=; b=HYWwqP5X0N32FscVaqNpyE2v3LHEjpgQth1FmQ85Bl4Lc+PPI957VpqtpJAd1RLBiOrlfWQWtUUGfIUbIrS+M8d7CqY+nW198gGvjjPc6OXHPEReCvhVbcWg6ed6ygRgGAG/8xboNMsOlzAwlA3SUsVBm3h3cX/M5t9p3JuidHnBK60QvRaM9XL8EQNigZ9J0PspakIkVV7yc4zuPdTw40bZvmPDykilCru1YkhexByzyGts2s/9DmsvHE1jf9o4AVwcRukX5nPRnvtYAaulqXG4pvxLoayJWC6egGayS4TKPVGfpoVuNROEUrOLL6U0L0Xi5tHF2DY0kwQW4+wwLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h/VqLW2GGR1JxZOGnBO9adCtwOWzGyCrJ3gBQK2S1Ts=; b=qpmcm9KhPxIVVtzgjOo9Qr+O2sOs+ZUMCc0j2tzCvsxqR2iaHdZ1FBX2bcqTeUAcn8pozam7mpDevFaenN6ai4oQjpEDiDTVVkRKNzTVRBdDPLi2ACBfIXbl4Lr9nhVJMSeeELqRrRcj1JJo5hIV+rzYxSNVp+8SpnigcKFvkt4= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by AS8PR08MB6149.eurprd08.prod.outlook.com (2603:10a6:20b:29d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Thu, 23 Mar 2023 23:01:26 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%8]) with mapi id 15.20.6178.038; Thu, 23 Mar 2023 23:01:26 +0000 From: Wilco Dijkstra To: Noah Goldstein CC: GNU C Library Subject: Re: [PATCH] Benchtests: Improve large memcpy/memset benchmarks Thread-Topic: [PATCH] Benchtests: Improve large memcpy/memset benchmarks Thread-Index: AQHZXXwQrCEeUk4amEyO3TletkUDOa8IrG6AgABG87M= Date: Thu, 23 Mar 2023 23:01:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|AS8PR08MB6149:EE_|AM7EUR03FT044:EE_|DU0PR08MB8208:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f4c54ba-ddde-42a7-b115-08db2bf28ea9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hYbCdJvOKCGanX9H0Dyb2YEUmppyEQLUMXgxMDWLRSwx3UMYeheXKlgsOueE0JHf7rVMd9sf2HyKBJb2LGa/8au16CXLPTllE0RGMhwhGRA5PJleDevzih9EYJDuaE+JrOvobImji5W4JTDp2ip/9A+9wkZkssC0LJFxYykfmKyYKvt9/xLLQcXZG6Uoi9onhMV71NnLz+7mF5OrhVDNcjglatzu6dQtP4azQqLtG9foC72sG4xOxBzFLM3DKnc7YT60AoXkSSXcjKaxtFHPx+vSamuS5/tiryA2K+KNddwnUOqoTvmrHWDKyLuQSSHf9cn5tCxa4hD9ES1boamE5AdIEg1yZ5WuSIAem5RESbmQUsmq+MbLR8xeNlmQc04DsZYZtKxjntcohX+Y+5J/U212VOGNV6mZcFg0FsYcLJ+L9HqfP86TJ6ztRFVVnr/cCQD0NsmeMWYqcYAEvXduOfTEXavNnJQNKjndqKrqWsDuRwlrQZr7iYpBh+QnwCrfd4Bp8PRfhBASGJkGRez56Ya72i9C18/90s5afJfVJakCrDSI+Yob0TCjXONFCtIldmZbuAOemiiwGGrzBL8FN+mDfdbbZMEiRHr/4gDIihyiYTW03RPzHbk8kaSdmn8EEnjDluE4o/LTxhLcxJFLMFJuEsQkjapiMkVACn/8kwIDHyu6yJjgyxJxlaQnZO0yif7itYhGz6jF2dG09zWp0g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(451199018)(86362001)(64756008)(38070700005)(33656002)(66476007)(122000001)(7696005)(38100700002)(41300700001)(4744005)(66446008)(52536014)(4326008)(2906002)(5660300002)(8676002)(6916009)(71200400001)(66556008)(8936002)(55016003)(66946007)(9686003)(186003)(6506007)(26005)(316002)(91956017)(76116006)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6149 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 12a731dd-9357-4096-55a2-08db2bf287f9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rsrRCoYKPVoeqOnaXAFdYNXA7S14MJQGtsRl4Be39aKSfyGoFhpMZEkRlV5gqjYhFehko5rLxZnYZYoUnIQakFzD+jSkteKSUx8yjelNMI0JWKoY6uSpD0qKlPC7pR9xQmVIKzZVMZjMQrq5nwLbv3WJPGb0H2/OT6gORPq8oPNKGSDwXbDxzBwqzxcsMi/8oysW6OLU1LiW4yzHbKLEs5Udk3Ad2DxU9J2+hCHGKNMPs1hgkTBdUvTBk4SUH0YAGe+uLGJLFlUqo82uJbHQ6McrWEBRIGkG3Nnn5u4zjB6xhC8mX7+MU7vz4vvoGgk3HS+Ou2VVxFSjaMwLqZZtY6pP+gpBWkzAYt4RGRZAVw0YgADRXRsg94ut7iJZpxxMhmF0QDziPvUB5MAuLGWjcB3BG/qe5nlJmIjfz94E/0lIyZMwQ0xwYp5NRgd6ifyjgcEDIACcFAe9ZdJkqcMLofTHzstCzAnhlAG0CFMTx37upEHxekM9iIOBWS+WN2qd5moPDwcNa5arAx4RiWjk8fAu1X+pgfJBZZhN6kNAP/p2eG0cVyv8IERMlfRumRlmWIPlH/7kKJVBbrURBtbnJJOqkZcRVYF8/1wLtazsY+bhVu56nBdFUeCHN+qvqkbIzCIJaY6C3yB7Ebft5p4BImK/5gK1ta9g1jFbYJ6/CGHZovUfXMcj4EoyIQ8chAmt7DYLUnnxlXdgIRxq7VLF0g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199018)(40470700004)(36840700001)(46966006)(478600001)(40460700003)(70586007)(8676002)(4326008)(4744005)(52536014)(36860700001)(70206006)(81166007)(41300700001)(5660300002)(82740400003)(8936002)(26005)(47076005)(6506007)(6862004)(336012)(9686003)(316002)(186003)(7696005)(33656002)(86362001)(82310400005)(40480700001)(356005)(55016003)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 23:01:37.7529 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f4c54ba-ddde-42a7-b115-08db2bf28ea9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8208 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Noah,=0A= =0A= =0A= >> -=A0 align &=3D 63;=0A= >=0A= > Can you replace with `align &=3D getpagesize () - 1`?=0A= =0A= Yes that would make more sense indeed.=0A= =0A= >> -=A0 if ((align + len) * sizeof (CHAR) > page_size)=0A= >> -=A0=A0=A0 return;=0A= >=0A= > Is there a reason to remove the out of bounds check?=0A= =0A= Well it can't ever go out of bounds. The allocated buffer size is=0A= 2 * page_size (ie. 4 times real page size or 2 times MIN_PAGE_SIZE=0A= due to the incorrect logic in init_sizes).=0A= =0A= And if it could go out of bounds it should be an assert so we don't=0A= silently benchmark a bounds check!=0A= =0A= >>=A0=A0=A0 align2 &=3D 4095;=0A= >=0A= > Might as well fix these up, can you replace 4095 with `getpagesize () - 1= `?=0A= =0A= Sure.=0A= =0A= >> +=A0 size_t i, iters =3D (MIN_PAGE_SIZE * 64) / n;=0A= >=0A= > this takes [.5, 10] seconds?=0A= =0A= Yes, it's only 1 GB written per test. It takes ~8.5 seconds on an old slow= =0A= Cortex-A72.=0A= =0A= Cheers,=0A= Wilco=0A= =0A= =0A=