From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2055.outbound.protection.outlook.com [40.107.14.55]) by sourceware.org (Postfix) with ESMTPS id 98FDD384B803 for ; Fri, 17 Feb 2023 17:13:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98FDD384B803 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nln+HBvbLR6oYA+UOddN7FAc0kxmIxfdfNX2IfriV4E=; b=dznjq8BUUQ3XPtV0q43CL4dBxMwIxxiy8924RiDPemEZgO0l6DFi+VRaJE14tNX0GGFO3Gpujt9+ftmDWV3WR+znTk+QV2033e6FNAhj5BrMIW3NpIWFEtp4Lnu2wQQw5ieYj2S5uxb9UAI7Ksam2+cUJQuWq+ONj7i/nq/ZnIY= Received: from AM5PR04CA0028.eurprd04.prod.outlook.com (2603:10a6:206:1::41) by DB9PR08MB7560.eurprd08.prod.outlook.com (2603:10a6:10:307::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Fri, 17 Feb 2023 17:13:52 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::fe) by AM5PR04CA0028.outlook.office365.com (2603:10a6:206:1::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15 via Frontend Transport; Fri, 17 Feb 2023 17:13:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.17 via Frontend Transport; Fri, 17 Feb 2023 17:13:52 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Fri, 17 Feb 2023 17:13:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b1005fc0d8e78438 X-CR-MTA-TID: 64aa7808 Received: from 8220f2a4226a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1D99AE14-A3F0-40B1-B5EA-113BC697055A.1; Fri, 17 Feb 2023 17:13:45 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8220f2a4226a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Feb 2023 17:13:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mq9AlhI62Ya7VIwUwOeD2iU4w6NDAD5yA+bpN5VuPCpUkvNU2FITjyFQ6vAERCfP1xgS7cIrb2zYoWi88AZNnsMBf7djZWMPYXu/8FKYRasFj7HSVV7oTuGM1QDxF8wzO8owelT3t43NMbOBig+NFqBMeUR8k+iIjsftHx+FI4R300aM0RDdDuRZC8D1VFxRYRQHrH5KPPQ4OBe5LmwuCQhfiusPReo0vUpnUwELVI5IkAixPXdEo/5FyWtC2Gi6rL0N9nYkJrxw67+SQ1v3fYtKZS8r+SSwNLeAmWPhxlez2WAGInT/2hswmr6q32k0Bp0C2QK88uocE3PuKKe9Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nln+HBvbLR6oYA+UOddN7FAc0kxmIxfdfNX2IfriV4E=; b=jDiLhkH9Uut/JSEFslYXBsl3KMWU1CMEhMZCzUaDf3EyGotCTrO5nMFFPn3iUZD11iVx9d6KF7XFC/M41mLjrih1JGd0rZzdfvuCupZz+S83l2RUcOLnrRdN9eLA26l3PWCfH0gCn0yf5hunagx+Le/WPsmiW2d9OzyjSklRYZoRNTOF6evOPXxEinCo+7nLOsATTS+tjIc33q5iOSZ0k0MJo2q+2NZzll9X3FN6aoBm3KU+9/vrM0vIZN2RwraOnXMv3KNF2U1Pj72fGG1Xl5O78g5hUMtDGFSJvOoNxN+w7wGREpzFyre1C8M2blO25JYK9Pr4ZcwuTfF54yklvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nln+HBvbLR6oYA+UOddN7FAc0kxmIxfdfNX2IfriV4E=; b=dznjq8BUUQ3XPtV0q43CL4dBxMwIxxiy8924RiDPemEZgO0l6DFi+VRaJE14tNX0GGFO3Gpujt9+ftmDWV3WR+znTk+QV2033e6FNAhj5BrMIW3NpIWFEtp4Lnu2wQQw5ieYj2S5uxb9UAI7Ksam2+cUJQuWq+ONj7i/nq/ZnIY= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by AS4PR08MB7781.eurprd08.prod.outlook.com (2603:10a6:20b:515::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Fri, 17 Feb 2023 17:13:43 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%6]) with mapi id 15.20.6086.026; Fri, 17 Feb 2023 17:13:42 +0000 From: Wilco Dijkstra To: Adhemerval Zanella Netto , "libc-alpha@sourceware.org" Subject: Re: [PATCH 2/7] stdlib: Simplify getenv Thread-Topic: [PATCH 2/7] stdlib: Simplify getenv Thread-Index: AQHZP7Lw1U/R5f74V0KbI/wP5ufA3q7QRZeegAFWGQCAAEHs0YAADp2AgAAAL2GAAA43gIABa0gc Date: Fri, 17 Feb 2023 17:13:40 +0000 Message-ID: References: <20230213135558.3328727-1-adhemerval.zanella@linaro.org> <20230213135558.3328727-3-adhemerval.zanella@linaro.org> <7d887c0c-7ab0-4057-df39-e8d671bca1d0@linaro.org> <1809ebdf-e032-c34f-f685-d6718d525c2c@linaro.org> <5bef607c-6810-9dfe-c122-2d7df7decf71@linaro.org> In-Reply-To: <5bef607c-6810-9dfe-c122-2d7df7decf71@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|AS4PR08MB7781:EE_|AM7EUR03FT032:EE_|DB9PR08MB7560:EE_ X-MS-Office365-Filtering-Correlation-Id: 2162076d-f0f4-446c-86cd-08db110a57ee x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Npb0PuVAe8nl97hBylR6FpHWpl4zkviCfhDK/7Jqo4Edno9qrVf2nCCGPmXKJggknlKMq7nsSPWu5DSJGjxzrjR8uzadxih0GtGdH3NQ9aBkR9kIwKzfTuZlXFxuAJy+2+1CF3aelypGLAHiaNH2vNb5Uv4BLoEjDzCxC6oEacFdyTlp+fV8ZmiZBVSfnYZgG0+JZJzj45TZ0Xr3vw1133i+Oz1aRDpeJIYPuIIxQYTbVymHWr+Z89GaAl4hqvEnTuXuceaAL+FdceKqo3cOvegaapnp2kiLiQdnzTgkt3QU/MAjdaf+GYC5+wxRe8beMmTCKYbUuj3juOIZ0C+BrzLOOS7En6BqGP4ngZgVRslvMWLJhsKAGaBNYvMGmfEVGExNtrlX82t9Ay3M+vibpp2rSPlY1gWXX4AcklRwSF2HcEfVfjE6Vqf58bHCqaqDR7eSc7zkw3XuK3gAVnSL1twWJX875QSiWTbzew5WK6BEszzC4o1S38Z83FUY9C1cqXN+BsScNoCwI1lsUL9LA4mmiBXAxUxLRdWb9rY8ST5iw5IhQ59VYzOAFErN5/zs8+Iy49RNhIw2D3TXtU046D1jQ3sgtScDvHjxVPGxHsvuTcSNUu94p0Xr8R8sJ1paf2hltJHLP8tRlj331UEXu5LFTXSytkcMrsHnYjWMZfDfE2KJEc5vKFesH2dxgnN9y0Emq7xKJnjfQ2vuPsO22w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199018)(55016003)(38070700005)(33656002)(558084003)(91956017)(71200400001)(6506007)(316002)(86362001)(26005)(9686003)(186003)(110136005)(8936002)(478600001)(122000001)(5660300002)(52536014)(7696005)(38100700002)(76116006)(41300700001)(66946007)(66476007)(8676002)(64756008)(2906002)(66446008)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7781 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 29cf5333-79a1-4c1e-bdd5-08db110a50d8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HW0ecral9s+geIVjfG3g6kMAFnoft9FIxflg3uvBkbSWf4zAo0a1rczZsAnD9lzTHUxeJ6EjuFOFoYSTzJ+OFfqgQCnhk730lLDtDmRFhdLfUd2ctTLilhvIZYPHExgmW78VRaCf0LJ4Biy1TXEHLtT9KRjXQekC9/REaeFy+hEmFCJX/zsULrGhcv4O5pwaRUhzcXVU3Usfxbybi3JONEDBgp/zy3Jh6St/W5kQh3vKRGo3LE7mM8W7vS+Viwsl4T2hLtWbXppUWgGRPmEhJbnVKzFYybsZKSiRcJ70cbW6nOmIjFDdbCDsEJeGaRzw1DNdwh5cSVPFCIQX5NeWyOdTe9ryS8joPQ2E2Wb5FE+HbO5tYCg+3HuaXR38k86CSgvhEKI8A9TBPt4DGJ4oB6KAauleK+jg0Bfb0VUsYTXNB6TNwJSCWhDK20JZ2RTlG0YlrcXbwfgTZgbPPjno3pZdEzcYo+tJSQTjneOMrAaasCre2pfuNpUUo2gyjJDI03fvpJIxS5m71ufHKf6Qn6BlT/HE0fu487jWmBaifiUjqt+x08P2M3prvduzH/SqW26p4orb3UuyjLE5oVoFtFTyGTY3kr/PJxe9PVgD9JqGZPz/inhlXOOvliQc3B+Z/WH1I6UTmKtHqHmxwRnBOzYIWNmCJdXzlTYOPeCQx5nVGe/K/klZpfBQTKkr17ZGxRElK3MLaG/t4P8eckn2Kg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199018)(40470700004)(36840700001)(46966006)(40480700001)(55016003)(26005)(478600001)(7696005)(36860700001)(47076005)(558084003)(356005)(86362001)(82310400005)(81166007)(82740400003)(33656002)(336012)(40460700003)(9686003)(6506007)(110136005)(5660300002)(316002)(8936002)(41300700001)(52536014)(186003)(8676002)(70206006)(70586007)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 17:13:52.5027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2162076d-f0f4-446c-86cd-08db110a57ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7560 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= > Ah ok, I see it now.=A0 Do the follow addresses the issues pointed out?= =0A= =0A= Yes that looks good to me - just one thing (as pointed out by Andreas):=0A= =0A= +=A0 size_t len =3D strlen (name);;=0A= =0A= Double semicolon. OK with that fixed.=0A= =0A= Reviewed-by: Wilco Dijkstra =0A= =0A= Cheers,=0A= Wilco=0A=