From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63]) by sourceware.org (Postfix) with ESMTPS id 0A2FF385B519 for ; Thu, 16 Mar 2023 19:15:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A2FF385B519 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6C0ZQgG2YCgQCf48oy3adRL21h6OS0rN9pkEb/+HasY=; b=RjE2toWdELe5RGbrC8OteMBcL9LpG6U6zVD1VrjEwLDAliBwf/vTihd/c+2hxUJSwmWiTl3KTjlmIGB4Ff2oLFA9vtZX+RLmQ/DR/pnmLmq6pkgFUKodETKn6I/+6aFgVlOXo18D9TrXcL3lpGRzZg4d4sdxXGTnJ0ByfqGrYoM= Received: from AM6P194CA0021.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::34) by AS2PR08MB9594.eurprd08.prod.outlook.com (2603:10a6:20b:60a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Thu, 16 Mar 2023 19:15:26 +0000 Received: from AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::7f) by AM6P194CA0021.outlook.office365.com (2603:10a6:209:90::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.31 via Frontend Transport; Thu, 16 Mar 2023 19:15:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT016.mail.protection.outlook.com (100.127.140.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6199.17 via Frontend Transport; Thu, 16 Mar 2023 19:15:25 +0000 Received: ("Tessian outbound 0df938784972:v135"); Thu, 16 Mar 2023 19:15:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 94d408b2124996ef X-CR-MTA-TID: 64aa7808 Received: from b482f893ccdd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D556D72F-ECC1-431E-81A2-4DA4A8506757.1; Thu, 16 Mar 2023 19:15:18 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b482f893ccdd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Mar 2023 19:15:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gZonJFmo5g+IXAw/7LgvQu3UeRDXU06Ic5byxBF2Qfhuk/57PmZmXNmuAH7Ufk5lVArkhfStLw1vJx6D9DIGrYxh1AENhbXDjxd0ovbmwmoG8q9Wv6FMo7H/SSeV/I27Sj/yhg4RDorajoFjZ5D2xIQigg77DYyL8S6ydsA6qJf9jKkX2dQhmMqx6yVdHhQoZNYCXbOyo5VDVLFZxRgMoiDqiPqJrz8d2qAnZc6FsqFYeiDpNPsKvwXrL/f8jVaUnSkmNcG7BRD2dOV3uc660tyDlObJNq+F7eV+P+6hco1+8O5EQ/09ahbiePbtvQAdeUdmtHv6eO9qJ/C+VhH5NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6C0ZQgG2YCgQCf48oy3adRL21h6OS0rN9pkEb/+HasY=; b=GE67tWp3tVMCNDcxl4O71aHv1uSmEVgBNKViVJD726Zddu98pnikFmr7Pe+gwFBKhMfxCGmMMz+X4Bkp7XGoMqSJYbQ4dzdMk7Wo+zxyF/Tr1g1vjErVJu6FsDcyLDuqKQ+JF9l9ZuyL/Bv/Ys47BWauyZjiBQGlQLxANtR3X6s7q7448w2+NHvZ3XXzwpmO72sbujuCZRqyfUw5Dp/gN+Ww2eMmnX1CurlJniJ0z3pwkEOC+SZRDfP4RariotPEyHIKA6BBO5cdsDw6yak/F0MZKYmmfSZK3HiPiN8ARooXQDWUnQ3c6+LnJsFYittoiPqZXUjRnCwxGYIL6ZhE+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6C0ZQgG2YCgQCf48oy3adRL21h6OS0rN9pkEb/+HasY=; b=RjE2toWdELe5RGbrC8OteMBcL9LpG6U6zVD1VrjEwLDAliBwf/vTihd/c+2hxUJSwmWiTl3KTjlmIGB4Ff2oLFA9vtZX+RLmQ/DR/pnmLmq6pkgFUKodETKn6I/+6aFgVlOXo18D9TrXcL3lpGRzZg4d4sdxXGTnJ0ByfqGrYoM= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by DB9PR08MB9540.eurprd08.prod.outlook.com (2603:10a6:10:451::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Thu, 16 Mar 2023 19:15:06 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%7]) with mapi id 15.20.6178.030; Thu, 16 Mar 2023 19:15:06 +0000 From: Wilco Dijkstra To: Adhemerval Zanella Netto , "libc-alpha@sourceware.org" , "H . J . Lu" CC: kirill Subject: Re: [PATCH v2 4/5] math: Improve fmodf Thread-Topic: [PATCH v2 4/5] math: Improve fmodf Thread-Index: AQHZV4ENjwLxBAoRq02fdqgV7KhxJK79qKXigAAVdoCAAAcU0A== Date: Thu, 16 Mar 2023 19:15:06 +0000 Message-ID: References: <20230315205910.4120377-1-adhemerval.zanella@linaro.org> <20230315205910.4120377-5-adhemerval.zanella@linaro.org> <3d3ff2cd-2187-8b54-cb4d-bbf6d9c7ed88@linaro.org> In-Reply-To: <3d3ff2cd-2187-8b54-cb4d-bbf6d9c7ed88@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|DB9PR08MB9540:EE_|AM7EUR03FT016:EE_|AS2PR08MB9594:EE_ X-MS-Office365-Filtering-Correlation-Id: c1946bb3-8aed-42d9-f866-08db2652cbcc x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Zh8aURZfMrt7pquXLRUlPg3RotKe96e2EQomQ0iZTI09/ALAnEYcwXLrnW3qKLRS8YuPwZ0+u0UvFTaogBqqlyo7bMPDcOpmaBpsmjlR7hM5quPJ9/vFF9HuHhshWMfAIgQt1HlfUKe+8fhgNh9vDrHzHjYPY47dEk4XLeEKX7YB1mqK9zcFnhLIC5Nom91s3WGibjU8FyqUzZfbmYxCKS/R5pal1hGiU/EDcqMh28f7jPEnO1RUATH+W5+FC+wE/4gMpdPHTCGMYJu2ieqxaTNBz3sdvlvYo0+h2I3fwXSU8jmU0O4kGf9F7v8daL6zpvnzBZSm1nm5EWsplPr7eaer+5updQbvCZkubXIgy+tZafdGM/puqU5e4d5S2K/ozXXkKhL04KRxSYhaucTnXv9X9uQvVxa7hwu3uUMfg6+LH/Pf9GXp0ebgMlQpu2qI+3+YSA0W+o8vspywqznRGzqcwcyqjNMNW5kVStufqca9RlmgOWZq+abNIH66Cdr+ZlMPJfXo/OBNrpdM22hzxDAWtUOklO5Qp1gyCoANdlvkkaJE8sZ62lLlhyllnSbgkh4AtpYaFndt9h5HskZSfLy6TF95K2QfQs7yhXRcO9LoSaEbyGv+IO8MYLxBWa+5MaFSZ+5gRWidGh+1QxDIhf5lJqlpJIgVuPqpx112TdzwoknwkYWtw4DNBycna/jfAL3xmXhE6Amhj4R8EGygxg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199018)(4744005)(52536014)(8936002)(5660300002)(41300700001)(2906002)(38070700005)(38100700002)(86362001)(33656002)(122000001)(478600001)(66556008)(76116006)(64756008)(66476007)(8676002)(66446008)(91956017)(55016003)(66946007)(71200400001)(4326008)(26005)(7696005)(316002)(9686003)(6506007)(186003)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9540 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7a69518f-91d0-4ac5-db0c-08db2652c070 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qn5QbO4xvdjpAtfNdrdAVzIZ8Ssof5pDpJDGPVzQEtCy042SmCMUqZhm0ai/Zjrj8KNb/cBbOHEzVw1H1ozok3G63frK+AHdGQx7EcmV9zID8yf5Xoi46LAbSlC+2kQwTeXbxGPzPhlykAdhUjjT3xhdZf9gsxc+3r8XRSnbdNIePoFfo4yiL9kGvy/fOvp5KEp28hnxCelJf3eMsNWCQuGo3OEM2nba5fODwhPIWhfi5GBQvoDfZsbYgIu0+KZ1nO36mfrlG+vPEk9xYG2pwGzX0FWgj2gtbsEv+mGaCqoOCRti0WKmFeOCWl7QId3R+NU4GI5JusrX/Brs8WFjmV377i/efdvAQMVJrO8p62U4YhBHx4uyAfVc/1LmMBvihVAwPkWT4caiHTzNpcZ6g/LDdM6f4UwOmtda3TGl1s7k0glNXrkb4aC1yHElOOV0yuTrfLeNrjgEMYNLf3XGl8y1Jf+WTSeIi9CjDI1Enw1LZps50EfuVKk+j5CCJkYgdd0qxA9Nu0oDxokbfKXmpf97a2DSSxWX+8HnodbnW+Qq5sSBrjr2rRQY4UXlP5tb6hFDimiGhS29Ra8exwd37HgXujD5hSEubAc2bgZkbHjZ2Vplgf5tTpEZeDt+QKBf/s5TYfbG4gUm8+bRiUUakFnw43UbR/z+Es1k6RpKB5HUKGl00821a/IF61Xl2QgfphM0dtdEyebsLCsRpuDR0RvIswr0zbjGCo2fZLZBN8Q= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199018)(40470700004)(46966006)(36840700001)(81166007)(82740400003)(33656002)(86362001)(82310400005)(356005)(26005)(47076005)(336012)(36860700001)(6506007)(186003)(478600001)(9686003)(7696005)(107886003)(70586007)(4326008)(70206006)(8676002)(41300700001)(110136005)(5660300002)(4744005)(316002)(2906002)(55016003)(40480700001)(8936002)(52536014)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 19:15:25.0969 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1946bb3-8aed-42d9-f866-08db2652cbcc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9594 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= >> So we do need to handle zero case here, I think fmodf (5, 1) will now=0A= >> return 0.5... We could add support in make_float (see below).=0A= >=0A= > Ok, although at least for fmodf (5, 1) current algorithm does return 0.= =0A= =0A= Try printing with %a, on AArch64 it shows 0x1p-25 (ie. 0.5 * 1p-24 from=0A= passing ey-1 to make_float and CLZ (0) - 8 =3D=3D 32 - 8).=0A= =0A= Again odd no testcase caught it...=0A= =0A= Cheers,=0A= Wilco=