public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] AArch64: Check kernel version for SVE ifuncs
Date: Wed, 13 Mar 2024 20:44:31 +0000	[thread overview]
Message-ID: <PAWPR08MB89827CBAA4157047C2FECEEC832A2@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CA+=Sn1=E26YmZfssP7hDbObAm0cNNn07pBWugOD3pu4Or7ga7A@mail.gmail.com>

Hi Andrew,

> Does it make sense to check prefer_sve_ifuncs before checking IS_A64FX
> because this is about the use of SVE registers and the kernel version
> and the a64fx versions use SVE too?
>
> That is doing:
> if (!prefer_sve_ifuncs)
>   return __memcpy_generic;
> if (IS_A64FX (midr))
>   return __memcpy_a64fx;
> return __memcpy_sve;

The A64FX memcpy shows a major speedup due to the very wide SVE registers. It runs
floating point code, not general purpose server code. Since the benefit of SVE is larger
and the likelihood of system calls far lower, there is no reason to change the default
for A64FX.

Cheers,
Wilco

  reply	other threads:[~2024-03-13 20:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 14:31 Wilco Dijkstra
2024-03-13 18:12 ` Adhemerval Zanella Netto
2024-03-13 19:25   ` Szabolcs Nagy
2024-03-13 19:55     ` Adhemerval Zanella Netto
2024-03-14  8:35       ` Szabolcs Nagy
2024-03-14 13:47         ` Adhemerval Zanella Netto
2024-03-14 14:26           ` Szabolcs Nagy
2024-03-14 14:28             ` Adhemerval Zanella Netto
2024-03-14  9:02       ` Florian Weimer
2024-03-13 18:39 ` Szabolcs Nagy
2024-03-13 19:31 ` Andrew Pinski
2024-03-13 20:44   ` Wilco Dijkstra [this message]
2024-03-14  9:06 ` Florian Weimer
2024-03-14 14:42   ` Wilco Dijkstra
2024-03-14 14:55     ` Florian Weimer
2024-03-14 15:38       ` Wilco Dijkstra
2024-03-14 16:52         ` Florian Weimer
2024-03-18 11:46           ` Florian Weimer
2024-03-18 14:22             ` Wilco Dijkstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAWPR08MB89827CBAA4157047C2FECEEC832A2@PAWPR08MB8982.eurprd08.prod.outlook.com \
    --to=wilco.dijkstra@arm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).