From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: "k4lizen@proton.me" <k4lizen@proton.me>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] malloc: send freed small chunks to smallbin
Date: Mon, 21 Oct 2024 17:19:18 +0000 [thread overview]
Message-ID: <PAWPR08MB89828BA5588939630028B6CC83432@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
Hi,
> I didn't ping this for a bit because the benchmarks are relatively unimpressive,
> but I did spend quite a bit of time on them so I figure I'd like some feedback nonetheless.
It does appear to be faster overall, I see a ~0.5-1.0% speedup on xalancbmk, so
I think it is worth it.
The patch looks good, the main issue is the formatting appears off for most
comments and malloc_printerr uses - perhaps tabs got replaced by 4 spaces?
> Large chunks get added to the unsorted bin since
> sorting them takes time, for small chunks the
> benefit of adding them to the unsorted bin is
> non-existant, actually hurting performance.
Agreed, it makes sense to place them directly into the small bins. It does not
affect anything else since you literally bypass the code in _int_malloc that scans
the unsorted bins and places blocks back into the right bins.
> Splitting and malloc_consolidate still add small
> chunks to unsorted, but we can hint the compiler
> that that is a relatively rare occurance.
> Benchmarking shows this to be consistently good.
I guess this could be improved separately - splitting could be smarter and
avoid fragmenting large blocks into smaller ones. And consolidation should
avoid throwing all fastbin blocks into the unsorted bin and then move them
back again in the next malloc.
> @@ -4156,9 +4156,9 @@ _int_malloc (mstate av, size_t bytes)
> #endif
> }
>
> - /* place chunk in bin */
> -
> - if (in_smallbin_range (size))
> + /* Place chunk in bin. Only malloc_consolidate() and splitting can put
> + small chunks into the unsorted bin. */
> + if (__glibc_unlikely (in_smallbin_range (size)))
Is it worth doing the same as for int_free and handle the large case first?
Note the formatting is off, perhaps due to replacing tabs?
Minor nit: use 2 spaces after a '.' in comments.
> @@ -4723,23 +4723,45 @@ _int_free_create_chunk (mstate av, mchunkptr p, INTERNAL_SIZE_T size,
> } else
> clear_inuse_bit_at_offset(nextchunk, 0);
>
> - /*
> - Place the chunk in unsorted chunk list. Chunks are
> - not placed into regular bins until after they have
> - been given one chance to be used in malloc.
> - */
> + mchunkptr bck, fwd;
>
> - mchunkptr bck = unsorted_chunks (av);
> - mchunkptr fwd = bck->fd;
> - if (__glibc_unlikely (fwd->bk != bck))
> - malloc_printerr ("free(): corrupted unsorted chunks");
> - p->fd = fwd;
> + if(!in_smallbin_range (size))
Nit: space before '('.
> + {
> + /*
> + Place large chunks in unsorted chunk list. Large chunks are
> + not placed into regular bins until after they have
> + been given one chance to be used in malloc.
> +
> + This branch is first in the if-statement to help branch
> + prediction on consecutive adjacent frees.
> + */
Formatting again... Also the /* and */ can be on the same line as the comment.
> +
> + bck = unsorted_chunks (av);
> + fwd = bck->fd;
> + if (__glibc_unlikely (fwd->bk != bck))
> + malloc_printerr ("free(): corrupted unsorted chunks");
Formatting
> + p->fd_nextsize = NULL;
> + p->bk_nextsize = NULL;
> + }
> + else
> + {
> + /*
> + Place small chunks directly in their smallbin, so they
> + don't pollute the unsorted bin.
> + */
Formatting
> +
> + int chunk_index = smallbin_index (size);
> + bck = bin_at (av, chunk_index);
> + fwd = bck->fd;
> +
> + if (__glibc_unlikely (fwd->bk != bck))
> + malloc_printerr ("free(): chunks in smallbin corrupted");
Formatting
Cheers,
Wilco
next reply other threads:[~2024-10-21 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 17:19 Wilco Dijkstra [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-08 5:39 k4lizen
2024-07-08 5:51 ` k4lizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB89828BA5588939630028B6CC83432@PAWPR08MB8982.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=k4lizen@proton.me \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).