From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2088.outbound.protection.outlook.com [40.107.22.88]) by sourceware.org (Postfix) with ESMTPS id D54523858418 for ; Tue, 3 Oct 2023 10:44:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D54523858418 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VtWvr/Y0yrcLmUhOc1OVSedZKzn+35x1mRexM0urPqg=; b=TA9/x0Rnkdzk4Ii+PLd86Z4AmFeAD+wPhYRMmzTz+sbS+boiVcarvERDx5tbnJQhOVafiWqVKd8EUVnOSVPs525KH9oT2CTh0pRYqIQuXeYp1KkO1n53OYAQibl9hiNHQBYKQ0ltgxvzskxZipzaMP4iz92GcjLYY1/dxEwt0+4= Received: from DUZPR01CA0128.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::21) by DB3PR08MB10334.eurprd08.prod.outlook.com (2603:10a6:10:43e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.29; Tue, 3 Oct 2023 10:44:44 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bc::4) by DUZPR01CA0128.outlook.office365.com (2603:10a6:10:4bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33 via Frontend Transport; Tue, 3 Oct 2023 10:44:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.21 via Frontend Transport; Tue, 3 Oct 2023 10:44:44 +0000 Received: ("Tessian outbound d219f9a4f5c9:v211"); Tue, 03 Oct 2023 10:44:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dbd7a9c542146e0f X-CR-MTA-TID: 64aa7808 Received: from ff30a0664bb1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 695A94A5-25B6-4231-824C-4D7E4E421C64.1; Tue, 03 Oct 2023 10:44:38 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff30a0664bb1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Oct 2023 10:44:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HsmEieCK7siTrTDssNZP8dtwKcJiFJA1mWx21GRyx1HzeK7HJu5bxj2YZyiEb7HTsi9N/l4IpyxIr3tsD+6lfnb0EfVhs4IZq36+x1TaZPcbeh7jKlX4H0J29cdHELsdcVntq5wKdpTAc1BG8RkRdc0JaL0vfIlFZyJCnRtFNxf3xrR6egZ/ES+4F5PHORlN74XoGos70/ESZ83Sfx2VXBVNFaelU2OENWBzIIzramk7FP4QnUUh0gormj9FgPL1QTdXAXFWw3s5EAJ8ftmIe/0PaSdLzeiJmQmRALfb9rqWmtxRPbEi+dkGKBJ1inDL17taeXbcQt1/Y7njdn8r2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VtWvr/Y0yrcLmUhOc1OVSedZKzn+35x1mRexM0urPqg=; b=Qqfc/P/jFvm0ph0w9QuJK8Om4q0MWuN36ZinCOXLZltHDFkZsGR4+w/gbCJIPyfn60B2z7toumrAtkGhU7HjqJRehi7+IBpmgYrG7Eab1yTzxNq0iDqG10CtPb073QFnLVJ0rvsOKoWJRA/3g2pzfwGVkrRVsnvVbq4oNvnPw2sB1Yyu2fZUl/8I1kGjzB2t+65i5Xr1C1u9DF/2kY6k6zXuZGtxQHJomZswtJYRpOYN2uWD2GpULlmSnYI28fuMUUYSEjqrUBPoh+Y5iDsAPp5c53IJ66nCaCTplYZ/J72e1vXWL0L5LN9BJdjnQC1jvTLu8xg1YJ0THOkopNlS1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VtWvr/Y0yrcLmUhOc1OVSedZKzn+35x1mRexM0urPqg=; b=TA9/x0Rnkdzk4Ii+PLd86Z4AmFeAD+wPhYRMmzTz+sbS+boiVcarvERDx5tbnJQhOVafiWqVKd8EUVnOSVPs525KH9oT2CTh0pRYqIQuXeYp1KkO1n53OYAQibl9hiNHQBYKQ0ltgxvzskxZipzaMP4iz92GcjLYY1/dxEwt0+4= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by AM9PR08MB6035.eurprd08.prod.outlook.com (2603:10a6:20b:2d9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Tue, 3 Oct 2023 10:44:35 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::ff3d:6e95:9971:a7e]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::ff3d:6e95:9971:a7e%5]) with mapi id 15.20.6838.030; Tue, 3 Oct 2023 10:44:34 +0000 From: Wilco Dijkstra To: Xi Ruoyao , "tirtajames45@gmail.com" CC: 'GNU C Library' Subject: [PATCH] ftw.c: Use unlikely for unlikely taken branches such that taken ones are placed closer Thread-Topic: [PATCH] ftw.c: Use unlikely for unlikely taken branches such that taken ones are placed closer Thread-Index: AQHZ9eRNz59dA8mfEk+cGLVw62XGXg== Date: Tue, 3 Oct 2023 10:44:34 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|AM9PR08MB6035:EE_|DBAEUR03FT051:EE_|DB3PR08MB10334:EE_ X-MS-Office365-Filtering-Correlation-Id: 04640d75-9d31-40f4-967a-08dbc3fdc1b9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Sy3GUQZuyw181iEBjnqDg+oDL9/PiCQKvDcR9LmEZLmpLDtrUaxcAM1MriKfk+p8UkjyogRLgi+jlNUOCAS9keO0SdRu4qDHIGGXu9l9fC7xAOwm6pLpfr58ag6xk0u+6s26dyXtJQk4LuvJ4iSeWt6J9qV2+0BbEHdX0eCHAAPdmiU0ogawMffFINRpyYKeOHa/GfVCFoeuK8IJA8xvkPmE0pboCJYlz/BjYIU0COyHneYDpoYq7J9CK72WWnPDeFTFazRGdEfVKFEIiZ2WPAUH2gdGoHMhFwEEQGw8aJOgxBBtXPK+XpIwJZzE81wVaDkMXVLNO3cS0lCM9lckjCbgDVyqeQHWimhLuWGx3jxZnTa+oNvrdhu1LQjNpUHeXhFEiU9KRFqELlKV/3vKfkvYLP54fXTE/vMtz6fT8XPKg+6tFdhjbA4cYzpudM6iz2zES84FE5AXWASyyS5pvOsIxQ/X2Le2rCvzxfuj6FjshKjd/ilz+6XlxUE+YWndjPiECwvtnxK/evDH9iib8O84Ak8dkettepT5donKAkHzRn5UhTrVYl76ddGSG+JRLMaKx98py2zYMa2mqUXbpuw91fYBBKj+xRUPyewrQuwO7MQCM9Z6rMvx3vYSqypC X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(39860400002)(366004)(376002)(396003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(5660300002)(122000001)(4326008)(8936002)(8676002)(52536014)(86362001)(33656002)(4744005)(2906002)(91956017)(41300700001)(26005)(76116006)(316002)(66946007)(55016003)(9686003)(110136005)(7696005)(6506007)(38070700005)(38100700002)(66476007)(66556008)(64756008)(66446008)(478600001)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6035 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25e65533-c96b-4f0e-b39d-08dbc3fdbbc3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bt+jgguGyBTiiyuWOpNxfIShnfWhgyF3yUHNgHbQSOhQ3Bve4p+u2k64ul5dsu6DblafBFyVuhWwQBo/YX9+XSFekqOrF7Ip4/G2R5Ucggh7hlo94snBM9vp1B49wjY9jMcVZJjKAVUStqf1+0tWlGy0WMBQ2BUH6Gi1fGe8iA7AO5VOY8GsybGOSX15KILJXB9V4QkaGxzOnh5bxIocCwFyiMEKawhPfdTypeNqtLdOR40eh1Vj4G3Dmq5p8xVaAWdXpBqOAJwL4X/NKn1rcM5rFTF1bGUtc1JILm3W/jTHc5oMhmf+2FbInSmHdgNl/LNORUgnRQQNPnZkOaYBvILoabmUCblqBVKGzR9IFuZDpepuoVyVMN2ig+NkXvzrLFHWjy6wl2gkm0IwyAeuQ2PKxVOykQro2nhrMwP48MOdLF37DBNNZHDxo5PWtngjJwSfuCXsOEZsRdYIpVxSeZSIeozYwzPvZ1e9ZMcZ0roVNkxYfTAUkcATifMMGGSVcH0yY3gxGiiptnrXq9vejP96BoXJ8jMvIfONypCXmSHDSCtQt8bY68/UmAOt8DCGnksMoFGHGMMzMjPlZNv4RgYR9sHak/ed7tcB064daYzVbeLCL50OccFPuWXLjPcoiExgW5kmpgaudMmOeiFoQMz++5HXxTV75KydZeD/E1SrgG55F1fyMOfXHgSoR6VrxdKL7QXKkgcmXkocpg5BBimQYPOpFnAY472PsPrV1y5tb3o9svTpxU7meHFW/MB6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(39850400004)(396003)(376002)(346002)(136003)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(82310400011)(40470700004)(36840700001)(46966006)(40480700001)(40460700003)(55016003)(52536014)(82740400003)(4744005)(81166007)(70586007)(70206006)(478600001)(356005)(316002)(110136005)(2906002)(8936002)(86362001)(4326008)(336012)(36860700001)(7696005)(6506007)(8676002)(26005)(9686003)(47076005)(41300700001)(5660300002)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 10:44:44.7208 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04640d75-9d31-40f4-967a-08dbc3fdc1b9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB10334 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi,=0A= =0A= > @@ -298,12 +298,12 @@ open_dir_stream (int *dfdp, struct ftw_data *data, = struct dir_data *dirp)=0A= > while ((d =3D __readdir64 (st)) !=3D NULL)=0A= > {=0A= > size_t this_len =3D NAMLEN (d);=0A= > - if (actsize + this_len + 2 >=3D bufsize)=0A= > + if (glibc_unlikely(actsize + this_len + 2 >=3D bufsize))=0A= =0A= > It seems only this one might be mispredicted by GCC. But there should=0A= > be a white space between "glibc_unlikely" and "(". And should it be=0A= > "__glibc_unlikely"=0A= =0A= If GCC's static predictor gets this case wrong, it should be reported as a = bug.=0A= An if-statement containing a call should get lower probability in a loop -= =0A= the call to realloc implies a rare case to increase buffer space.=0A= =0A= Note we should use __glibc_unlikely only in performance critical code, not = in=0A= code like this.=0A= =0A= Cheers,=0A= Wilco=0A= =0A=