From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2073.outbound.protection.outlook.com [40.107.247.73]) by sourceware.org (Postfix) with ESMTPS id 5914D3858C52 for ; Thu, 2 Feb 2023 19:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5914D3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1xdsmd7GVyEhCVhxLlUKEKPetEMAIzmX9UMr4Tb2kU=; b=cy5c6IALupmz0/O4eKleXi1eFdIh45XVNEFuxwrJOegnwnx7QZXykC1atigZ44hUoNYaONE0+EEkm/UVCxz08IQkwk9aCDPPYehsF4ygt8GxSpu1ALZ360sY8ek600lh5EnZFNuQ4gyiIms2R8hfMcnbvmstir38zTYUp40nBQI= Received: from DBBPR09CA0013.eurprd09.prod.outlook.com (2603:10a6:10:c0::25) by PAVPR08MB9089.eurprd08.prod.outlook.com (2603:10a6:102:32a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 19:54:11 +0000 Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::12) by DBBPR09CA0013.outlook.office365.com (2603:10a6:10:c0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 19:54:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28 via Frontend Transport; Thu, 2 Feb 2023 19:54:11 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Thu, 02 Feb 2023 19:54:11 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 145c72cc8b181fcc X-CR-MTA-TID: 64aa7808 Received: from 8057eec96c49.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3C4553C3-CEB7-4F9E-80D2-F89BF7F868B5.1; Thu, 02 Feb 2023 19:54:04 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8057eec96c49.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Feb 2023 19:54:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QoR/GPOFOrG0x7yioYi2S4nE28BgsRztn1npTnx+U5CwnemFC8H7C8RgecZ9ryu4DAhQqKPBEQOrcaxHR1aguT3po8Lku0gl2OZISwDVNt9TUTRDeGnpAPeQPowAoMvMv1/GTw1ZYUT+pCID7+q+w2tTV3q0NRVh6NJCyoRPj23zoCutyLjXZkEh6aBOMOp+GlnqpMpYuDuPPRU25YIiTqc9bLw8oW9ACnRkUhtzinZI2OWt7455VnLpubwSzkEu4QF5Y7y1z7aSJjIYQFcb3T0K3/LO6b+CVCzV2XiZtcCGKYXfP8JgdYWM4kZet1+LYKI+Cb/pfX+pTgc7aYWVWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1xdsmd7GVyEhCVhxLlUKEKPetEMAIzmX9UMr4Tb2kU=; b=M3q0Nu4S/wNgxIeoYm+lOFe7/rZlxCUtm5TNZqd6+Saefmq4/89bwJipCH4pDhrK3Q3U9Ub9uwKRxE/9yeszWXiQbfnM0mK7+6LZOWvvdOgXcimZE3r6S7QG2hU3SaNSwlXf16N2/q+eCqW2KKPBQBrWkzbZvm1xesoyvjWbNPL7eH7OkgONt9Jznu3ohHkBYTcEVJyZqFOIB+R3gKmynwCGfdll/65Y1y92ZsEO1R+8QlTvF6xVnhK8hlR5qaXvaJ+cSHq7JW5WIuJU3DUe513p/2M1Mv/X6/kQAF2cA4e7I48L27RYTgx0ZWjycEH19XxDUmeDxsfE+hitt0oWWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1xdsmd7GVyEhCVhxLlUKEKPetEMAIzmX9UMr4Tb2kU=; b=cy5c6IALupmz0/O4eKleXi1eFdIh45XVNEFuxwrJOegnwnx7QZXykC1atigZ44hUoNYaONE0+EEkm/UVCxz08IQkwk9aCDPPYehsF4ygt8GxSpu1ALZ360sY8ek600lh5EnZFNuQ4gyiIms2R8hfMcnbvmstir38zTYUp40nBQI= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by GV1PR08MB8332.eurprd08.prod.outlook.com (2603:10a6:150:87::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Thu, 2 Feb 2023 19:54:02 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%8]) with mapi id 15.20.6064.024; Thu, 2 Feb 2023 19:54:01 +0000 From: Wilco Dijkstra To: Adhemerval Zanella CC: 'GNU C Library' Subject: [PATCH v12 14/31] string: Improve generic strrchr with memrchr and strlen Thread-Topic: [PATCH v12 14/31] string: Improve generic strrchr with memrchr and strlen Thread-Index: AQHZNzutbBDGngAKCEqj8sOkD69D9Q== Date: Thu, 2 Feb 2023 19:54:01 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|GV1PR08MB8332:EE_|DBAEUR03FT050:EE_|PAVPR08MB9089:EE_ X-MS-Office365-Filtering-Correlation-Id: 19fa2143-692a-4521-eed6-08db0557412a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: t8q5Ot53Os3g/2hcGkd1FoqhhKRujmuUwwIjyt1uiBlSXnDsIai8HMPfZO2fyuQZM3Zcy0YFNLm7o+/LmOuPTXzdvtaondU1He8jCKoS2BU/0jhqgWYY37Xej7lG9qGMeYaO3svYUgLRy47UqkiUT6pyYqdv4dGXzru1SE9cfOOXljV2sIRTuCXqWIrlxKSp7AC5tRFSsAdnbNgLB8Ro8P46y1aBy8wGkkuPAfDcuVTGee1C3KMAsXWtvslDrJsEZFTn513LoEEyP2HdCU1QXkw4Cf47ddPsHHhf9mRknK+Lij3bDgRFjjm8JPnimICC/Qhx/p+QIBHx0iO7O8t8XdfuEP9ANaGUaZOt735jtxfeKhroYAfkZcWBMPBrzEaNwbRO3kZQ3+V3j5gLdhgc4M8Q4aHRdkOmSeGzu01DTZHtHEVi9aI8LnvUbGLZRI38lNICpQn9WDwUiDOP1BYX+ZWIimE684thc2y+kFm3Z3bc57sJY4VOrMmmwhDCashnGBxA2sR+C0GevxMmYgxrkalLxPIB8CeOnbB7Lqn/j5RBeRbF9igPkY4UkHSCf7YXw/JZG2354mAcwIffZA0JyTJr3PoSR7VTGCSjLuqczY3CYWXCrqm4P88twj5h5tMIYDU5oFQEl8I4fnWfG6Bs5I5yGqi1bD5NnkUvThrBsAXlCmXggval+6QqdbQC1elP97YT0Dl0o5kpdhX/Kxp2VJASDJOSNRSZj1psEeSzqvk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(451199018)(2906002)(71200400001)(7696005)(316002)(83380400001)(33656002)(122000001)(38100700002)(186003)(26005)(66476007)(76116006)(6506007)(6916009)(64756008)(66556008)(9686003)(91956017)(55016003)(52536014)(38070700005)(8936002)(66446008)(86362001)(41300700001)(5660300002)(8676002)(66946007)(478600001)(4744005)(4326008)(41533002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8332 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eb47b761-906e-4686-6579-08db05573b13 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gaZw0LP0Z8Ao1KjNLrnQ6CqroTyGLCE+3Tm2Qved2aKR96RJ4SK9PK47D/J3OaXmwY4E2uakILCREdaf8n+FAutCoOagIJeQWs1XardtNVSdyM2fgbduyBOLZdVKRtx4u1GSWKaIkuvdKcXeImfAsB+hvh+lCcgR7rSKAYCD+NyOHHB2BH/Et6cZHwIkb5XIOQhMVMIlyCZuLlHht/flMzxIx4B2AOecM8Gvr1eIT7KpMAebYTMYn7uAuQEmY3KvU4a1SPSDa/GbdgBPvsFHW82FiDpDI98dD61IvZC32swFr7FsYQGzKK6C2Hezf5KIWh2Y3QVZgKYSukB3GlVtCZ9ewm2IJZ/jQCnpEBvYkvTnT/lEOTP3O3fsdNHt3HCphTIrP2ZyJ/347NyYbsThg4jivH4A0C/iKRTjjC8YzrC+11ojM9mhFEPf+3Wkb2EPFpnYXa6n9Ehra5xiZK0mDDcWaNbB9PMdx1y/2NON+Gq/5rogRsmbsfglr/fagi5VS52a4xQmuwvGTnXg+Z1A7XYFRn9O3d6Xe/hqwPQ7H7SUEsZRgUOe2+Y2vAFPULO7jcdjwxnGGCs+AjmOn/Z+ICZFn/OEadeRFFzsC7wM9jEmp9nuDoy+g190tJHt6f6KuC5pzL3nsDSPtiS4oca+kgXPEBAGMJeDofJSAmUT3Mn8r3t2lffZh9eez5kNVy0UpNwXd6v+pEmT27WL7Qp7iYYKuG0EeLHnFYqWFLEoW2o= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(36860700001)(186003)(6506007)(83380400001)(26005)(52536014)(82740400003)(356005)(40480700001)(33656002)(55016003)(81166007)(47076005)(86362001)(82310400005)(6862004)(40460700003)(336012)(8936002)(41300700001)(5660300002)(9686003)(4744005)(2906002)(478600001)(7696005)(8676002)(316002)(4326008)(70206006)(70586007)(41533002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 19:54:11.6683 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19fa2143-692a-4521-eed6-08db0557412a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9089 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= STRRCHR (const char *s, int c)=0A= {=0A= + return __memrchr (s, c, strlen (s) + 1);=0A= }=0A= =0A= LGTM=0A= =0A= I did a quick check on AArch64 and the speedup vs the old generic version= =0A= on bench-strrchr is 9.9 times! It's ~15% slower overall than the assembler= =0A= strrchr.=0A= =0A= While the benchmark is not perfect, it shows that if you have decent strlen= =0A= and memrchr then strlen+memchr gives a competitive strrchr.=0A= =0A= Cheers,=0A= Wilco=