From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2047.outbound.protection.outlook.com [40.107.13.47]) by sourceware.org (Postfix) with ESMTPS id A907838582BE for ; Thu, 9 Mar 2023 19:38:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A907838582BE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=coVX0XyE1mnRFgfGSKzxuYjwEGMWj/hFCGR6hK0LA4c=; b=nuvsrY+UPGMRC8zkX6w7micgyYA7cQIkxnIPVg+iBJsA+LAgvh0lYRdU8CWv/e2wFQVNDhYwTVEToWUIYiYGusXxdbQ3xFKMOlqAVGI4XDtgtfHjg6aKVYdmegdoPQ5qF6yp0EUwlqSaaH6AUTIm9p/gElWEi6ZFzDOyHPsC12E= Received: from AS9PR06CA0745.eurprd06.prod.outlook.com (2603:10a6:20b:487::33) by AM9PR08MB6226.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Thu, 9 Mar 2023 19:38:12 +0000 Received: from VI1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:487:cafe::6c) by AS9PR06CA0745.outlook.office365.com (2603:10a6:20b:487::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19 via Frontend Transport; Thu, 9 Mar 2023 19:38:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT054.mail.protection.outlook.com (100.127.144.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19 via Frontend Transport; Thu, 9 Mar 2023 19:38:12 +0000 Received: ("Tessian outbound f2a8d6d66d12:v135"); Thu, 09 Mar 2023 19:38:11 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5e2c4ba3770c9626 X-CR-MTA-TID: 64aa7808 Received: from 8fc12b201695.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5DADD8A0-74F2-4141-AA4F-1347A947E25D.1; Thu, 09 Mar 2023 19:38:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8fc12b201695.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Mar 2023 19:38:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VeYwLjD20H0VMdDqJpf4cUnA+afdtjf85Ctvky0TgnoiKrpQAQLrVFxlfqOKoe2Tcm92OcaLBYbsup0uXdAvozMtJoMkt+o+YvgfHJdoWx1tuNEycaZt6qgXq94WVC5Yrwo9For7jUw0s8r64vK+5fJKyysCuCsGRCW8mRlGr6TjHHL/purGxlAvvl/G+2nhW1afg0QN1uAwD8QrF26RrttjxmEQzS9V6NQI1NND3sbiAaQPYAyi45r0wfxyilllBLDwmLfNMqbRJ4HlE+KZkFO/tTXeUF5y+b0fokZyeSyR8x3daWRwOnCWfokCeJudizmcjsxsmqdSxOimo0z+xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=coVX0XyE1mnRFgfGSKzxuYjwEGMWj/hFCGR6hK0LA4c=; b=aLPa5hOxrMfZ6708xM0bTff8MphDM+BRolPXT9MAbnaLTYWmK+xvctZmEE/tdhOh//4Wa73Dy5iJKEWnOffEgjVvjWUs3J4PFkXKtYnvWyF1bA/L7YdAy6zLxs4gnOq0/JI4NU35QPlrIGA4aBLv529c8M87DgUxADEqSNa2RsQ8lTCOVZdFpPyihrrJ3xJKy1gp930yPWE62xkC2MKP11td4RL8eOcyJHL16Mm7try6Z41THb9n2vR7umaPP1Aztpg5DOiLwwawSNCtPGy/vvZ/+ULSCeexmB2kOI6HU/Q+XS04ekRNjIwTFoQrBOAobKjVP8q0lNO813dUQWeTkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=coVX0XyE1mnRFgfGSKzxuYjwEGMWj/hFCGR6hK0LA4c=; b=nuvsrY+UPGMRC8zkX6w7micgyYA7cQIkxnIPVg+iBJsA+LAgvh0lYRdU8CWv/e2wFQVNDhYwTVEToWUIYiYGusXxdbQ3xFKMOlqAVGI4XDtgtfHjg6aKVYdmegdoPQ5qF6yp0EUwlqSaaH6AUTIm9p/gElWEi6ZFzDOyHPsC12E= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by DB9PR08MB7582.eurprd08.prod.outlook.com (2603:10a6:10:306::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Thu, 9 Mar 2023 19:37:58 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%7]) with mapi id 15.20.6178.018; Thu, 9 Mar 2023 19:37:57 +0000 From: Wilco Dijkstra To: Kito Cheng , Palmer Dabbelt CC: "libc-alpha@sourceware.org" , "joseph@codesourcery.com" , "jeffreyalaw@gmail.com" , Darius Rad , "christoph.muellner@vrull.eu" , DJ Delorie , Andrew Waterman Subject: Re: [PATCH] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 Thread-Topic: [PATCH] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 Thread-Index: AQHZUpGX8k2dpVWsnU+W0pDcm7oxta7y0UWq Date: Thu, 9 Mar 2023 19:37:57 +0000 Message-ID: References: <20230217022646.99959-1-kito.cheng@sifive.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|DB9PR08MB7582:EE_|VI1EUR03FT054:EE_|AM9PR08MB6226:EE_ X-MS-Office365-Filtering-Correlation-Id: 06512967-14d2-449e-6e1e-08db20d5d1de x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lVrGOm38sD+0ZBv58srKCU+GA0q7sJpbmUSeiay3X5nUYsnj7uF2ue+o6cJAkN7vJs4EuCWqpUrhIhqBL0ofKqP+iAtkTV09ctDvgsHTrJLDjotM4S9N7IyysDDqrrJ7CxqQm8s4x5bQ2DRtyPHxMXi2dpKHZwsaSCH9q3U8N1c//VUxYodlXtHlFqbACBG1u560TM5xtS9GdakHd2QE838DuxI1XVUOB8gyY3GTSN3gFkw0ruZ0tXPq9yIW1Yc++SmiA4zS5mVYga+myKYtuuzaWfe88W7UoDCBXt+GdeOIDGQcdSNRIENSMzMWdKDMvON7fIAGReXQr1fc1oSuhy6BpXchFy0JcoHdkz2nU2N0Fz7xX/RYyNkA7yVcIKIUmW+EIWBs+N9iYbUcvsNrGZXFUu6YAW4tQsUzidZRuEo3tSkqamXP8SXKC1ZfLd5NQL8tjLglnko0BgwNJ2H3D1M02NfVy5eh83frjsD3svsOVMPMBKGXi6U7ZcpaNOcVe3wXt0/TD44T4lSWdDX+YRj7RAbUFZshjXHMGy+alsEwb4gbT89lj4/p3FRvAlNcCgRrpbkU4H2f8xG0GhWWX0nwnp0qcjIPPxLR3eFfMbaEYT0n8u1L1S/kch6r6eMGAr9sOChz5M2OkohNAAYtYL0EI0Uj9/LR47kAD5jYsBkwG0heHUkffBpuGhJgmW2XgrXintihkHhhR94YFfXjMw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(366004)(39860400002)(136003)(346002)(451199018)(33656002)(110136005)(54906003)(478600001)(52536014)(316002)(71200400001)(122000001)(7696005)(5660300002)(2906002)(66446008)(8936002)(41300700001)(91956017)(66476007)(64756008)(8676002)(76116006)(66946007)(66556008)(4744005)(4326008)(26005)(55016003)(38100700002)(86362001)(9686003)(186003)(6506007)(83380400001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7582 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 08bb976f-8079-4c36-35cc-08db20d5c8cf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6cWieoI6Rc9eb01zYH9TVUn7USFZMnP06/BjQ2jLO91w0qiIXdVaN+pAgOHaVO9Mr1HEBEjA/QAv66007lW3Cug7ToudOxKWvkMDy1+3zZfPy3rs/xHTdTRun3Aa2QjFSaky75O0yDFXbt/jzSuzOGcUreQAVr2tPNGF+vUu69Aghw5ltoiH0s745GHXEH22UWfcezyLpUVj3QIjgBV69KcVPmJXa7d0II5lTQReIWCTfdobL4uPMuEHIYPZlyfn5lX7O1ItAMJyWsapZr1PL5TRwRt+99tZ9toPWnlsbk3eGzC9V0OWqsM8+xofJQ8LXsc/ginvKDHnVnlFzTp2Jbfd+ZRTcUiMkLPEclmW/f1j/mgPlcVXZ2AywyAxSthA9AfU0u4zsB8x3zlD3F6Q43oZ9R8GrrwnYRCyyP2iXsnQA/L8IUUaW7P7ZxC0IW96ivlj6bEx/AbxmI2IGEZh0Vq2XpOE+MVdm2ngAE5lN42bqVAxxZEEPI1cRfWYguIxKpJGC2XCnOErQh+bGxE3P4iax7ZlWfxCiPBWXCIkQWxgGfKQVGZzYuT0aF13o7/8Q/PMJ3uqqLf3EtCbSf2Etb59O5gX7Of+zlIfIIt3LjCpp5/iYA7o0nbu4vkZcbXZ2GPqDOYUvgQTWzI8eCbk4zACNMYXPiagmC9ZW+ZLt8T1rc1fQOxZOjEjOEU1fBKHFuxfW6aJqI6RJ/FGafCXTg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(33656002)(40460700003)(316002)(54906003)(110136005)(478600001)(8936002)(7696005)(52536014)(5660300002)(2906002)(4744005)(4326008)(70586007)(70206006)(8676002)(41300700001)(356005)(55016003)(26005)(82740400003)(36860700001)(81166007)(9686003)(40480700001)(86362001)(186003)(6506007)(107886003)(82310400005)(83380400001)(336012)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 19:38:12.3257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06512967-14d2-449e-6e1e-08db20d5d1de X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6226 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kito,=0A= =0A= This comment reads a bit strange after the change:=0A= =0A= > >=A0 /* In the default version of this header, follow __FLT_EVAL_METHOD__= .=0A= > > -=A0=A0 -1 is mapped to 2 (considering evaluation as long double to be = a=0A= > > +=A0=A0 -1 is mapped to 0 (considering evaluation as same precision to = be a=0A= > >=A0=A0=A0=A0 conservatively safe assumption), and if __FLT_EVAL_METHOD__= is not=0A= > >=A0=A0=A0=A0 defined then assume there is no excess precision and use th= e value=0A= > >=A0=A0=A0=A0 0.=A0 */=0A= =0A= Maybe this would be clearer?=0A= =0A= In the default version of this header, follow __FLT_EVAL_METHOD__.=0A= If __FLT_EVAL_METHOD__ is not defined or set to -1, assume there is no=0A= excess precision and use the value 0 (this is correct for most targets).=0A= =0A= =0A= Also separating the commit message from the rest of the discussion would be= =0A= good - I assume the quote from the C99 standard is not part of it?=0A= =0A= Cheers,=0A= Wilco=