From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2045.outbound.protection.outlook.com [40.107.8.45]) by sourceware.org (Postfix) with ESMTPS id 493CA3857400 for ; Thu, 16 Mar 2023 18:43:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 493CA3857400 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7zOn8Q8QNsYeGS4+RgyJWnM/Y+CkzxZ7ZPXwhv41fo=; b=h77TTW6a1vTK8XhbeTlpso91o7T3GJDWazDNjzjrRBHiqInmVEO9coubLmkIplBumc5CDo03Oxgl3ewYQY7+yF5hVWoTvHjh5JFFw1QpqE4Ouj3ltW3dPWs+oTjI1gyN+8ujnD8XTruxdYwhl5lj3miaVovb+cMwF4XXhuzYTOU= Received: from AM6PR08CA0034.eurprd08.prod.outlook.com (2603:10a6:20b:c0::22) by DU0PR08MB7592.eurprd08.prod.outlook.com (2603:10a6:10:311::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Thu, 16 Mar 2023 18:43:03 +0000 Received: from VI1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::17) by AM6PR08CA0034.outlook.office365.com (2603:10a6:20b:c0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.31 via Frontend Transport; Thu, 16 Mar 2023 18:43:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT019.mail.protection.outlook.com (100.127.144.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6199.19 via Frontend Transport; Thu, 16 Mar 2023 18:43:03 +0000 Received: ("Tessian outbound c2bcb4c18c29:v135"); Thu, 16 Mar 2023 18:43:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dd85170ff4ef94bb X-CR-MTA-TID: 64aa7808 Received: from 00c3c338b56a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 453DF567-3C9C-4990-B102-0A61C24DB28E.1; Thu, 16 Mar 2023 18:42:55 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 00c3c338b56a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Mar 2023 18:42:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gyqhEYiAcqPk3RrfWB10FGeEnMyBOTAthS+fcWZ9Qh+Ajp6bQXrM87400NO4qxVcWPRyzmuLhh/myyDazEXe4iX5vy1TzcMPquyN9qqwyh6Y9P5HtzteIDcpYOA8/Z0UfSU/nplubAtPWy94LZy9upLW/izTdoQTuwpNHhL6zydPmSAQA0W+xY3JiUCS63uS6JXiy1HoRRjtwAV+5rCrvxNIKlNZyrU8cmgIG0aqFCszGtteHkzPl71+I+QGeGV9a1IeAlDO45DFXlZYqZOojjuj8qklLmYccpZoq5rL/aHYabt7XwDi4MBkPUXfOFDgPg9xzxD+6qZRGxPDvnTyBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c7zOn8Q8QNsYeGS4+RgyJWnM/Y+CkzxZ7ZPXwhv41fo=; b=j56tjTcVjJomSRr4KnwSe1Lq1VsDUOitHkipYS1C+qMBGzirzTFpiqF9fEFhiW4jJDBSSAlbeJumqufBwGUD1x0EB6utzKDuKFFyz5tO27ht6zlaMAXYQoqxIUhA5QRqDWN70D4solOJqGos5wz8Yok4Xaz28rI4WtH8AoETWFH7bTDuoeqFAa/le/gYtRhfgnzjKUyKPvDqEoin9eI0kK4bpVE3aeudsCsLDa1ByL7ZKdQU9zHZqWcWKnCTzf1lnxTsbrNJ8ztRI9aNEuRFFlfVKCWaMvW+ggLjnRJJ8vJBld1hBa7tRNJVGvaIpHu83AdoGUnG/Tx6wsk11vZIUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7zOn8Q8QNsYeGS4+RgyJWnM/Y+CkzxZ7ZPXwhv41fo=; b=h77TTW6a1vTK8XhbeTlpso91o7T3GJDWazDNjzjrRBHiqInmVEO9coubLmkIplBumc5CDo03Oxgl3ewYQY7+yF5hVWoTvHjh5JFFw1QpqE4Ouj3ltW3dPWs+oTjI1gyN+8ujnD8XTruxdYwhl5lj3miaVovb+cMwF4XXhuzYTOU= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by VI1PR08MB5454.eurprd08.prod.outlook.com (2603:10a6:803:13d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.31; Thu, 16 Mar 2023 18:42:52 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%7]) with mapi id 15.20.6178.030; Thu, 16 Mar 2023 18:42:52 +0000 From: Wilco Dijkstra To: Kito Cheng , "libc-alpha@sourceware.org" , "joseph@codesourcery.com" , "palmer@rivosinc.com" , "jeffreyalaw@gmail.com" , "darius@bluespec.com" , "christoph.muellner@vrull.eu" , "dj@redhat.com" , "andrew@sifive.com" , "xry111@xry111.site" Subject: Re: [PATCH v2] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 Thread-Topic: [PATCH v2] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 Thread-Index: AQHZVoiLO6wONogGg0WDriOUT144w679wBFg Date: Thu, 16 Mar 2023 18:42:52 +0000 Message-ID: References: <20230314151948.12892-1-kito.cheng@sifive.com> In-Reply-To: <20230314151948.12892-1-kito.cheng@sifive.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|VI1PR08MB5454:EE_|VI1EUR03FT019:EE_|DU0PR08MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a93420a-424a-4fc0-fa0b-08db264e4658 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OAhAtKEwUMPZ/7S/ah42u72NZztc2lkogvPriCI+maWYLBhVn1tasvADenAMRb6N7NTHVHXLsmj1FLM9ZScLXwac06h8Z7ijyKIZJzGjvXEC9p0qfqTqt6yJe7WdCKjKRb6CzfPzNSLJZW5Hi4xPOSMCoSJOmJmYsp9xOP4p56yDGO/rl6YIvaLGmhhEwiRe4AttDUj8Gh14HZcqlteKEKfewl/ebWYiZfoXEy5nHrMiR2iZa8EeBlHxkOkBfWXbRougl73MkCDvpipUdgW7Kav9PEdw7FeZtXdUqBX+D1bQxHyV3/SJfWAV81+K58fPpnYtUIB9dehyHIMDd8Mba4r16/Ape6b12JjaNpxrGyr75l1UPXOcXXDJYbrpATAirPdC8ItX7px93klKkvKQWzqvprJ3vwPfIdZco1wjNeRvDi6mGtbC1H0/h275oegBe2dePIx1Du3XhmHLaeykJnKwobXeHYR0XDm4dYjdz9iQekcD7H+XeKrGjSxoG2l9tluFI09gWGQkUauvGgHQUL0QX5nQ7kSC7e/Z3BA45Xz2ZsdNslZBypyS1u4OfUqNmHsKzWfkV/7/yjiAUqCYy8rPYp1mm+pE2vE2y/7wz/Pxu0rtk6hEREl1zS3Ob6xcqfjXPgjmULahMsM3035lI2QIZOjHqKGFRhtiz8RsYNPId531OkeI1V+oySGIhtFdPQaS2doCgdOQjhz67UeGkyy14xuT6ix5QA4qHF7zxZ0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199018)(86362001)(38100700002)(38070700005)(921005)(122000001)(33656002)(2906002)(41300700001)(52536014)(8936002)(5660300002)(7416002)(55016003)(26005)(6506007)(9686003)(186003)(83380400001)(110136005)(316002)(64756008)(91956017)(478600001)(66446008)(66946007)(71200400001)(7696005)(66556008)(8676002)(66476007)(76116006);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5454 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1b22cc5e-35d3-4232-adae-08db264e3fe8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 48UbUd5+IJMiI8ENQtbP5siMRfUnxXvfDi8z1BejOoVNtOHLGwGmqZOmc+hTb0WWWlrkB1OtuKLHhZAA8tTehCpmDgM5lF+KaIIUv3yyTjpmamHKIgLq1WYFsryOEOwDhUuQ4yxOmIx8kTGRfhqrJ5DXSldnLw2vVrvMTonvofoS/J5ZLuAEOlQZQbkdnYcTn/yJI9uYCHjcz3Q4dV2P5JC85X2xIcYbqRnFdgTT7EKO0/+74N1XOpbAPyszl0fSQBQp9dE9zQajdO+A/bbXwBDGDnkM0UKU6p+2BaTRxkhAlUthLtKf5EKkBfVNcN3V9YudSNkukvEJyzk6JmAeP//ktFUaLZvmVCqaXP/FJHyl/pLjFyOnY+h/fk8942aW7rCEhxCVSn0TmQDucVettAQTs8jB067g6BktIPBk5K216Xnfz191p1RjRHtixE1fZyAnBcGb7R81X9fFCXaY8r/0bVcISJW+zbVHBdai3a3gSZPCKSKbZnGdvV5vAZdGCZ8PtbEj7Ir3b5VriqISj57hFzAi3o7IFGv6tbG97M+Cie/LEjbsJkzc588g/GZUdICJV8KXDwGaTFugmxqlACaaQNqJ7Qm2W6TyOFdC6R2xJN9kPJ+UZ3pbTfC6K1jG0R94pPgQnR6ZnpnGZCOd87qd9hKzE+hbQpgL10tO4pqsLfDxzukSfyGt93TYRgyKvTbxsalTHD+0h4FKKUkwlqJ1Hw09ARc9uryg7vxfv1g= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(356005)(82740400003)(36860700001)(82310400005)(921005)(70586007)(33656002)(478600001)(41300700001)(7696005)(86362001)(70206006)(8676002)(55016003)(110136005)(40460700003)(316002)(40480700001)(81166007)(5660300002)(2906002)(26005)(6506007)(47076005)(336012)(186003)(9686003)(83380400001)(8936002)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 18:43:03.1504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a93420a-424a-4fc0-fa0b-08db264e4658 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7592 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_MANYTO,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kito,=0A= =0A= Thanks for the update, this looks good now.=0A= =0A= Reviewed-by: Wilco Dijkstra=A0 =0A= =0A= Cheers,=0A= Wilco=0A= =0A= =0A= ---=0A= =A0bits/flt-eval-method.h | 8 +++-----=0A= =A01 file changed, 3 insertions(+), 5 deletions(-)=0A= =0A= diff --git a/bits/flt-eval-method.h b/bits/flt-eval-method.h=0A= index 75f57b9a0e..f9262d7d0b 100644=0A= --- a/bits/flt-eval-method.h=0A= +++ b/bits/flt-eval-method.h=0A= @@ -26,14 +26,12 @@=0A= =A0=A0=A0 -1.=A0 */=0A= =A0=0A= =A0/* In the default version of this header, follow __FLT_EVAL_METHOD__.=0A= -=A0=A0 -1 is mapped to 2 (considering evaluation as long double to be a=0A= -=A0=A0 conservatively safe assumption), and if __FLT_EVAL_METHOD__ is not= =0A= -=A0=A0 defined then assume there is no excess precision and use the value= =0A= -=A0=A0 0.=A0 */=0A= +=A0=A0 If __FLT_EVAL_METHOD__ is not defined or set to -1, assume there is= no=0A= +=A0=A0 excess precision and use the value 0 (this is correct for most targ= ets). */=0A= =A0=0A= =A0#ifdef __FLT_EVAL_METHOD__=0A= =A0# if __FLT_EVAL_METHOD__ =3D=3D -1=0A= -#=A0 define __GLIBC_FLT_EVAL_METHOD=A0=A0=A0=A0=A0 2=0A= +#=A0 define __GLIBC_FLT_EVAL_METHOD=A0=A0=A0=A0=A0 0=0A= =A0# else=0A= =A0#=A0 define __GLIBC_FLT_EVAL_METHOD=A0=A0=A0=A0=A0=A0 __FLT_EVAL_METHOD_= _=0A= =A0# endif=0A= -- =0A= 2.39.2=0A=