From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by sourceware.org (Postfix) with ESMTPS id 0CC8C3858439 for ; Wed, 15 Feb 2023 17:51:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CC8C3858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k7UKcMlzwQYfXxYc/EuInO31U0vR3Wj+HVmVm0wrYpc=; b=QbFAbWvoEqcFTJn4nGgGG483FCIDhcH4HB4V9GW5CsmJyqohVNuS1Mo56nh5slyUGc7+9GnxV08Hbn6enG1dojLimlpmyCymWWxuN1HxUwdFN+3zvqc5G/gz6gzgT0w4LNocC96LVMCAy1A8FGYI01dq7XjZ6Mfl7RJo+Wbfc1Y= Received: from DUZPR01CA0013.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::6) by AM9PR08MB5891.eurprd08.prod.outlook.com (2603:10a6:20b:2da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 17:51:08 +0000 Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c3:cafe::14) by DUZPR01CA0013.outlook.office365.com (2603:10a6:10:3c3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Wed, 15 Feb 2023 17:51:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12 via Frontend Transport; Wed, 15 Feb 2023 17:51:08 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Wed, 15 Feb 2023 17:51:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2e8fa9fbbc52f51e X-CR-MTA-TID: 64aa7808 Received: from 24beebffa40e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0AE99401-2797-4AE5-A736-05BF7FFE6AFD.1; Wed, 15 Feb 2023 17:51:01 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 24beebffa40e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 15 Feb 2023 17:51:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RwpJMAGfG46kiQlo1PQGig50Cgh3bic+VmRMmsx2MdzbG6JIRv8ImmYk1DHG7aFqRgMNXD5qJLEeGIhruOd5pGWOJgI/CFowGcA22pwOWYJJEDlvPSyeXX92Apm4S7syAc3AmXZVtiIJailavGdUL7Walfnv8vTPnNrjL/mmv3sMQW38qScjvkYd5fXTi9CnxCxbXueNy/l4XP6Ow/NL6qnHo5R+opqUGkDH/vj59NhqdQ0aV8D7PCSOOOzgoYhChn9RyaRjpAXhX6hqPhucu9Qql5HgTZ6TEDlanOGnpA3sTZowbenxjenHybrqcXBmuaBUJEhIBqnD11nsbCrd8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k7UKcMlzwQYfXxYc/EuInO31U0vR3Wj+HVmVm0wrYpc=; b=CxWwqRjuDvtvcbmmiQPNEJGzx4oXskANUJVx8llYORvDfxXIWCcJe63hRVknU7qLnnn0a0pjUBfWRxLM4KE5xwqcKhDuK4kN9K7bicFAN1nJ6dKV0qAbAoLo+icaJbe6EWlFpHn1e4LCxFjt8rbB/kt4l1AAqOdivGSSnWx1MqRILKqTWRNaxjUMQNIhQI5GRoHlBp3ozddEeP4U4O3pkfFaWnCy9tJomS9nSwZIfZPCDidOl8ULvM/OvxQ8ZRf61xcP+3cVRH175Enl0Mb9xLrCzUs5tcJzw/MasdsxsAmAWmP/YleLNeo3ElZm8lOOIJ2AGVzJHI6wJXIEVVZ18g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k7UKcMlzwQYfXxYc/EuInO31U0vR3Wj+HVmVm0wrYpc=; b=QbFAbWvoEqcFTJn4nGgGG483FCIDhcH4HB4V9GW5CsmJyqohVNuS1Mo56nh5slyUGc7+9GnxV08Hbn6enG1dojLimlpmyCymWWxuN1HxUwdFN+3zvqc5G/gz6gzgT0w4LNocC96LVMCAy1A8FGYI01dq7XjZ6Mfl7RJo+Wbfc1Y= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by GV2PR08MB8318.eurprd08.prod.outlook.com (2603:10a6:150:b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 17:50:59 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%6]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 17:50:58 +0000 From: Wilco Dijkstra To: Adhemerval Zanella , "libc-alpha@sourceware.org" Subject: Re: [PATCH 2/7] stdlib: Simplify getenv Thread-Topic: [PATCH 2/7] stdlib: Simplify getenv Thread-Index: AQHZP7Lw1U/R5f74V0KbI/wP5ufA3q7QRZee Date: Wed, 15 Feb 2023 17:50:58 +0000 Message-ID: References: <20230213135558.3328727-1-adhemerval.zanella@linaro.org> <20230213135558.3328727-3-adhemerval.zanella@linaro.org> In-Reply-To: <20230213135558.3328727-3-adhemerval.zanella@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|GV2PR08MB8318:EE_|DBAEUR03FT055:EE_|AM9PR08MB5891:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d915be8-3ab8-49cb-4588-08db0f7d37d6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LKOLtKeN1gIvjPpKnV2qwlX9WOXo44DF0pu66f6qDU3M2N7ogP7Et/PbpscnGzshZJZvTKvb96NmCx7QlWptc8P64YwhiHW06dKemP35quLMzUgb6RN5shRwTjS7XK6Msij2ym+Yk5f5VTRIv9qguy2uf0FGwY5sFpfymoNdgzFsNLv05hA/CEaPdDrvso7eIwx/L4eBdpcT8mDWKmjX8aWm9mQQ7kWQqdkR5zXShh7njiXr57aE8tmJhjIzw4dOUgvdTTe+JR1ZpCyquW42ufItwS7S6dlvmrUsZmtnvuns9KH+2TWl++d4kruA3Z0/T6v3k1Ub8mhUpe12Axzpx9Xj84BXb60xe7kmWG3zmtzM8W1Am9WiT6YYwSoVopaupMD7vIoCoxvR5LGJqgOgPpkLEwT7bmrVMfHzyo1Tc5UijNEWxhCswQNvj4+hsyBWDgYXcjNVMQnCOL0uMLHgF9qZ6fJBCZn+dpmdTzTmU9Oo3LENNYc/jKff4FLsHnCAqe7qg0Px2hDFGw9fgq1VxxOMx9mVoQieB7vjpNUfIl8Nzld0uFpWeBbDYd2wcaE/kA7CWWMfskTKdKb4Yh4aNVLsfvV00tslfHDbknlIc1x7sA0JquMJ9ORn1lAekJG9lbNUV55D4YMhh4XuIoSTEFm4omBsdeLCmQArV2L2JA2hyrKQnEbibFhBN4lDQmFLaO5A4d4vneu1hhrC9TWQmg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(451199018)(9686003)(55016003)(316002)(38070700005)(2906002)(91956017)(66476007)(64756008)(66446008)(66946007)(66556008)(76116006)(122000001)(8676002)(38100700002)(5660300002)(6506007)(478600001)(41300700001)(33656002)(86362001)(71200400001)(52536014)(8936002)(110136005)(7696005)(186003)(26005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8318 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b34e4d75-6a38-4874-146a-08db0f7d31b8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tifEmWe6W2YnRfLsDOEZAT/IN8EnRtokipvCCWU/JpvZj8Mu5ft9jqMf6n/n2UkRoS7z5wb9CrNems2r3n+O/n039lvqxBVYHjrqmxfcg2QYgF3QQJfXn57XLz0lX3696OTwxxtchPYvxBaCTAA/uAnlk8C4Vr47z2tjR0I7C4lSzMIVy8u0q/ksEry8vexNsvFKQOQBnvVBNpzaf5S/UzK2UAkjN45IzwSVmqwalCaAnUrjdapmone5Uhbx5yjS3eyrTKalBbfpfyrp9Vw0e+PvR9r3e1DTAKWtJPZLQ8lDUopOsT33q5SwERL6zuxRzYRSIqIrpmKXgkZNATcSitwOL6Ri7H1XniDqzrokd5HALBUiEsM1yhg1182zM1HP5cXA/rCmNwAJoZZyHnETaGaUS5TWjHdDECodUAYrP7q9UwFhDTfu7Et3fxqi/8W6iawsGVzmTTEKmXowHzeEjENZHXnvCtgaNnC4uRur5YUxj3yUV66YkwXEd83Uk8qcftuQ278OIsVRKHG7Yf3On/rHy7NVmwEdlHmTGxv78dHsypVKgkMMpBNY4nCbJUpE+inDa624ThHn1HaNlb0Lb+3h395Zz4RgRUikoy0/0MbuPosi3nLbMRtzAOHW35CY34dL0Jqbvw1zBPocqQOX10mOs5NLm1KL4ndEN44jwlKUAWfGMzarqE7TWsrnOv8ETtOXdMV9T9B6b6bKWgo9uw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199018)(46966006)(36840700001)(40470700004)(40460700003)(7696005)(6506007)(41300700001)(2906002)(9686003)(186003)(70206006)(8676002)(70586007)(316002)(478600001)(26005)(110136005)(52536014)(5660300002)(8936002)(81166007)(86362001)(82740400003)(33656002)(82310400005)(55016003)(40480700001)(36860700001)(356005)(47076005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 17:51:08.5018 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d915be8-3ab8-49cb-4588-08db0f7d37d6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5891 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= +=A0 size_t len =3D __strchrnul (name, '=3D') - name;=0A= =0A= This is a change in behaviour, ignoring anything behind a '=3D' in name. Wh= at is=0A= wrong with strlen?=0A= =0A= +=A0 for (char **ep =3D __environ; *ep !=3D NULL; ++ep)=0A= =A0=A0=A0=A0 {=0A= -=A0=A0=A0=A0=A0 size_t len =3D strlen (name);=0A= -#if _STRING_ARCH_unaligned=0A= -=A0=A0=A0=A0=A0 name_start =3D *(const uint16_t *) name;=0A= -#else=0A= -=A0=A0=A0=A0=A0 name_start =3D (((const unsigned char *) name)[0]=0A= -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 | (((const unsigned= char *) name)[1] << 8));=0A= -#endif=0A= -=A0=A0=A0=A0=A0 len -=3D 2;=0A= -=A0=A0=A0=A0=A0 name +=3D 2;=0A= -=0A= -=A0=A0=A0=A0=A0 for (ep =3D __environ; *ep !=3D NULL; ++ep)=0A= -=A0=A0=A0=A0=A0=A0 {=0A= -#if _STRING_ARCH_unaligned=0A= -=A0=A0=A0=A0=A0=A0=A0=A0 uint16_t ep_start =3D *(uint16_t *) *ep;=0A= -#else=0A= -=A0=A0=A0=A0=A0=A0=A0=A0 uint16_t ep_start =3D (((unsigned char *) *ep)[0]= =0A= -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 | (((unsigned char *) *ep)[1] << 8));=0A= -#endif=0A= -=0A= -=A0=A0=A0=A0=A0=A0=A0=A0 if (name_start =3D=3D ep_start && !strncmp (*ep += 2, name, len)=0A= -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 && (*ep)[len + 2] =3D=3D '=3D')=0A= -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return &(*ep)[len + 3];=0A= -=A0=A0=A0=A0=A0=A0 }=0A= +=A0=A0=A0=A0=A0 if (strncmp (name, *ep, len) =3D=3D 0 && (*ep)[len] =3D=3D= '=3D')=0A= +=A0=A0=A0=A0=A0=A0 return *ep + len + 1;=0A= =0A= It's still useful to keep a check for the first character, eg. name[0] =3D= =3D (*ep)[0] as this=0A= is about twice as fast as always calling strncmp.=0A= =0A= Cheers,=0A= Wilco=