From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2071.outbound.protection.outlook.com [40.107.15.71]) by sourceware.org (Postfix) with ESMTPS id D6BDA38582BD for ; Mon, 16 Oct 2023 13:52:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6BDA38582BD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6BDA38582BD Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=40.107.15.71 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697464343; cv=fail; b=s7FQk+9vW3n2xkT54QQDavNjZgFPfBNnnAHVjcO54gIIFFHfFvRUjcBAUD1yKUdbZGqglEL7uYpyNx0lWDvzHpOnyU4lE7sIl7a8m3N83F32PSlgCJ07hNV2yEGznDW6lT05XxDbJMe9+Ofbc5y0vQP/28Vs1n4BG1NoXqC8/qI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697464343; c=relaxed/simple; bh=VKA0mXj3enpt+YWtDuSjh2WnUKre8EbqdJH/EkH424U=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=LKtffEuNEOWJoPTrQwxc8KWOAaY97UvWasHNqWZVAowk34L3bv2CTxCXCtjuX4Kdm6jI/67e8U0rudri/M+nAF6uhLw65FfqbN7e+rPBidNkOQ9/HRRmiKDpOAfRtSyaDcbVntrztKdUur+VLQL+gA/tzIcYNSOh9PL0KUjW3kQ= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKA0mXj3enpt+YWtDuSjh2WnUKre8EbqdJH/EkH424U=; b=pTDQ1sEiEl961iqzuy/IxRhu0/mSXRdfFMZMgtf42GinOiyoBHIets4sjPzZF6kjdLc+bpq/AiiG8Y6D/AtcOPw4Zj1N5HH91hQjaVmoaPsHQr93g1SNHK3jxzFm5f7AQ2I5Sy+0zc0/JK3JNEnbFYxH2ARJ4v9AqTJeGDms5fs= Received: from AS4P190CA0029.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d0::19) by AS2PR08MB10125.eurprd08.prod.outlook.com (2603:10a6:20b:649::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Mon, 16 Oct 2023 13:52:16 +0000 Received: from AM1PEPF000252DF.eurprd07.prod.outlook.com (2603:10a6:20b:5d0:cafe::e7) by AS4P190CA0029.outlook.office365.com (2603:10a6:20b:5d0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35 via Frontend Transport; Mon, 16 Oct 2023 13:52:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252DF.mail.protection.outlook.com (10.167.16.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Mon, 16 Oct 2023 13:52:16 +0000 Received: ("Tessian outbound fb5c0777b309:v211"); Mon, 16 Oct 2023 13:52:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6b59bdb2eb5db539 X-CR-MTA-TID: 64aa7808 Received: from 773e532cf045.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ED5977FA-5543-464A-A427-1453BE2546C3.1; Mon, 16 Oct 2023 13:52:09 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 773e532cf045.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 16 Oct 2023 13:52:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mq1rEneFoc1z7D9XM3awaWCvtOZkb1AY/w2bi94QvOnRMrbhNc8dTDpdsxOHHltBA3gI7B/nJQUyrCga7DmSCqLdGjOkdJqI9I1gbOmD9MC215K0fEHakMtiZQHiiDzzY4GG0m1R7mTG8mbVktVcoY66oWgCWwm4iGPPRW3xz4awN7lVMGJXdXxOpDKHuPZC0sYBF0UM+wYFWsvl47lLi5TmUhybr6i75/RV3+QCDez2M8Sv9h3GdgxdRzzC8A7JyQUjkp3RprXK2+uVErqid23nfTW+4LSpkSmGClRvF4Rr9XSM80Pmej+pIeJfeTqkIcgSHFhRIz7ce23DublPUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VKA0mXj3enpt+YWtDuSjh2WnUKre8EbqdJH/EkH424U=; b=VX01t0xKEbiuhUxJMVbp85YOjjDtc+ousyTqtiCi0X3zyyK8fSyX1L6KC4r4KhzFab64eujoB8ucNj1qsQ/t9AdZ6Z4eBxphl1mH8Qd8/Ih/dVz7P09X2UAprxO5LYpGvnPYk26LqBA/qUJzhI6s5+XhWe7J5GVWaFgM60c+DSoUBBgKYdYcM81pozmUqK6YMvsh48xFVg2HKi/BdZLIrz+Di9VK1rnu4MMqkHJEqN09L7dUPH+xUa4BWCRC1RQ3s+0RSYb6D5hlgQm8zrprbLKNuF/ZdPEkhiuUKIWWLh72tC/TMqITs9dFHNyYOCaVJP4XrEiza/pjORAmKNGL3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKA0mXj3enpt+YWtDuSjh2WnUKre8EbqdJH/EkH424U=; b=pTDQ1sEiEl961iqzuy/IxRhu0/mSXRdfFMZMgtf42GinOiyoBHIets4sjPzZF6kjdLc+bpq/AiiG8Y6D/AtcOPw4Zj1N5HH91hQjaVmoaPsHQr93g1SNHK3jxzFm5f7AQ2I5Sy+0zc0/JK3JNEnbFYxH2ARJ4v9AqTJeGDms5fs= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by PAWPR08MB9637.eurprd08.prod.outlook.com (2603:10a6:102:2e5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Mon, 16 Oct 2023 13:52:07 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::31cd:30d1:37a7:3e8]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::31cd:30d1:37a7:3e8%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 13:52:07 +0000 From: Wilco Dijkstra To: Adhemerval Zanella Netto , James Tirta Halim CC: "libc-alpha@sourceware.org" Subject: Re: [PATCH] strcasestr: check if ne[0] is in hs with strchr or strpbrk as does strstr Thread-Topic: [PATCH] strcasestr: check if ne[0] is in hs with strchr or strpbrk as does strstr Thread-Index: AQHZ4dAd5lZhjOSe8k+Jyf663Rm12rBJLmuAgANvNACAAAh9XA== Date: Mon, 16 Oct 2023 13:52:07 +0000 Message-ID: References: <20231014083253.138510-1-tirtajames45@gmail.com> <8deea669-21b6-442b-a58a-05be075290a8@linaro.org> In-Reply-To: <8deea669-21b6-442b-a58a-05be075290a8@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|PAWPR08MB9637:EE_|AM1PEPF000252DF:EE_|AS2PR08MB10125:EE_ X-MS-Office365-Filtering-Correlation-Id: 68ec3eed-0891-4cef-9a45-08dbce4f1bbe x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sTtmNlJ3h/PN+va68DBseIl/xEmvXQSIUKtkpQ7xqIUI/GKXIAMtKFNr7Ie0lLQ/7JY3shCEMJQunMg+A0cvp880YbBaCFaBrnfDOgt2gCFJJbzdFqi8GahBGBGLmGHu3h52M9J2OpWnjS70YDmldEbb41kVnbeps8d2EtVzmq9dXmsQheguM23ni8SXdvjQ8DA068yfvgrbm6tJ2QgyVn7oPiOm6i884Cj16ANxIPTg1EXlkBxoTWB23nuFz9k2yzZsjgsniUhcHIlT4sX7Nk5ys9UV2ZUNfRlMvnQZ/ABAUUnfct9aZabyqETGzr6Na81g971gu9mAMoWL5tuVpxUWcK5s5EE3fnWpWQdrLQg/9Bm0J6bPhOFHM/4uBbhgVvvcsP0wwFSW2pu/1Z1xgkzFcjm9xGUpFkQFY+/6clCsCF5EVV3MoLHiTtlpTsq/NZ5nP0XM4vh7o/t9Dqse8VliwrirRR2OUQ/Q9S2nC2R5AzVYQ+R3h/sq6MtuhgaRHD0IPs3OQzAZdirDpD8QP0X2skcssXOVKvXulp9lV3od7sUAdKeb5cl0uc2Mf63LwyXxOP/d7/PHY103A9e6KUpCQ2IlObBmXLF1QQ03ZD4RLbNinkD62MF++WNpHjSEr1hfJrGjjXd4XSnf+XXp3eSCdUl/892KrUGh+ZmILisWoTZmtg70bqekdt+toKLiAZ1ve6aWlDOWYKzgaQ3fDX3SCRncO9pDxtwrW/KNMZI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(376002)(366004)(39860400002)(396003)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(55016003)(110136005)(91956017)(76116006)(316002)(66946007)(66476007)(66446008)(64756008)(66556008)(26005)(38070700005)(9686003)(38100700002)(122000001)(86362001)(33656002)(478600001)(7696005)(6506007)(71200400001)(41300700001)(5660300002)(2906002)(4744005)(52536014)(8676002)(4326008)(8936002)(40753002)(17423001)(133343001)(156123004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9637 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252DF.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 424987a9-61c1-45da-ec88-08dbce4f1652 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XMebj+PSibqfmirDlQYUokoiD37ZPox6LbxQbRMRoA+dOK8os1Etev014Xs1QNEZhDpQNiGiJttjdlABajaOKf80HBLO7WwOw1PYykW+Y7Jy+RTl5IGOJnp1GgamaldXc4mPADNvixFha8XjCtSG7hqHYwHIslCZwZ/lqhgmPDT/1fHcO/+VGzjkYPQ5w1XMbBtOvzvdRL4ZA/ZVEUoLLf3AIpkOikh6e0Vz41k+7KhKQVvMncGuWqF0dQ1OHCtTuI4JRNYWTxtlwfGBKVck/Ik2IAgD58/w/3CUeDMIYuiL7e3GmphI+5YxKEPJGhTwN5p9XWn+gXXArM3kaB/qJfpxteB4qtVQSrINmCJjNgRNwvCV2qwvQ9B+SIwZQhBk0hws+EtLNX2s9rzXSWc9USGcfEjFtSTNd9vxsuD9Bs8YFO/mNshkUlswuDdnbydot5E/mg6SSypv2W+XLFsG+FvKd0KB9fH+7um4XzH4bn/SRnfuZ1cXgsoIYlaoSVccVxSxFftRq+OXW2UxZFccEHjjwqXHJFtKjQbWI3N+p9uRU7vORTDRYNFT+VwCT9yeOqh035pSA/d+NPYR9rL04L3lPFS6DLfvXG08GUv24ZNryvr4QOoOS2MeLa3odxcj+lrph5lQAQ2ELBxJqNSN/qEgGVVswuKyG0DQC4oUaMcNKi0ApL5sMJF7flVuI+SNltWtXuXxx5Dcu1ldJ3byqS87IpVqNIQmQ26DoTcOGNKzDezZ5Hzztrp0IB++jVd+j1cj2u9Zn4GfNHbyU/SGfTMj7F34CI99dCJabnNSKmF3LCobuHS8PS2Vk+Ck0EXH X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(396003)(136003)(39860400002)(346002)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(82310400011)(46966006)(36840700001)(52536014)(26005)(55016003)(336012)(82740400003)(8676002)(8936002)(4326008)(5660300002)(33656002)(47076005)(81166007)(40480700001)(41300700001)(356005)(478600001)(86362001)(110136005)(4744005)(2906002)(36860700001)(316002)(7696005)(6506007)(9686003)(70206006)(70586007)(40753002)(133343001)(17423001)(156123004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 13:52:16.5802 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68ec3eed-0891-4cef-9a45-08dbce4f1bbe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252DF.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10125 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval/James,=0A= =0A= > We have the sysdep folder exactly to provide such macros if requires, for= instance=0A= > the file sysdeps/generic/string-fzi.h.=0A= >=0A= > So if this optimization is really worth, the best way to provide would be= through=0A= > a generic implementation like:=0A= =0A= I ran it on my x86 machine (with proper AVX-512), and the "optimized" strcs= pn is=0A= slower than the simple byte loop on bench-strcasestr. While the benchmark c= ould=0A= likely be improved, it shows this target specific optimization isn't worth = doing.=0A= =0A= Cheers,=0A= Wilco=0A=