From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2059.outbound.protection.outlook.com [40.107.104.59]) by sourceware.org (Postfix) with ESMTPS id 0B2603858D33 for ; Thu, 16 Feb 2023 18:02:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B2603858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJFhcFZ5yrmjDHTWPnSqrzHb1ycAR2mVUc7ZNeQjUGM=; b=oyCNAr4ZgZj7io6JAzzDHo5AFt9stdUMcx15sOZpnHpjL5FZ1AObns4k4eJdMX5Da8eh/jHrgG7kyf9dps+xLSsgvl41MuNi2p4YYb2781MFKMVYuOTPeQrsR3VIXTuOElG3cSLWh+OQ6sLCLspp+RTdPAskfns6eixkucNOddE= Received: from DU2PR04CA0072.eurprd04.prod.outlook.com (2603:10a6:10:232::17) by DB4PR08MB9861.eurprd08.prod.outlook.com (2603:10a6:10:3f2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Thu, 16 Feb 2023 18:02:17 +0000 Received: from DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::10) by DU2PR04CA0072.outlook.office365.com (2603:10a6:10:232::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12 via Frontend Transport; Thu, 16 Feb 2023 18:02:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT015.mail.protection.outlook.com (100.127.142.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13 via Frontend Transport; Thu, 16 Feb 2023 18:02:17 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Thu, 16 Feb 2023 18:02:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e49c2ce1305633f5 X-CR-MTA-TID: 64aa7808 Received: from 1c8aaa744365.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9DE27A5D-CCB6-4389-8E44-8E982A8ECE4E.1; Thu, 16 Feb 2023 18:02:09 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1c8aaa744365.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Feb 2023 18:02:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bKw23o5W6DiVNUYeiY/GcfJT/2W9pZnZGUbLBuCnvr9sHLgrdUI31KhyYanoWtSbN/495FK+z2dRzzw3+Z7aA8v1cRVDhcCZV68m7A+KSmRekxhxy7GDO3QRKf4byVLe1DHA+E66gOrG3h4tGNXk1o0CBABfLS8EJHlgXUiX6pC0itzCMMMsCtl6QwtK9vQFWdMKp1iPJWdiGV9bCOEsPwVoIXef9Bf6f/RyIpyZ/HV/XFb4CeZLE+fDfKzTCsJJHG6a5Ogug/u7olnZJKo++HjyfPTT1KUQkx6o2OShcMQ47oq3/DYpKPNWgzrrMJs8JnL3FHnhS8mlD/R4NHyeng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TJFhcFZ5yrmjDHTWPnSqrzHb1ycAR2mVUc7ZNeQjUGM=; b=XTsGP7dfaPo7ApjGGPdpEQoAfhAW5VJcy6BVhi/0gd0Op9NckuLz37XJRKpR49mtbFFltPNe2X0Hz+BJFqG6dGXTicw5nI3+mgDhWEyG9+Z11/W4GuKTl6Xag91+Er6nfXJ78H5mRS6aVEkBtbWQOtR9j5zKvuTKabpkEsamuqj/QwpMMqMI5KVnbinD6RnImwy5El0hPaptsP8u0Ical2QBBTS+2bbs8SnJfLakPKaPpeg6X/f67AxtMJp8M7dceQpFLBSeyIj3q/RLUB6xB/FfNWJJySBCiK8SLApYA1Q8RcqdJRyLBBJAPvPKPzVOwJRJbUud5azPBUtUx6A6TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJFhcFZ5yrmjDHTWPnSqrzHb1ycAR2mVUc7ZNeQjUGM=; b=oyCNAr4ZgZj7io6JAzzDHo5AFt9stdUMcx15sOZpnHpjL5FZ1AObns4k4eJdMX5Da8eh/jHrgG7kyf9dps+xLSsgvl41MuNi2p4YYb2781MFKMVYuOTPeQrsR3VIXTuOElG3cSLWh+OQ6sLCLspp+RTdPAskfns6eixkucNOddE= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by DU0PR08MB7592.eurprd08.prod.outlook.com (2603:10a6:10:311::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 18:02:08 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%6]) with mapi id 15.20.6086.026; Thu, 16 Feb 2023 18:02:07 +0000 From: Wilco Dijkstra To: Adhemerval Zanella Netto , "libc-alpha@sourceware.org" Subject: Re: [PATCH 2/7] stdlib: Simplify getenv Thread-Topic: [PATCH 2/7] stdlib: Simplify getenv Thread-Index: AQHZP7Lw1U/R5f74V0KbI/wP5ufA3q7QRZeegAFWGQCAAEHs0Q== Date: Thu, 16 Feb 2023 18:02:07 +0000 Message-ID: References: <20230213135558.3328727-1-adhemerval.zanella@linaro.org> <20230213135558.3328727-3-adhemerval.zanella@linaro.org> <7d887c0c-7ab0-4057-df39-e8d671bca1d0@linaro.org> In-Reply-To: <7d887c0c-7ab0-4057-df39-e8d671bca1d0@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|DU0PR08MB7592:EE_|DBAEUR03FT015:EE_|DB4PR08MB9861:EE_ X-MS-Office365-Filtering-Correlation-Id: 08badeaa-32a4-4083-c0dc-08db1047f0b9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pmIVD90rJtz6HqCElUO9rweoq3iuu0C5A6AgRz2MwvX88qJBbmReTeMnG/zbeA9qB4IPyMtLOL3s+QFor3CK/9m4/i35kgfGCpi8iizRC7jzKvQrds2iH36MJSPUAnh0RLcp7RuB0ytKFRaLwD0+MJ0Y8Asva9mBKim2RqY3nm89aO/LZjfvT6Ef6pO2TNJcfOG+0dL66R5xfziF0ZtdaVdubGn/p/gMZgTSkOa5ZYZfgXCNsDmDAXQ/HyxWjU2P6iM3rGx161+daCIRB/Q1x09YbY9/f3LRI1T5aUTkXdgnp7IOWFLxqYbDPfoWiFEXKloIpbc2AXhM0FVLLJOqQP6PSiGbEf6iz1lfRQ0v2kSdwLUc83OuPfwEFqJGxufO4PM62iHx347gcASJ1VpXgpA0OWq4x25xAjgB5wIhwcAF/3Mi8BU/JNDITPoMQsSbXSYGJRY1NTYt38Jd+UZ8LVjiK5A7llBTCKDLH6UXAbfUFEh6f05sFq2HjJ6lmiQcIJnt/+3fTmc1MEZcz/dQFFz8tiOL/V5IIO9gHyAW2uxZKtS9mMQV21Md7Mgyp7Ls3GXmjMDckaOv55OlapAsiMKpX7ctjwzXbisQWpDvMFMKfBRo0hL86GC3YyDVscoCWSnShYXRvKQwoB+vZ5eLo7jaCI+lmc7QUrWP3svFCpedPeBbLOh8W1Qei/Qzc7ioVQ4iFk0a6YILzOFTN4MDQw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(376002)(396003)(136003)(346002)(451199018)(2906002)(38100700002)(38070700005)(9686003)(86362001)(26005)(6506007)(55016003)(186003)(66946007)(8676002)(66556008)(52536014)(41300700001)(66446008)(66476007)(122000001)(64756008)(5660300002)(478600001)(33656002)(71200400001)(316002)(76116006)(4744005)(110136005)(8936002)(91956017)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7592 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ad87f432-b84a-4a60-8811-08db1047eaf4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kVwROMo9U6fb1PaDjq5a79w24CbdG8DAkzfbOTxEcTDgYYidqH+9iBeP0QqCYKWFwFnW61OZI7tMIhYOyhxrL/BE1tNFWP7uvntbqWcc5wTfgWG1TwCsqRFZP8cMwK1c683cj617jiJVn6rsbutjpz7T57Ciab1Zt8uFl6rxpg2gPATqmcNIERjaKV0Gg8d5EkMza/OYaS7mGO1yBMNoqdfOHIge7hHJn7tqdcOTqAHOwPc5s4qjJsP+MJ9chHH6+cLAa2UzQEu57cqJEjEdCb/5UIvuw5opwFMP+5QLEEvcSoLm/XkvGKN8myI3cMfSh8UVga5e7KQMm/xSUpVhTlKgjePQhvgS4ey94NEYz72nu5V1JkRNW5wNS//7if+4z+BbuD2vCM+YAu+RK3R1kF0VkrJIeOXPHvhib+uiypn0VZBN8/ENDR/5dHd9ROFUYsjUW76pT0sVy2HbzUhmLsIKzHBfRUNVtQ+e5R3Qb21xIRXJ+D5E+9R9lco9lMftft2C0NNPeIAI419m8YP7Aafu3i7UyMxsYzcIZ2j/NLtaaDwn1S8Yut1HgncXmbk9qBlRSmu9l+R7gxIfuogLSojX9jvwyChi1cjhL79KJuDkwUozil248taRcrclfF47q6WcKlqNY58Ku6qgLilO33SNesu1TF6H28OODws8jPpZyWzq1RW4ENWbLEFH6nD+7FlOGBeQOX1iUIkwrwlR+A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(70586007)(478600001)(26005)(186003)(81166007)(55016003)(8676002)(7696005)(9686003)(40480700001)(40460700003)(82740400003)(2906002)(5660300002)(33656002)(86362001)(356005)(82310400005)(6506007)(47076005)(316002)(8936002)(110136005)(52536014)(41300700001)(36860700001)(4744005)(336012)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 18:02:17.0328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08badeaa-32a4-4083-c0dc-08db1047f0b9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9861 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval,=0A= =0A= +=A0 size_t len =3D strlen (name);;=0A= +=A0 for (char **ep =3D __environ; *ep !=3D NULL; ++ep)=0A= +=A0=A0=A0 {=0A= +=A0=A0=A0=A0=A0 if (single_char && (*ep)[0] =3D=3D name[0] && (*ep)[1] =3D= =3D '=3D')=0A= +=A0=A0=A0=A0=A0=A0 return *ep + 2;=0A= +=A0=A0=A0=A0=A0 else if (strncmp (name, *ep, len) =3D=3D 0 && (*ep)[len] = =3D=3D '=3D')=0A= +=A0=A0=A0=A0=A0=A0 return *ep + len + 1;=0A= =0A= This is about 10-20% slower than the previous patch both for single-char an= d=0A= multi-char case... The approach I showed it is far simpler and 3-4 times fa= ster=0A= (within 10% of original performance).=0A= =0A= Cheers,=0A= Wilco=