From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2044.outbound.protection.outlook.com [40.107.8.44]) by sourceware.org (Postfix) with ESMTPS id D0B363858D39 for ; Mon, 3 Apr 2023 20:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0B363858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FtombG2GBrfYP0S2fGND6f+SMYWezBaU90D/JXS7ZeI=; b=m0LUEc8MQ7JbQxUS9WD3DAMytXvBLWQhChU55XSlAk89Fp9875pco//KCDoPp25vRVM/AHOnHrUDLg+BvKaDNi3wwYwyNSgN9dm8nK+g+XjLeASZlMWUaEXFGSmxGtjz+6uZfE5+Qo2cQT7eQDL6y5GGrYfxNpUzgsXh6QJ8yio= Received: from DU2PR04CA0151.eurprd04.prod.outlook.com (2603:10a6:10:2b0::6) by AS2PR08MB9918.eurprd08.prod.outlook.com (2603:10a6:20b:544::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.28; Mon, 3 Apr 2023 20:02:00 +0000 Received: from DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::b3) by DU2PR04CA0151.outlook.office365.com (2603:10a6:10:2b0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22 via Frontend Transport; Mon, 3 Apr 2023 20:02:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT005.mail.protection.outlook.com (100.127.142.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.16 via Frontend Transport; Mon, 3 Apr 2023 20:01:59 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Mon, 03 Apr 2023 20:01:59 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2a8f3f0e0fed169d X-CR-MTA-TID: 64aa7808 Received: from dd9f9aa79dd0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EEDCFD7A-8E30-4D79-AB70-DD995A343627.1; Mon, 03 Apr 2023 20:01:52 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dd9f9aa79dd0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Apr 2023 20:01:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6HBSJlvs3ACCaB4t4koCc4DF+hJdfPu8eZ0y1lQmDdEIeMOtBIuLiNgOvrkQtDdQrLofOBFMUv45Ax+yzqqpWxZXoewyej5i1dtSFHpica0luIlSZPnax03CKFvoEoJ7C3lq87LEsA9+aWnSVBLPcQOYvyEyD9uBR056zJyIpuS5w7lQ7hUAwt+nevzZbBTx8aLxCkZxxUk+wsnjdZymq0bOr8WCGFEFK6PqY9JQBtPa1RnZFu4+BAbY02wXQv/z7gnfHLbF/0Yp4gVekQ5oenzbJxb5yGxE8GBzUmrL1C1FiHJbPg2mKCQFSL6Ag78Lq4dEF+dIESyOUdsAFniqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FtombG2GBrfYP0S2fGND6f+SMYWezBaU90D/JXS7ZeI=; b=X4VSBxpnEBk1DhxZ+luUZD21T6Vr8ZKF/CPLB3LX+L70c/9Af19xczp0p6hTokA+vkXaKNgzSsNI6c1dXXI3sctuKhRmvzws/kTNOQJpMNg2Gi6fIUoWiTQO5LkvwNlOtsIyzotmKivlsEouCofSpWuhBfQqIaL6fabAqe84LEoUzS2PRUzmgv/vIBqjPhCx3tf0ahG7Mmw7xfZPdx6obyNN0gPtG4mhe573zsWOcBJeuYOJPXRF20RjksVIORaVb00G1HtW3lNJ/yXMESe4rj277aXJ0eSMU5DR3ezdezcxIj1afOtgbWZ1LIjFF9+SwNIadT1pvxa7Ckiaw1KQqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FtombG2GBrfYP0S2fGND6f+SMYWezBaU90D/JXS7ZeI=; b=m0LUEc8MQ7JbQxUS9WD3DAMytXvBLWQhChU55XSlAk89Fp9875pco//KCDoPp25vRVM/AHOnHrUDLg+BvKaDNi3wwYwyNSgN9dm8nK+g+XjLeASZlMWUaEXFGSmxGtjz+6uZfE5+Qo2cQT7eQDL6y5GGrYfxNpUzgsXh6QJ8yio= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by GV1PR08MB8060.eurprd08.prod.outlook.com (2603:10a6:150:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Mon, 3 Apr 2023 20:01:50 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::13be:967d:6e80:432f]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::13be:967d:6e80:432f%9]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 20:01:50 +0000 From: Wilco Dijkstra To: "josimmon@redhat.com" CC: 'GNU C Library' Subject: Re: [PATCH 0/3] Add tests for abs(), labs(), llabs() (BZ #30263) Thread-Topic: [PATCH 0/3] Add tests for abs(), labs(), llabs() (BZ #30263) Thread-Index: AQHZZmUhlUXWcQ+Yi063T7VsvuZpSA== Date: Mon, 3 Apr 2023 20:01:50 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|GV1PR08MB8060:EE_|DBAEUR03FT005:EE_|AS2PR08MB9918:EE_ X-MS-Office365-Filtering-Correlation-Id: 821a922d-d2a0-41e5-064b-08db347e4919 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Nw/w9v4RHLBIwOPXNafOAk6Et3+4CgbOiUGO/kFHHU6FcaXza5EyEjH8bkgx4IV4SLBCwvIv/9aSkiHSyFqhu9NbqRFnyWmvz8Hyfav2QbvoK/zjs7uoqbkLflY0nR0hfHq8u63mrmrvtufRzKehc/Kaq/BZ1vMIUFZ63rz42lZH4z/HmKptUY6gJb9qU6MBrA0YEbWRLX1TeAaLTBcsD+ApWAoV1+Q/4RpHFKq2TICbfJu5d4J1FpmoMD2Y2v4mG6jGafqaN23CtsPDksFryVthHt40/yxRk9WM85CjzcpQ9/wo3OoAiovDsisiflMW8mLxErNqAu0kSzy+HCqvpaTuRRW8aNTPcU+MALFPXAcKEWkXg1NWzb5/exnj8W7wrCiQtJz1UgIUvzHrEiKB8AuIc8adfwVqmibZwWm6ZCV8M/Touo24VS4KMWOMg4qkWgi8WFX1oGxDQw3RMAyK6ZXogeHhD687t+vflDK+oEqRRauzCzXjsjjKv/OvqTLKA0biHsh/BbizoHDAMLlWb7c68vxvRXqaeEQCUwRvLo0HACHw+ErA5pkV0pUEQhz7kEOl9t8+a1+VlShBO8Yu/PuYlpODni4fHU49TlBevIg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(136003)(396003)(366004)(346002)(451199021)(64756008)(8676002)(66476007)(478600001)(66556008)(5660300002)(52536014)(8936002)(66946007)(41300700001)(66446008)(316002)(91956017)(2906002)(4744005)(9686003)(186003)(6916009)(26005)(4326008)(6506007)(76116006)(122000001)(38100700002)(38070700005)(86362001)(7696005)(71200400001)(33656002)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8060 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c4d72331-b720-4c29-dcd8-08db347e4332 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: whILx1YqSrLRgwUdHgXuT+Uh1c8TwJVwKvicvqTvLzKaTjWx4fLHlu2SzQks9AoWy8emIm+V6orSzwzHqY2xgyCSrNnA8HqyQWqPXFVcztIo7KrWV/E4FBTM/4gXsPvgwBr4Mmg1u4tH4vKXH0ebApQZHNrlv8omNbWlzwjHQHkwgBbZadWttP/vXeTKe95jOlOEW4VacE5A/f23/xPomszJGKKVFdfXVwRHSgjFk9LyPIl18EjyIbcf+gTeowYuAhMyCnfLSd6TBSSt1epPiZhUfWVtn1L3kMEGYYhnRqm8jHuLjPTNOG1H1KUaEHOlWjn9zFR0pe9fKXUyJwx5gL7lmxSglyxnhBc6P1tO68J+9rH7+WXHL973U7alKN21s5lLywZa42rks0h1kmZ3EX6AegkqfXK3s5K1m2HbHIrs7u6ZpURtiP7ndUrcVqezxn5CGdKl59IxS6u3UKr3n9djiavvEBpdv6/GPWZryOeB12r2rCWsBwu64tuhZsFqRUqzK/Ql9F/P7J0fZqHeKOAWNRpJaKiYb+ix7mKLMlrsV49wrUZaN4TtcwtHnTA8V5NElZuTqCAhj3LFXi/zImAXYqlY5p/untEvVLIYPiYZZJ/twWiAiOb9iS9Yy7fEk0Zj/pXO64WEH6ISyhNLFewAa4zuJrXnQ5mvYr0lA82rLB1cFi8Z8sTfAZdiJSJC X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199021)(40470700004)(46966006)(36840700001)(8936002)(7696005)(6862004)(336012)(2906002)(47076005)(40460700003)(9686003)(36860700001)(86362001)(70586007)(52536014)(5660300002)(356005)(82740400003)(41300700001)(40480700001)(478600001)(70206006)(8676002)(4326008)(186003)(81166007)(55016003)(26005)(4744005)(82310400005)(33656002)(6506007)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 20:01:59.9801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 821a922d-d2a0-41e5-064b-08db347e4919 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9918 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Joe,=0A= =0A= > Add testcases for abs(), labs(), and llabs(). Test the bounds of the=0A= > given type, zero, and part of the full range of values for labs() and=0A= > llabs(). Test the full range for abs().=0A= =0A= How long do these tests take on older, slower cores? You're running=0A= over 20 billion tests in total - at say 10 cycles per test a 2GHz CPU=0A= would take 100 seconds which is way overkill for these basic functions.=0A= =0A= Try using a larger increment (eg. prime) so that you cover the range=0A= and the test will run within a second on a slow core. And for llabs it=0A= makes sense to add tests for the carry when the bottom 32 bits are=0A= zero to the top 32 bits (think 32-bit targets here).=0A= =0A= Cheers,=0A= Wilco=